Repository navigation
[HOLD for payment 2022-03-02] Conversation - A single message was sent 100s of times #7666
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Send a message in a conversation
Expected Result:
A single message should be seen in the conversation history.
Actual Result:
100s of repeated messages were sent to the other user.
Workaround:
No need.
Platform:
Where is this issue occurring?
- Web
Version Number: v1.1.38-1
Reproducible in staging?: Unknown
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
Issue reported by: @tgolen
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644440925115879
Activity
MelvinBot commentedon Feb 9, 2022
Triggered auto assignment to @pecanoro (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.conorpendergrast commentedon Feb 10, 2022
This hit me too, and it was so weird
VictoriaExpensify commentedon Feb 10, 2022
The same issue happened with @conorpendergrast this morning:
It appears that every time he tries to send me a new response, it resends that same message another couple of hundred times:
Also happened with Conor's 10ams so it seems to be an issue on his end rather than mine:
mallenexpensify commentedon Feb 10, 2022
Here's logs when it happened to me, also, my steps, since it happened right after I reopened my computer.
BUG: A message sent while my laptop was closed kept sending a couple dozen times and I got a notification ping for each.
Action Performed: Had production web open in Chrome, closed lid, opened lid 10-15 mins later
Expected Result: To see one new message
Actual Result: Saw ~2 dozen of the same message and got browser notifications for each. It stopped after I sent multiple messages to the user.
Platforms: web, production, Chrome
Version Number: v.1.1.37-2
Screenshots or Videos: in :thred:
StefStavri commentedon Feb 10, 2022
Also happened to @twisterdotcom and I at 12:25 UTC (i kept getting notification after notification for the same line)
Can't make it stop by closing the app and restarting unfortunately.
twisterdotcom commentedon Feb 10, 2022
I first sent that message to Stef at
Today at 12:18 PMUTC according to my desktop app (which isn't experiencing this)twisterdotcom commentedon Feb 10, 2022
Happened when I next sent a message to @muttmuure and then my test account pecan@expensivepie.com
Desktop, endless errors but no repeating message:
https://user-images.githubusercontent.com/9133401/153413258-3a65a126-9ba1-4683-824f-078227244ba4.mp4
Basically endless:
Mobile vid:
Still trying to get it off my phone
Logs from the recipient:
One such log: 6db5746a0dfa76f9-SAN
From the sender:
One example: 6db560f1683b773b-LHR
tgolen commentedon Feb 10, 2022
Here were the logs from when it happened to me yesterday.
The recipient (544 total):
The sender (554), on web:
kidroca commentedon Feb 10, 2022
38 remaining items
botify commentedon Feb 23, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.39-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-03-02. 🎊
[-]Conversation - A single message was sent 100s of times [/-][+][HOLD for payment 2022-03-02] Conversation - A single message was sent 100s of times [/+]tgolen commentedon Feb 23, 2022
Cool, thanks for that info! This is the backend code for the CORS header:
So, maybe we should just ad
app://to that? Isn't that a protocol though, not the host? PHP is doing things with the host there.kidroca commentedon Feb 23, 2022
The current code adds this
App/desktop/main.js
Line 176 in 853db57
It shouldn't be prefixed with
httpsBuuut it also changes the origin sent by the request (I geuss
$host) so it won't work unless we revert thatApp/desktop/main.js
Line 167 in 853db57
Also maybe there's some way to change
app://toexpensify://orapp://expensifyor something in that sensekidroca commentedon Feb 23, 2022
@NicMendonca, @tgolen
I'm sorry but I submitted the #7673 before there was an Upwork job and never applied for it
I've tracked any work around this ticket (including recreating the problem in Desktop today) in my hourly contract referencing this issue
Can we just close the Upwork job?
tgolen commentedon Feb 23, 2022
@NicMendonca Can you close the upwork job, please?
Maybe to fix the host/origin problem, the PHP code can also look at HTTP_REFERRER to see if it contains
app://. So it would look more like this:We would have to change this too:
kidroca commentedon Feb 23, 2022
Well just so you know both the referrer and origin are overridden here, so if you do decide to take this to the backend we should unset them on Desktop (which can happen after the server is updated)
App/desktop/main.js
Lines 167 to 169 in 853db57
mallenexpensify commentedon Mar 1, 2022
@kidroca is there still work being done here before filling out the Root Cause Analysis (RCA) doc?
https://docs.google.com/document/d/1OwX4QGqemKbm2yb1opwqIDrYkt8b5wskHcgYNwAKkzo/edit
kidroca commentedon Mar 1, 2022
Not that I know of.
I'll fill out the doc and post back
kidroca commentedon Mar 4, 2022
@mallenexpensify
I've filled the RCA
This ticket can be closed: #7666 (comment)
mallenexpensify commentedon Mar 4, 2022
Thanks @kidroca , closing.
cc @michaelhaxhiu , cuz it's RCA