Skip to content

[Due for payment 2026-04-17] Refactor ConfirmModal usage to useConfirmModal in workspace feature pages #76691

Closed

Description

@roryabraham

Coming from #68799 (comment)...

Problem

When every component mounts its own ConfirmModal in the component tree, it creates component bloat, memory overhead from multiple modal instances, and repetitive boilerplate code that makes the application harder to maintain.

Solution

Refactor ConfirmModal usage to useConfirmModal in the following files:

WorkspaceMemberDetailsPage.tsx
WorkspaceMembersPage.tsx
WorkspaceWorkflowsPage.tsx
WorkspaceWorkflowsApprovalsEditPage.tsx
WorkspaceInvoiceVBASection.tsx
WorkspaceReportsPage.tsx
ReportFieldsValueSettingsPage.tsx
ReportFieldsSettingsPage.tsx
ReportFieldsListValuesPage.tsx
AddNewCardPage.tsx
WorkspaceCompanyCardsSettingsPage.tsx
WorkspaceCompanyCardDetailsPage.tsx
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 4, 2025
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 4, 2025
  3. melvin-bot commented on Dec 4, 2025

    @melvin-bot

    Current assignee @ZhenjaHorbach is eligible for the External assigner, not assigning anyone new.

  4. melvin-bot commented on Dec 4, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. lorretheboy commented on Dec 4, 2025

    @lorretheboy
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Refactor ConfirmModal usage to useConfirmModal in workspace feature pages

    What is the root cause of that problem?

    Refactoring

    What changes do you think we should make in order to solve the problem?

    We should migrate to use ConfirmModal to useConfirmModal like what we did here in all pages

    const {showConfirmModal} = useConfirmModal();

    List files:

    WorkspaceMemberDetailsPage.tsx
    WorkspaceMembersPage.tsx
    WorkspaceWorkflowsPage.tsx
    WorkspaceWorkflowsApprovalsEditPage.tsx
    WorkspaceInvoiceVBASection.tsx
    WorkspaceReportsPage.tsx
    ReportFieldsValueSettingsPage.tsx
    ReportFieldsSettingsPage.tsx
    ReportFieldsListValuesPage.tsx
    AddNewCardPage.tsx
    WorkspaceCompanyCardsSettingsPage.tsx
    WorkspaceCompanyCardDetailsPage.tsx

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  6. github-actions commented on Dec 4, 2025

    @github-actions
    Contributor

    ⚠️ @lorretheboy Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  7. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 4, 2025
  8. 87 remaining items

  9. melvin-bot commented on Apr 10, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.57-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-04-17. 🎊

    For reference, here are some details about the assignees on this issue:

    • @waterim requires payment (Needs manual offer from BZ)
    • @ZhenjaHorbach requires payment through NewDot Manual Requests
    • @lorretheboy requires payment (Needs manual offer from BZ)
  10. melvin-bot commented on Apr 10, 2026

    @melvin-bot

    @ZhenjaHorbach @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. lorretheboy commented on Apr 11, 2026

    @lorretheboy
    Contributor

    May I ask for the price adjustment to reflect the actual effort since we have worked on multiple PRs (3 PRs) for refactoring and the testing is quite time consuming...

  12. ZhenjaHorbach commented on Apr 13, 2026

    @ZhenjaHorbach
    Contributor

    Agree
    This required a lot of time and effort
    But we had one regression 😢

    So I think $625 would be fair here for 3 PRs

  13. roryabraham commented on Apr 14, 2026

    @roryabraham
    ContributorAuthor

    👍🏼 to $625. It doesn't look like there's an upwork automation on this one where I can automatically adjust the price

  14. ZhenjaHorbach commented on Apr 17, 2026

    @ZhenjaHorbach
    Contributor

    And I don't think we need a checklist here
    Since it's a refactoring issue

    CC: @mallenexpensify

  15. roryabraham commented on Apr 17, 2026

    @roryabraham
    ContributorAuthor

    agree we don't need a checklist

  16. mallenexpensify commented on Apr 17, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @lorretheboy paid $625 via Upwork
    Contributor+: @ZhenjaHorbach due $625 via NewDot

    @lorretheboy can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022045196467550926825

  17. melvin-bot commented on Apr 17, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  18. mallenexpensify commented on Apr 18, 2026

    @mallenexpensify
    Contributor

    @lorretheboy paid, summary updated above. Thx.

  19. garrettmknight commented on Apr 23, 2026

    @garrettmknight
    Contributor

    $625 approved for @ZhenjaHorbach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions