You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-17] Refactor ConfirmModal usage to useConfirmModal in workspace feature pages #76691
When every component mounts its own ConfirmModal in the component tree, it creates component bloat, memory overhead from multiple modal instances, and repetitive boilerplate code that makes the application harder to maintain.
Solution
Refactor ConfirmModal usage to useConfirmModal in the following files:
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
⚠️@lorretheboy Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.57-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ZhenjaHorbach@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
May I ask for the price adjustment to reflect the actual effort since we have worked on multiple PRs (3 PRs) for refactoring and the testing is quite time consuming...
Activity
melvin-bot commentedon Dec 4, 2025
Current assignee @ZhenjaHorbach is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Dec 4, 2025
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lorretheboy commentedon Dec 4, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Refactor ConfirmModal usage to useConfirmModal in workspace feature pages
What is the root cause of that problem?
Refactoring
What changes do you think we should make in order to solve the problem?
We should migrate to use ConfirmModal to useConfirmModal like what we did here in all pages
App/src/components/MoneyReportHeader.tsx
Line 298 in 3f5906b
List files:
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
github-actions commentedon Dec 4, 2025
87 remaining items
melvin-bot commentedon Apr 10, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.57-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 10, 2026
@ZhenjaHorbach @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
lorretheboy commentedon Apr 11, 2026
May I ask for the price adjustment to reflect the actual effort since we have worked on multiple PRs (3 PRs) for refactoring and the testing is quite time consuming...
ZhenjaHorbach commentedon Apr 13, 2026
Agree
This required a lot of time and effort
But we had one regression 😢
So I think $625 would be fair here for 3 PRs
roryabraham commentedon Apr 14, 2026
👍🏼 to $625. It doesn't look like there's an upwork automation on this one where I can automatically adjust the price
ZhenjaHorbach commentedon Apr 17, 2026
And I don't think we need a checklist here
Since it's a refactoring issue
CC: @mallenexpensify
roryabraham commentedon Apr 17, 2026
agree we don't need a checklist
mallenexpensify commentedon Apr 17, 2026
Payment Summary
Contributor: @lorretheboy paid $625 via Upwork
Contributor+: @ZhenjaHorbach due $625 via NewDot
@lorretheboy can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022045196467550926825
melvin-bot commentedon Apr 17, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Apr 18, 2026
@lorretheboy paid, summary updated above. Thx.
garrettmknight commentedon Apr 23, 2026
$625 approved for @ZhenjaHorbach