You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-03] [Due for payment 2026-06-24] Refactor ConfirmModal usage to useConfirmModal in workspace accounting and general pages #76692
When every component mounts its own ConfirmModal in the component tree, it creates component bloat, memory overhead from multiple modal instances, and repetitive boilerplate code that makes the application harder to maintain.
Solution
Refactor ConfirmModal usage to useConfirmModal in the following files:
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
⚠️@thelullabyy Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
changed the title [-][Due for payment 2026-06-24] Refactor ConfirmModal usage to useConfirmModal in workspace accounting and general pages[/-][+][Due for payment 2026-07-03] [Due for payment 2026-06-24] Refactor ConfirmModal usage to useConfirmModal in workspace accounting and general pages[/+]on Jun 26, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.20-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ZhenjaHorbach / @thelullabyy@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
melvin-bot commentedon Dec 4, 2025
Current assignee @ZhenjaHorbach is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Dec 4, 2025
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.thelullabyy commentedon Dec 4, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Refactor ConfirmModal usage to useConfirmModal in workspace accounting and general pages
What is the root cause of that problem?
Improvement
What changes do you think we should make in order to solve the problem?
We need to update to all files below to use
useConfirmModal, we have done it in MoneyReportHeader.tsx file already. We can follow that patternNetSuiteExportExpensesDestinationSelectPage.tsx
NetSuiteImportCustomFieldView.tsx
SageIntacctEditUserDimensionsPage.tsx
PolicyAccountingPage.tsx
WorkspaceExpensifyCardDetailsPage.tsx
WorkspaceExpensifyCardPageEmptyState.tsx
WorkspaceEditCardLimitTypePage.tsx
WorkspaceEditCardLimitPage.tsx
WorkspaceOverviewPage.tsx
WorkspacesListPage.tsx
WorkspaceDowngradePage.tsx
WorkspaceReceiptPartnersPage.tsx
WorkspaceMoreFeaturesPage.tsx
WorkspaceDuplicateSelectFeaturesForm.tsx
WorkspaceResetBankAccountModal.tsx
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
github-actions commentedon Dec 4, 2025
abbasifaizan70 commentedon Dec 4, 2025
I would like to work on this.
84 remaining items
[-][Due for payment 2026-06-24] Refactor ConfirmModal usage to useConfirmModal in workspace accounting and general pages[/-][+][Due for payment 2026-07-03] [Due for payment 2026-06-24] Refactor ConfirmModal usage to useConfirmModal in workspace accounting and general pages[/+]melvin-bot commentedon Jun 26, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 26, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.20-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-07-03. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 26, 2026
@ZhenjaHorbach / @thelullabyy @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Jul 2, 2026
@ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jul 3, 2026
@ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jul 3, 2026
@ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!
ZhenjaHorbach commentedon Jul 3, 2026
@mallenexpensify
Now we can close this!
garrettmknight commentedon Jul 6, 2026
$1000 approved for @ZhenjaHorbach
laurenreidexpensify commentedon Aug 12, 2026
$1000 approved for @thelullabyy