Skip to content

[Due for payment 2026-07-03] [Due for payment 2026-06-24] Refactor ConfirmModal usage to useConfirmModal in workspace accounting and general pages #76692

Closed

Description

@roryabraham

Coming from #68799 (comment)...

Problem

When every component mounts its own ConfirmModal in the component tree, it creates component bloat, memory overhead from multiple modal instances, and repetitive boilerplate code that makes the application harder to maintain.

Solution

Refactor ConfirmModal usage to useConfirmModal in the following files:

NetSuiteExportExpensesDestinationSelectPage.tsx
NetSuiteImportCustomFieldView.tsx
SageIntacctEditUserDimensionsPage.tsx
PolicyAccountingPage.tsx
WorkspaceExpensifyCardDetailsPage.tsx
WorkspaceExpensifyCardPageEmptyState.tsx
WorkspaceEditCardLimitTypePage.tsx
WorkspaceEditCardLimitPage.tsx
WorkspaceOverviewPage.tsx
WorkspacesListPage.tsx
WorkspaceDowngradePage.tsx
WorkspaceReceiptPartnersPage.tsx
WorkspaceMoreFeaturesPage.tsx
WorkspaceDuplicateSelectFeaturesForm.tsx
WorkspaceResetBankAccountModal.tsx
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @ZhenjaHorbach

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 4, 2025
  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 4, 2025
  3. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 4, 2025
  4. melvin-bot commented on Dec 4, 2025

    @melvin-bot

    Current assignee @ZhenjaHorbach is eligible for the External assigner, not assigning anyone new.

  5. melvin-bot commented on Dec 4, 2025

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. thelullabyy commented on Dec 4, 2025

    @thelullabyy
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Refactor ConfirmModal usage to useConfirmModal in workspace accounting and general pages

    What is the root cause of that problem?

    Improvement

    What changes do you think we should make in order to solve the problem?

    We need to update to all files below to use useConfirmModal, we have done it in MoneyReportHeader.tsx file already. We can follow that pattern

    NetSuiteExportExpensesDestinationSelectPage.tsx
    NetSuiteImportCustomFieldView.tsx
    SageIntacctEditUserDimensionsPage.tsx
    PolicyAccountingPage.tsx
    WorkspaceExpensifyCardDetailsPage.tsx
    WorkspaceExpensifyCardPageEmptyState.tsx
    WorkspaceEditCardLimitTypePage.tsx
    WorkspaceEditCardLimitPage.tsx
    WorkspaceOverviewPage.tsx
    WorkspacesListPage.tsx
    WorkspaceDowngradePage.tsx
    WorkspaceReceiptPartnersPage.tsx
    WorkspaceMoreFeaturesPage.tsx
    WorkspaceDuplicateSelectFeaturesForm.tsx
    WorkspaceResetBankAccountModal.tsx

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. github-actions commented on Dec 4, 2025

    @github-actions
    Contributor

    ⚠️ @thelullabyy Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  8. abbasifaizan70 commented on Dec 4, 2025

    @abbasifaizan70
    Contributor

    I would like to work on this.

  9. 84 remaining items

  10. changed the title [-][Due for payment 2026-06-24] Refactor ConfirmModal usage to useConfirmModal in workspace accounting and general pages[/-] [+][Due for payment 2026-07-03] [Due for payment 2026-06-24] Refactor ConfirmModal usage to useConfirmModal in workspace accounting and general pages[/+] on Jun 26, 2026
  11. melvin-bot commented on Jun 26, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jun 26, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.20-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-03. 🎊

    For reference, here are some details about the assignees on this issue:

    • @waterim requires payment (Needs manual offer from BZ)
    • @ZhenjaHorbach requires payment through NewDot Manual Requests
    • @thelullabyy requires payment (Needs manual offer from BZ)
  13. melvin-bot commented on Jun 26, 2026

    @melvin-bot

    @ZhenjaHorbach / @thelullabyy @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  14. melvin-bot commented on Jul 2, 2026

    @melvin-bot

    @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. melvin-bot commented on Jul 3, 2026

    @melvin-bot

    @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. melvin-bot commented on Jul 3, 2026

    @melvin-bot

    @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!

  17. ZhenjaHorbach commented on Jul 3, 2026

    @ZhenjaHorbach
    Contributor

    Payment Summary

    Contributor: @thelullabyy due $1000 via NewDot Contributor+: @ZhenjaHorbach due $1000 via NewDot

    @mallenexpensify
    Now we can close this!

  18. garrettmknight commented on Jul 6, 2026

    @garrettmknight
    Contributor

    $1000 approved for @ZhenjaHorbach

  19. laurenreidexpensify commented on Aug 12, 2026

    @laurenreidexpensify
    Contributor

    $1000 approved for @thelullabyy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions