Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.2.72-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #74541
Email or phone of affected tester (no customers): ibellicotest+2154@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 11 / Chrome
App Component: Search
Action Performed:
Prerequisite: Account has at least one workspace.
- Open the Expensify app.
- Navigate to “Reports” > “Reports” (so page is already loaded for next steps)
- Open any workspace chat.
- Create two manual expenses.
- Turn off internet connection.
- Open the report of the just created expenses.
- Long tap and select both expenses.
- Tap on the dropdown menu and select "Hold"
- Enter any reason and hold the expenses.
- Note that a "This expense was put on hold" message appears on both previews.
- Navigate to "Reports" > "Reports"
- Note that report preview doesn´t show any violation.
- Turn on internet connection.
- Note that violation is still not visible.
- Open report and return.
- Note that violation is still not visible.
- Navigate to "Inbox" and return to "Reports".
- Note that violation is now displayed on report preview.
Expected Result:
When expenses are held while in offline mode, violation should be automatically visible on expenses preview on chat and also on "Reports".
Actual Result:
When expenses are held while in offline mode, violation is not visible on report preview on "Reports". Violation is still not visible when user returns to online mode. User has to navigate to "Inbox" and return to "Reports" to make the violation appear on report preview.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug7021139_1764889562673.V.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022001079686997417329
- Upwork Job ID: 2001079686997417329
- Last Price Increase: 2025-12-30
- Automatic offers:
- cretadn22 | Contributor | 110014406
Issue Owner
Current Issue Owner: @mallenexpensifyMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Dec 5, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.ashu75575 commentedon Dec 6, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
When expenses are put on hold while in offline mode from a workspace chat, the violation indicator doesn't appear on the report preview in the "Reports" page. The violation remains hidden even after reconnecting to the internet. Users must navigate to "Inbox" and back to "Reports" for the violation to finally appear.
What is the root cause of that problem?
The Reports page displays data from a cached search snapshot stored in Onyx. When we hold expenses, there are two different code paths:
holdMoneyRequestOnSearch()which properly updates the search snapshotputTransactionsOnHold()which does NOT update the search snapshotThe bug occurs in the workspace chat flow:
When holding expenses from a workspace chat (route:
SCREENS.SEARCH.MONEY_REQUEST_REPORT_HOLD_TRANSACTIONS), the code callsputTransactionsOnHold():This function updates the transaction violations in Onyx, but doesn't update the search snapshot. The Reports page continues reading from the stale snapshot cache, so the violation never appears until something else triggers a refresh (like navigating to Inbox).
What changes do you think we should make in order to solve the problem?
Solution: Use
holdMoneyRequestOnSearch()for both flows, since both routes are in the search context and need the snapshot updated.Change in
SearchHoldReasonPage.tsx(around line 27):Before:
After:
Additional change in
libs/actions/Search.ts-holdMoneyRequestOnSearch()function:Currently,
holdMoneyRequestOnSearch()only updates the child action count but doesn't add optimistic violation updates. We need to add the violation to show the UI changes immediately while offline:Note: You'll need to ensure
allTransactionViolationsis accessible in this function (either passed as a parameter or imported).What alternative solutions did you explore?
N/A
imadirtydog commentedon Dec 6, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Violation is not visible on preview on "Reports" if expenses are held offline. #76816
What is the root cause of that problem?
When we hold the expense offline, the search snapshot does not get updated with the violation.
What changes do you think we should make in order to solve the problem?
We could update the snapshot optimistically around here
App/src/libs/actions/IOU.ts
Line 12347 in d34df44
We could also apply similar logic to unholdRequest, mergeDuplicates, resolveDuplicates etc.
What alternative solutions did you explore? (Optional)
It could be possible to pull in violation data straight from onyx in
App/src/components/SelectionListWithSections/Search/ExpenseReportListItem.tsx
Line 23 in d34df44
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
mallenexpensify commentedon Dec 9, 2025
Can't stop thinking about how 'batching' or 'bucketing' related issues could help fix them more efficiently, espec for offline-related issues (and... ones that are edge cases).
I think it might be a better approach than just closing them (or... fixing one-off too).
More soon....
[-]Reports - Violation is not visible on preview on "Reports" if expenses are held offline.[/-][+][$250] Reports - Violation is not visible on preview on "Reports" if expenses are held offline.[/+]melvin-bot commentedon Dec 16, 2025
Job added to Upwork: https://www.upwork.com/jobs/~022001079686997417329
31 remaining items
ZhenjaHorbach commentedon Jan 16, 2026
The PR is in prod
The regression period will end on January 20
ZhenjaHorbach commentedon Jan 20, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Unfortunately, I did not find a suitable PR
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-e44c-aeb4-dafb-cab0c70b4a94ZhenjaHorbach commentedon Jan 20, 2026
@mallenexpensify
We are ready for payment!
mallenexpensify commentedon Jan 21, 2026
Payment Summary
Contributor: @cretadn22 paid $250 via Upwork
Contributor+: @ZhenjaHorbach due $250 via NewDot
^ Test case created
Thx!
garrettmknight commentedon Jan 21, 2026
$250 approved for @ZhenjaHorbach