Repository navigation
Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributorsWeeklyKSv2KSv2
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.2.73-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: #76384
Email or phone of affected tester (no customers): soidjnsodnjsoidjiosnj@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Open FAB > Track distance > Manual
- Enter amount > Next
Expected Result:
Distance field will show the correct value on confirm page
Actual Result:
Distance field shows Pending on confirm page
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug7021902_1764960511329.5.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021997942232073215377
- Upwork Job ID: 1997942232073215377
- Last Price Increase: 2025-12-08
Issue Owner
Current Issue Owner: @dylanexpensifyMetadata
Metadata
Assignees
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributorsWeeklyKSv2KSv2
Activity
melvin-bot commentedon Dec 5, 2025
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 5, 2025
Triggered auto assignment to @cristipaval (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 5, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 5, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Nodebrute commentedon Dec 5, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance field shows Pending on confirm page
What is the root cause of that problem?
This change happened after in this pr #75542 we allowed zero amount expenses. In this pr we have added
transaction?.comment?.customUnit?.namewhich is undefinedApp/src/libs/TransactionUtils/index.ts
Line 1401 in 28474b3
What changes do you think we should make in order to solve the problem?
Solution one
We can check
transaction?.comment?.customUnit?.quantity != null)this will work for 0 values too.Solution 2
We can check for
customUnitRateIDWhat alternative solutions did you explore? (Optional)
We can add
nameas 'Distance' optimisticallydylanexpensify commentedon Dec 8, 2025
Hmm, @cristipaval I can't repro
dylanexpensify commentedon Dec 8, 2025
10 remaining items
PiyushChandra17 commentedon Dec 8, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance field is showing pending in Confirm Page
What is the root cause of that problem?
We are checking for two conditions here in order to show Distance field,
if any of these conditions are not satified, hence has
falsyvalue then it's showingiou.fieldPendinghereWhat changes do you think we should make in order to solve the problem?
We need check both conditions
hasRoute && unit,What alternative solutions did you explore? (Optional)
n/A
Result
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Gonals commentedon Dec 8, 2025
FIxed and deployed. Closing
Add proposal in official Expensify format following template and best…
[-][$250] Expense - Distance field shows Pending on confirm page[/-][+][Due for payment 2025-12-17] [$250] Expense - Distance field shows Pending on confirm page[/+]melvin-bot commentedon Dec 10, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 10, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.74-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-12-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 10, 2025
@Ollyws @dylanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]