You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Missing Add expense button when report is created offline on instant submission #77145
Version Number: 9.2.74-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory Email or phone of affected tester (no customers):jnsdonsoijnods@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Critical User Impact Device used: Mac 26.1 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Submission frequency is Instantly.
Disable Add approvals and Make or track payments.
Go to staging.new.expensify.com
Go to workspace chat.
Go offline.
Click + > Create report.
Expected Result:
Add expense button will be shown when report is created offline.
Actual Result:
Add expense button is missing when report is created offline when workspace is on instant submission.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
Missing Add expense button when report is created offline on instant submission
What is the root cause of that problem?
When a report is created offline with instant submission enabled, the report actions are not loaded yet. The isAwaitingFirstLevelApprovalNew then tries to find the action in an empty array, which returns undefined. When is called, it returns null, and the function incorrectly returns false for empty reports, preventing users from adding the first transaction.
This bug was already there but it affected the UI in PR #76504, which replaced (deprecated) with isAwaitingFirstLevelApprovalNew. The old function used getSubmitToAccountID(policy, report), which only needed policy data and didn't require report actions to be loaded, so it worked correctly offline. The new function requires report actions to be loaded, causing the issue when they're not available yet.
What changes do you think we should make in order to solve the problem?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Activity
melvin-bot commentedon Dec 9, 2025
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 9, 2025
Triggered auto assignment to @rlinoz (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 9, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 9, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
rlinoz commentedon Dec 9, 2025
I believe it is coming from #76504
DylanDylann commentedon Dec 9, 2025
@rlinoz Let me check it
Nodebrute commentedon Dec 9, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Missing Add expense button when report is created offline on instant submission
What is the root cause of that problem?
When a report is created offline with
instant submissionenabled, the report actions are not loaded yet. TheisAwaitingFirstLevelApprovalNewthen tries to find the action in an empty array, which returnsundefined. When is called, it returns null, and the function incorrectly returns false for empty reports, preventing users from adding the first transaction.This bug was already there but it affected the UI in PR #76504, which replaced (deprecated) with
isAwaitingFirstLevelApprovalNew. The old function usedgetSubmitToAccountID(policy, report), which only needed policy data and didn't require report actions to be loaded, so it worked correctly offline. The new function requires report actions to be loaded, causing the issue when they're not available yet.What changes do you think we should make in order to solve the problem?
When report actions are not loaded yet (e.g., offline scenario), check if report is empty and if empty, allow adding transactions by returning
trueWe should add this below line of code herehttps://github.com/Expensify/App/blob/main/src/libs/ReportUtils.ts#L2004
What alternative solutions did you explore? (Optional)
3 remaining items
DylanDylann commentedon Dec 10, 2025
The offending PR got reverted
IuliiaHerets commentedon Dec 10, 2025
Issue is not reproducible by QA team on Windows 10/Chrome v9.2.74-8
bandicam.2025-12-10.10-55-55-624.mp4
yuwenmemon commentedon Dec 10, 2025
Thanks!
m-natarajan commentedon Dec 14, 2025
Issue repro in v9.2.78-0 on Web and Android and iOS, Not repro in production. Added the deploy blocker label as well
Recording.2073.mp4
ScreenRecording_12-14-2025.18-25-45_1.MP4
melvin-bot commentedon Dec 14, 2025
Triggered auto assignment to @jasperhuangg (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 14, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 14, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
rlinoz commentedon Dec 15, 2025
This is for a new checklist and I think it is best if it is handled in the new issue I think #77591