Skip to content

[CFI] [$125] Global “Create (+)” Button and Global Green “Scan” Button Missing Hover Tooltips #77472

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.75-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation (hyperlinked to channel name): #Migrate

Action Performed:

  1. Log into New Expensify (Web)
  2. Locate the global Create (+) button in the UI
  3. Hover over the button
  4. Locate the global Green Scan button
  5. Hover over the button

Expected Result:

Both buttons should display clear, descriptive hover tooltips

Global Create: "Create"
Global Scan: "Scan"

Actual Result:

No tooltip appears when hovering over the Global create (+) button and Green scan (+) button

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

View all open jobs on GitHub

Recording.2058.mp4
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021999430306942407520
  • Upwork Job ID: 1999430306942407520
  • Last Price Increase: 2025-12-12
  • Automatic offers:
    • nyomanjyotisa | Contributor | 109798230
Issue OwnerCurrent Issue Owner: @francoisl

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 12, 2025
  2. melvin-bot commented on Dec 12, 2025

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nyomanjyotisa commented on Dec 12, 2025

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Global "Create (+)" Button and Global Green "Scan" Button Missing Hover Tooltips

    What is the root cause of that problem?

    FloatingActionButton and FloatingReceiptButton components don't have Tooltip wrappers, so hover tooltips don't appear

    if (isLHBVisible) {
    return (
    <PressableWithoutFeedback
    ref={(el) => {
    fabPressable.current = el ?? null;
    if (buttonRef && 'current' in buttonRef) {
    buttonRef.current = el ?? null;
    }
    }}
    style={[
    styles.navigationTabBarFABItem,
    // Prevent text selection on touch devices (e.g. on long press)
    canUseTouchScreen() && styles.userSelectNone,
    styles.flex1,
    ]}
    accessibilityLabel={accessibilityLabel}
    onPress={toggleFabAction}
    onLongPress={longPressFabAction}
    role={role}
    shouldUseHapticsOnLongPress
    testID="floating-action-button"
    >
    {({hovered}) => {
    isHovered.set(hovered);
    return (
    <Animated.View
    style={[styles.floatingActionButton, {borderRadius}, styles.floatingActionButtonSmall, animatedStyle]}
    testID="fab-animated-container"
    >
    <Svg
    width={fabSize}
    height={fabSize}
    >
    <AnimatedPath
    d={isLHBVisible ? SMALL_FAB_PATH : FAB_PATH}
    fill={icon}
    />
    </Svg>
    </Animated.View>
    );
    }}
    </PressableWithoutFeedback>
    );
    }

    return (
    <PressableWithoutFeedback
    ref={(el) => {
    fabPressable.current = el ?? null;
    }}
    style={[
    styles.navigationTabBarFABItem,
    // Prevent text selection on touch devices (e.g. on long press)
    canUseTouchScreen() && styles.userSelectNone,
    ]}
    accessibilityLabel={accessibilityLabel}
    onPress={toggleFabAction}
    role={role}
    shouldUseHapticsOnLongPress
    testID="floating-receipt-button"
    >
    {({hovered}) => (
    <View
    style={[styles.floatingActionButton, {borderRadius}, styles.floatingActionButtonSmall, hovered && {backgroundColor: successHover}]}
    testID="floating-receipt-button-container"
    >
    <Icon
    fill={textLight}
    src={ReceiptPlus}
    width={variables.iconSizeSmall}
    height={variables.iconSizeSmall}
    />
    </View>
    )}
    </PressableWithoutFeedback>
    );

    Other buttons in the codebase use Tooltip wrappers (e.g., the Create button in the composer)

    <Tooltip text={translate('common.create')}>
    <PressableWithFeedback
    ref={actionButtonRef}
    onPress={(e) => {
    e?.preventDefault();
    if (!isFocused) {
    return;
    }
    onAddActionPressed();
    // Drop focus to avoid blue focus ring.
    actionButtonRef.current?.blur();
    setMenuVisibility(!isMenuVisible);
    }}
    style={styles.composerSizeButton}
    disabled={disabled}
    role={CONST.ROLE.BUTTON}
    accessibilityLabel={translate('common.create')}
    >
    <Icon
    fill={theme.icon}
    src={Expensicons.Plus}
    />
    </PressableWithFeedback>
    </Tooltip>

    What changes do you think we should make in order to solve the problem?

    Wrap these buttons with Tooltip components using the same translation keys already used for their accessibilityLabel props, or use other appropriate translation key

    if (isLHBVisible) {
    return (
    <PressableWithoutFeedback
    ref={(el) => {
    fabPressable.current = el ?? null;
    if (buttonRef && 'current' in buttonRef) {
    buttonRef.current = el ?? null;
    }
    }}
    style={[
    styles.navigationTabBarFABItem,
    // Prevent text selection on touch devices (e.g. on long press)
    canUseTouchScreen() && styles.userSelectNone,
    styles.flex1,
    ]}
    accessibilityLabel={accessibilityLabel}
    onPress={toggleFabAction}
    onLongPress={longPressFabAction}
    role={role}
    shouldUseHapticsOnLongPress
    testID="floating-action-button"
    >
    {({hovered}) => {
    isHovered.set(hovered);
    return (
    <Animated.View
    style={[styles.floatingActionButton, {borderRadius}, styles.floatingActionButtonSmall, animatedStyle]}
    testID="fab-animated-container"
    >
    <Svg
    width={fabSize}
    height={fabSize}
    >
    <AnimatedPath
    d={isLHBVisible ? SMALL_FAB_PATH : FAB_PATH}
    fill={icon}
    />
    </Svg>
    </Animated.View>
    );
    }}
    </PressableWithoutFeedback>
    );
    }

    return (
    <PressableWithoutFeedback
    ref={(el) => {
    fabPressable.current = el ?? null;
    }}
    style={[
    styles.navigationTabBarFABItem,
    // Prevent text selection on touch devices (e.g. on long press)
    canUseTouchScreen() && styles.userSelectNone,
    ]}
    accessibilityLabel={accessibilityLabel}
    onPress={toggleFabAction}
    role={role}
    shouldUseHapticsOnLongPress
    testID="floating-receipt-button"
    >
    {({hovered}) => (
    <View
    style={[styles.floatingActionButton, {borderRadius}, styles.floatingActionButtonSmall, hovered && {backgroundColor: successHover}]}
    testID="floating-receipt-button-container"
    >
    <Icon
    fill={textLight}
    src={ReceiptPlus}
    width={variables.iconSizeSmall}
    height={variables.iconSizeSmall}
    />
    </View>
    )}
    </PressableWithoutFeedback>
    );

    What alternative solutions did you explore? (Optional)

    None

  4. abbasifaizan70 commented on Dec 12, 2025

    @abbasifaizan70
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On New Expensify (Web), hovering over the global Create (+) button and the global Green Scan button does not display any tooltip, which reduces discoverability and clarity for mouse/trackpad users.

    What is the root cause of that problem?

    The global floating buttons already have accessibilityLabel values, but they were not wrapped with the app’s Tooltip component, so nothing renders on hover in web environments.

    • Create (+) (App/src/components/FloatingActionButton.tsx): was rendered without a tooltip wrapper (and the wide-layout branch also hardcoded label/role instead of using the passed props).
    • Green Scan (App/src/components/FloatingReceiptButton.tsx): was rendered without a tooltip wrapper.
    • Camera-style Scan FAB (where applicable) (App/src/components/FloatingCameraButton/BaseFloatingCameraButton.tsx): was also rendered without a tooltip wrapper.

    What changes do you think we should make in order to solve the problem?

    Wrap the global floating buttons with the existing Tooltip component and use the existing accessibilityLabel text as the tooltip content.

    Code changes (key snippets):

    1) FloatingActionButton (Create +)

    import Tooltip from './Tooltip';
    
    // ...
    
    if (isLHBVisible) {
        return (
            <Tooltip text={accessibilityLabel}>
                <PressableWithoutFeedback
                    accessibilityLabel={accessibilityLabel}
                    role={role}
                    // ...
                >
                    {/* ... */}
                </PressableWithoutFeedback>
            </Tooltip>
        );
    }
    
    return (
        <Tooltip text={accessibilityLabel}>
            <PressableWithFeedback
                accessibilityLabel={accessibilityLabel}
                role={role}
                // ...
            >
                {/* ... */}
            </PressableWithFeedback>
        </Tooltip>
    );

    2) FloatingReceiptButton (Green Scan)

    import Tooltip from './Tooltip';
    
    // ...
    
    return (
        <Tooltip text={accessibilityLabel}>
            <PressableWithoutFeedback
                accessibilityLabel={accessibilityLabel}
                role={role}
                // ...
            >
                {/* ... */}
            </PressableWithoutFeedback>
        </Tooltip>
    );

    3) BaseFloatingCameraButton (scan FAB parity where used on web)

    import Tooltip from '@components/Tooltip';
    
    // ...
    
    return (
        <Tooltip text={translate('sidebarScreen.fabScanReceiptExplained')}>
            <PressableWithoutFeedback
                accessibilityLabel={translate('sidebarScreen.fabScanReceiptExplained')}
                role={CONST.ROLE.BUTTON}
                // ...
            >
                {/* ... */}
            </PressableWithoutFeedback>
        </Tooltip>
    );

    Why this works:

    • The existing Tooltip implementation already disables itself on devices without hover support, so the change is web-focused and should not affect touch-only devices.
    • Tooltip text is sourced from existing translated labels (already used for accessibility).

    What alternative solutions did you explore? (Optional)

    Alternative 1: Add native HTML title attributes

    • Rejected: inconsistent styling/behavior across browsers, and it bypasses the existing tooltip system used elsewhere in the app.

    Alternative 2: Implement a bespoke tooltip just for FABs

    • Rejected: unnecessary duplication; the app already has a Tooltip component designed for this.

    Demo

    Screen.Recording.2025-12-12.at.2.43.06.PM.mov
  5. changed the title [-]Global “Create (+)” Button and Global Green “Scan” Button Missing Hover Tooltips[/-] [+][$125] Global “Create (+)” Button and Global Green “Scan” Button Missing Hover Tooltips[/+] on Dec 12, 2025
  6. melvin-bot commented on Dec 12, 2025

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 12, 2025
  8. melvin-bot commented on Dec 12, 2025

    @melvin-bot
  9. changed the title [-][$125] Global “Create (+)” Button and Global Green “Scan” Button Missing Hover Tooltips[/-] [+][CFI] [$125] Global “Create (+)” Button and Global Green “Scan” Button Missing Hover Tooltips[/+] on Dec 12, 2025
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 12, 2025
  11. 8 remaining items

  12. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 12, 2025
  13. melvin-bot commented on Dec 12, 2025

    @melvin-bot

    📣 @nyomanjyotisa 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  14. melvin-bot commented on Jan 8, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @francoisl, @trjExpensify, @nyomanjyotisa, @thesahindia eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  15. thesahindia commented on Jan 14, 2026

    @thesahindia
    Member

    @trjExpensify, this is ready for payment.

  16. thesahindia commented on Jan 14, 2026

    @thesahindia
    Member

    Simple fix. No need for checklist.

  17. trjExpensify commented on Jan 15, 2026

    @trjExpensify
    Contributor

    Thanks! Payment summary as follows:

    Paid, closing!

  18. garrettmknight commented on May 21, 2026

    @garrettmknight
    Contributor

    $125 approved for @thesahindia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions