Skip to content

Tax - Tax rate does not change after changing currency when submitting expense from self DM #77621

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.78-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #76636
Email or phone of affected tester (no customers): osidjosidjniosdjo@gmail.comwe
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Account has self DM.
  • Workspace has enabled Tax rates feature.

Configure tax settings below in Taxes page:

  • Workspace currency default tax rate - 5%.
  • Workspace foreign default tax rate - 10%.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Create an expense in default currency.
  4. Click Submit it to someone.
  5. Select the workspace with tax rates.
  6. On confirm page, click Amount.
  7. Change the currency and save it.

Expected Result:

Tax rate will change to 10%, which is the workspace foreign default tax rate.

Actual Result:

Tax rate still remains at 5%.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 13, 2025
  2. melvin-bot commented on Dec 13, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Dec 13, 2025

    @melvin-bot

    Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Dec 13, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Dec 13, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. koko57 commented on Dec 15, 2025

    @koko57
    Contributor

    probably from my PR I will check it today cc @cristipaval @parasharrajat

  7. koko57 commented on Dec 15, 2025

    @koko57
    Contributor

    @cristipaval just to make sure - we want to change the tax rate when currency changes?

  8. 12 remaining items

  9. cristipaval commented on Dec 22, 2025

    @cristipaval
    Contributor

    @koko57, Classic automatically updates the tax and the tax amount when the currency is changed

  10. melvin-bot commented on Jan 17, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @cristipaval, @parasharrajat, @koko57, @dylanexpensify eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  11. melvin-bot commented on Jan 22, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. melvin-bot commented on Jan 22, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  13. cristipaval commented on Mar 4, 2026

    @cristipaval
    Contributor

    this was fixed when we re-added the tax fields for unreported expenses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions