Skip to content

Tax - Tax amount is not reset after changing workspace and can exceed tax rate limit #77631

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.78-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #76636
Email or phone of affected tester (no customers): jsodijsodnsdojoij2@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Account has self DM.
  • Create two workspaces - A and B.
  • Workspace A is the default workspace.
  • Enable Taxes for workspace A and B.
  • Workspace B has tax rate 15% (as long as workspace A does not have the same rate).
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Create an expense with default rate 0%.
  4. Click Submit it to someone.
  5. Select workspace B.
  6. On confirm page, click Tax field and select tax rate 15%.
  7. Click RHP back button.
  8. Select workspace A.
  9. On confirm page, click Tax amount field and click Enter.
    → Error shows up because tax amount is larger than the maximum tax amount.
  10. Click RHP back button.
  11. Click Create expense.
  12. Open the submitted expense.
    → Expense can be submitted despite having tax amount larger than the limit.

Also, the same issue could happen with the steps listed here. Let's make sure we test that flow as well when we test the fix PR.

Expected Result:

In Step 9, after changing back to workspace A, Tax rate and Tax amount field should reset.

Actual Result:

In Step 9, after changing back to workspace A, Tax rate field changes to a different rate (originally it was 0%, then changed to 5%). Tax amount field does not reset and it still retains at the amount that is equivalent to 15% rate from workspace B, which is now beyond the 5% rate limit.

In Step 12, the submitted expense can be submitted to workspace despite having tax amount larger than the limit.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7028933_1765651634957.25.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @koko57

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 13, 2025
  2. melvin-bot commented on Dec 13, 2025

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. github-actions commented on Dec 13, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Dec 13, 2025

    @melvin-bot

    Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Dec 13, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. nkuoch commented on Dec 14, 2025

    @nkuoch
    Contributor

    Maybe coming from #76636?

  7. koko57 commented on Dec 15, 2025

    @koko57
    Contributor

    I will check it today cc @cristipaval @parasharrajat

  8. koko57 commented on Dec 15, 2025

    @koko57
    Contributor

    @cristipaval - should the value reset, like it's suggested

    In Step 9, after changing back to workspace A, Tax rate and Tax amount field should reset.

    or should we show an error?

  9. 39 remaining items

  10. cristipaval commented on Dec 29, 2025

    @cristipaval
    Contributor

    yeah, making it a Weekly in the meantime

  11. dylanexpensify commented on Jan 6, 2026

    @dylanexpensify
    Contributor

    nice

  12. dylanexpensify commented on Jan 13, 2026

    @dylanexpensify
    Contributor

    Ongoing

  13. dylanexpensify commented on Jan 20, 2026

    @dylanexpensify
    Contributor

    Same

  14. dylanexpensify commented on Jan 27, 2026

    @dylanexpensify
    Contributor

    @koko57 how're we doing?

  15. koko57 commented on Jan 28, 2026

    @koko57
    Contributor

    @dylanexpensify didn't have time to work on this one - I was busy with Per diem field. Now I need to jump into BBA project, so I don't have capacity today

  16. koko57 commented on Feb 2, 2026

    @koko57
    Contributor

    I'll have some capacity this week to continue with this issue. Looking into it today

  17. koko57 commented on Feb 4, 2026

    @koko57
    Contributor

    I have 2 PRs in active review, one of them for Create Per Diem, so I need to leave it for later. Will get back to it as soon as it will be possible

  18. koko57 commented on Feb 9, 2026

    @koko57
    Contributor

    I've opened a draft PR for this issue: #81888, but I need to test it thoroughly and complete the checklist. I'll do it tomorrow

  19. koko57 commented on Feb 10, 2026

    @koko57
    Contributor

    Because we base the differentiation on the tax value and the tax id we have one edge case that the name will be displayed differently (it will be the tax rate name of the chosen policy when submitting). But it doesn't result in submitting the expense with error. I explained it in the test steps

    When you have 2 workspaces - A and B and instead of changing the value you will change one of the default tax rates' name - on the confirmation screen you will see the chosen workspace tax rate name.
    Example:
    Workspace A (default) - Tax Exempt (0%) and Tax Rate 1 (5%)
    Workspace B - Tax Exempt (0%) and Custom Rate name 1 (5%)
    -> when self DM created it will display Tax Rate 1, when submitting to Workspace B - the name displayed will be Custom Rate name 1 (5%)
    The error also won't be shown because the value matches and the tax amount is also correct for the other workspace. The expense will also be submitted without any error.

    PR opened for review

  20. cristipaval commented on Mar 4, 2026

    @cristipaval
    Contributor

    this is in prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions