You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Reports - Delete option is missing for unreported expense in Reports > Expenses #77752
Version Number: 9.2.78-6 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#77207 Email or phone of affected tester (no customers):sjnodsjodijsosjdo1@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Mac 26.1 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Account has self DM.
Go to staging.new.expensify.com
Go to self DM.
Create an expense.
Go to Reports > Expenses.
Select the expense via checkbox.
Click dropdown button.
Expected Result:
Delete option should be present.
Actual Result:
Delete option is missing for unreported expense in Reports > Expenses.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
Reports - Delete option is missing for unreported expense in Reports > Expenses
What is the root cause of that problem?
In SearchPage, when determining whether to show the delete option, we looks up the parent report using the transaction reportID. For unreported expenses, transaction.reportID is CONST.REPORT.UNREPORTED_REPORT_ID (0), so it return early and the delete option is hidden
@DylanDylann Looks like we still need to use both allReports and snapshot (search result) data, see #77207 (comment) as well. Or we can try to fix search result data to include unreported expense data, which seems more clean - search result will be self-sufficient then.
@luacmartins happy to hear your thoughts on this too!
@lakchote Hmm, I'd like to ask for demotion given the impact of this issue is moderate. So, we don't need to rush fixing it and avoid reverting the PR to block subsequent tasks.
Activity
melvin-bot commentedon Dec 16, 2025
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 16, 2025
Triggered auto assignment to @lakchote (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 16, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 16, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lakchote commentedon Dec 16, 2025
Culprit PR: #77207
cc @DylanDylann @eh2077 @luacmartins
nyomanjyotisa commentedon Dec 16, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Reports - Delete option is missing for unreported expense in Reports > Expenses
What is the root cause of that problem?
In
SearchPage, when determining whether to show the delete option, we looks up the parent report using the transactionreportID. For unreported expenses,transaction.reportIDisCONST.REPORT.UNREPORTED_REPORT_ID(0), so it return early and the delete option is hiddenApp/src/pages/Search/SearchPage.tsx
Lines 681 to 684 in 5a8a078
What changes do you think we should make in order to solve the problem?
Handle unreported expenses by finding the self-DM report when the transaction
reportIDisCONST.REPORT.UNREPORTED_REPORT_IDApp/src/pages/Search/SearchPage.tsx
Lines 674 to 691 in 5a8a078
What alternative solutions did you explore? (Optional)
None
eh2077 commentedon Dec 16, 2025
@DylanDylann Looks like we still need to use both
allReportsand snapshot (search result) data, see #77207 (comment) as well. Or we can try to fix search result data to include unreported expense data, which seems more clean - search result will be self-sufficient then.@luacmartins happy to hear your thoughts on this too!
eh2077 commentedon Dec 16, 2025
@lakchote Hmm, I'd like to ask for demotion given the impact of this issue is moderate. So, we don't need to rush fixing it and avoid reverting the PR to block subsequent tasks.
lakchote commentedon Dec 16, 2025
Opening up a revert PR as per this discussion.
lakchote commentedon Dec 16, 2025
Unassigning since no work was done to fix the issue,
Revert PR is here: #77787
m-natarajan commentedon Dec 16, 2025
Not reproduce, MacOS Monterey / Chrome, Web and Xiaomi Redmi Note 10 / Android 12 v9.2.78-8
Screen.Recording.2025-12-16.at.23.35.38.mp4
Screenrecorder-2025-12-16-23-41-57-997.mp4
lakchote commentedon Dec 18, 2025
Closing since it's not reproducible anymore.