[$500] IOS - App jumped after request the money from user

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Launch the app and log in with any account
Tap on any user
Tap on plus button
Select Request Money
Put amount and tap Continue

Expected Result:

App should continue the action without jumping after request the money from user

Actual Result:

App jumped after request the money from user

Workaround:

Unknown

Platform:

Where is this issue occurring?

iOS

Version Number: 1.1.39.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Image.from.iOS.17.MP4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@danieldoglas

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

The expected result is not clear to me. What do you mean by jumping?

@danieldoglas

@danieldoglas At the timeline 0.10 sec in the video attached, there's weird jerk after completing IOU and returning back to chat again.

@danieldoglas

@danieldoglas Huh... This is 4 days overdue. Who can take care of this?

@danieldoglas

@danieldoglas Still overdue 6 days?! Let's take care of this!

@Christinadobrzyn

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Ok, setting this as External since we won't need any changes on backend to fix it.

Proposal

The jumping seems to happen when keyboard is still not completely hidden when message animation begins(maybe due to layout shifts) while going back to Chat Screen.

As we are always going back to the Chat Screen after pressing the button regardless of success or failure of the action performed. So, we can immediately hide the keyboard on button press using Keyboard.dismiss() so that the keyboard will already be hidden when we go back.

Proposal

It seems a latency closing of the keyboard. We can check if the virtual keyboard is opening then we add dismiss for it incomponentWillUnmount
File locate need to add: https://github.com/Expensify/App/blob/main/src/components/IOUConfirmationList.js

componentWillUnmount() {
        if(VirtualKeyboard.isOpen()) {
            Keyboard.dismiss();
        }
    }

If Regaron's proposal is legal to do please go ahead with him. I saw he is still in progress with his first PR.

@pecanoro

@pecanoro @rushatgabhane Could you guys take a look into the proposal?

@Regaron

Hmm, I can't repro this bug. iOS 15.0, v1.1.42-6

@Regaron @phivh are you able to repro this bug on main?

Screen.Recording.2022-03-16.at.8.29.27.PM.mov

@rushatgabhane

@rushatgabhane it seems happening in real device, with older phone it could jump slower than my video here.
https://user-images.githubusercontent.com/5449119/158930422-36d9dfa0-e764-4c8c-a311-5255a01fc9ea.MOV

I am really confused about this bug, I don't see anything wrong in any of those videos, what is it supposed to happen?

I saw it more noticeable on send money action than request money.

@Regaron

I saw it more noticeable on send money action than request money.

Hmm, both flows are essentially identical. I don't see any reason why it would be more noticable on send money action

@Regaron @phivh could you please help me understand, how does it look like before and after your suggested fix? (Video will be great)

I am going to close this issue since it's really unclear what the bug is or what the behavior is supposed to be.

Might be a bit late but here is what I've seen:

App Jumping:

Screen.Recording.2022-04-02.at.10.03.11.AM.mov

Proposal:

Screen.Recording.2022-04-02.at.10.07.38.AM.mov

Navigation Menu

Repository navigation

[$500] IOS - App jumped after request the money from user #7777

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

15 remaining items

Proposal

Proposal

App Jumping:

Proposal:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$500] IOS - App jumped after request the money from user #7777

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Activity

MelvinBot commented on Feb 16, 2022

danieldoglas commented on Feb 16, 2022

kavimuru commented on Feb 17, 2022

MelvinBot commented on Feb 21, 2022

MelvinBot commented on Feb 23, 2022

MelvinBot commented on Feb 23, 2022

danieldoglas commented on Feb 23, 2022

15 remaining items

Regaron commented on Mar 12, 2022

Proposal

phivh commented on Mar 14, 2022

Proposal

phivh commented on Mar 15, 2022

rushatgabhane commented on Mar 16, 2022

phivh commented on Mar 18, 2022

pecanoro commented on Mar 18, 2022

Regaron commented on Mar 18, 2022

rushatgabhane commented on Mar 23, 2022

pecanoro commented on Apr 1, 2022

Regaron commented on Apr 2, 2022

App Jumping:

Proposal:

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions