[Due for payment 2026-01-07] [$250] Reports - "Reset Filters" is not displayed on filters page when "Group By" filter is applied

@twisterdotcom

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.2.79-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2402/folder/13176922/41237509/1080011226
Email or phone of affected tester (no customers): ibellicotest+2230@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 11 / Chrome
App Component: Search

Action Performed:

Prerequisite: Account has at least one workspace.

Open the staging.new.expensify.com website.
Navigate to "Reports" > "Expenses"
Tap on "Filters"
Open any filter except "Group By" and apply any option.
Note that after selected filter is saved, a "Reset Filters" option appears on the top right corner on filters page.
Reset the applied filter.
Tap on "Group By" and select any option.
Tap on "Save"
When landing on filters page, note that "Reset Filters" option is not displayed on the top right corner.

Expected Result:

When user applies any advanced filter, a "Reset Filters" option should be visible on the top right corner on filters page.

Actual Result:

When user applies the "Group By" advanced filter, "Reset Filters" option is not visible on the top right corner on filters page.
"Reset Filters" option is visible when any other advanced filter is applied.

Workaround:

Unknown

Platforms:

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~022001420075452512496
Upwork Job ID: 2001420075452512496
Last Price Increase: 2025-12-17
Automatic offers:

etCoderDysto | Contributor | 109860860

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @twisterdotcom

@twisterdotcom

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mountiny

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Reset Filters" is not displayed on filters page when "Group By" filter is applied

What is the root cause of that problem?

We are returning false when key equals to groupBy when calculating shouldShowResetFilters

App/src/pages/Search/SearchAdvancedFiltersPage.tsx

Lines 23 to 25 in 617cb22

    
           if (key === CONST.SEARCH.SYNTAX_ROOT_KEYS.GROUP_BY) { 
        
               return false; 
        
           }

When clicking reset filters, we are returning early if key === FILTER_KEYS.GROUP_BY and the button is not functional

App/src/libs/actions/Search.ts

Lines 968 to 974 in 617cb22

    
           function clearAdvancedFilters() { 
        
               const values: Partial<Nullable<SearchAdvancedFiltersForm>> = {}; 
        
               for (const key of Object.values(FILTER_KEYS)) { 
        
                   switch (key) { 
        
                       case FILTER_KEYS.GROUP_BY: 
        
                           continue; 
        
                       case FILTER_KEYS.COLUMNS:

What changes do you think we should make in order to solve the problem?

We should remove the if condition

 if (key === CONST.SEARCH.SYNTAX_ROOT_KEYS.GROUP_BY) {
                return false;
            }

App/src/pages/Search/SearchAdvancedFiltersPage.tsx

Lines 23 to 25 in 617cb22

    
           if (key === CONST.SEARCH.SYNTAX_ROOT_KEYS.GROUP_BY) { 
        
               return false; 
        
           }

2. We should remove the below condition for reset filter button to work

case FILTER_KEYS.GROUP_BY:
                continue;

App/src/libs/actions/Search.ts

Line 971 in 617cb22

switch (key) {

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

This issue is reproducible on production too.

@etCoderDysto

📣 @etCoderDysto! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Reviewing label has been removed, please complete the "BugZero Checklist".

@bernhardoj

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: "Reset Filters" is not displayed on filters page when "Group By" filter is applied #78260

If no regressions arise, payment will be issued on 2026-01-07. 🎊

For reference, here are some details about the assignees on this issue:

@bernhardoj requires payment through NewDot Manual Requests
@etCoderDysto requires payment automatic offer (Contributor)

@bernhardoj

@bernhardoj @twisterdotcom The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: N/A - It was a design choice to not show the Reset filters when the group by only has 1 option
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

No need to create another test because it was caught on an existing test.

Regression Test Proposal Template

[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

This isn't overdue. Payment is due tomorrow.

@bernhardoj

Payment Summary:

@bernhardoj paid $250 via NewDot Manual Request
@etCoderDysto paid $250 here (Contributor)

Requested in ND.

@bernhardoj

$250 approved for @bernhardoj

Navigation Menu

Repository navigation

[Due for payment 2026-01-07] [$250] Reports - "Reset Filters" is not displayed on filters page when "Group By" filter is applied #77879

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

28 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (key === CONST.SEARCH.SYNTAX_ROOT_KEYS.GROUP_BY) {
	return false;
	}

	function clearAdvancedFilters() {
	const values: Partial<Nullable<SearchAdvancedFiltersForm>> = {};
	for (const key of Object.values(FILTER_KEYS)) {
	switch (key) {
	case FILTER_KEYS.GROUP_BY:
	continue;
	case FILTER_KEYS.COLUMNS:

[Due for payment 2026-01-07] [$250] Reports - "Reset Filters" is not displayed on filters page when "Group By" filter is applied #77879

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 17, 2025

melvin-bot commented on Dec 17, 2025

melvin-bot commented on Dec 17, 2025

github-actions commented on Dec 17, 2025

etCoderDysto commented on Dec 17, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

etCoderDysto commented on Dec 17, 2025

melvin-bot commented on Dec 17, 2025

28 remaining items

melvin-bot commented on Dec 31, 2025

melvin-bot commented on Dec 31, 2025

melvin-bot commented on Dec 31, 2025

bernhardoj commented on Jan 1, 2026

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

twisterdotcom commented on Jan 6, 2026

twisterdotcom commented on Jan 9, 2026

bernhardoj commented on Jan 10, 2026

garrettmknight commented on Jan 31, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions