[Due for payment 2026-01-07] Applied filters are in empty state after resetting filters and closing RHP without saving it

@garrettmknight

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.2.81-5
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77673
Email or phone of affected tester (no customers): sjdnisnjosjoisnjsiod@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Search

Action Performed:

Go to staging.new.expensify.com
Go to Reports > Expenses.
Click Filters.
Click From.
Select any user > Save.
Click View results.
Click Filters.
Click Reset filters.
Close the RHP without saving it.
Click Reset filters.

Expected Result:

From filter should remain applied and Reset filters button will appear because user did not click View results after resetting filters.

Actual Result:

From filter is empty and Reset filters button does not appear when user did not click View results after resetting filters.

Workaround:

Unknown

Platforms:

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @garrettmknight

@garrettmknight

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@flodnv

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Applied filters are in empty state after resetting filters and closing RHP without saving it

What is the root cause of that problem?

When the user clicks "Reset filters", it directly clears ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM using `clearAdvancedFilters

App/src/libs/actions/Search.ts

Lines 961 to 979 in c43ba15

    
           function clearAdvancedFilters() { 
        
               const values: Partial<Nullable<SearchAdvancedFiltersForm>> = {}; 
        
               for (const key of Object.values(FILTER_KEYS)) { 
        
                   switch (key) { 
        
                       case FILTER_KEYS.GROUP_BY: 
        
                           continue; 
        
                       case FILTER_KEYS.COLUMNS: 
        
                           continue; 
        
                       case FILTER_KEYS.TYPE: 
        
                           values[key] = CONST.SEARCH.DATA_TYPES.EXPENSE; 
        
                           continue; 
        
                       case FILTER_KEYS.STATUS: 
        
                           values[key] = CONST.SEARCH.STATUS.EXPENSE.ALL; 
        
                           continue; 
        
                       default: 
        
                           values[key] = null; 
        
                   } 
        
               } 
        
               Onyx.merge(ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM, values);

The filter form is synced with the current query in SearchPage, but this useEffect only runs when formValues changes, which is derived from queryJSON

App/src/pages/Search/SearchPage.tsx

Lines 197 to 204 in c43ba15

    
           const formValues = queryJSON 
        
               ? buildFilterFormValuesFromQuery(queryJSON, policyCategories, policyTagsLists, currencyList, personalDetails, allCards, allReports, taxRates) 
        
               : getEmptyObject<Partial<SearchAdvancedFiltersForm>>(); 
        
           // Sync the advanced filters form with the current query when it changes 
        
           useEffect(() => { 
        
               updateAdvancedFilters(formValues, true); 
        
           }, [formValues]);

When the user closes the filters RHP without saving, the queryJSON hasn't changed (it's still the applied query), so the useEffect doesn't re-run to restore the filter form values. The form remains in the cleared state from when "Reset filters" was clicked

What changes do you think we should make in order to solve the problem?

We could restore the filter form values from the current query when the advanced filters page mounts with a useEffect that sync the form with the current URL query params

    const [policyCategories] = useOnyx(ONYXKEYS.COLLECTION.POLICY_CATEGORIES, {canBeMissing: true});
    const [policyTagsLists] = useOnyx(ONYXKEYS.COLLECTION.POLICY_TAGS, {canBeMissing: true});
    const [currencyList] = useOnyx(ONYXKEYS.CURRENCY_LIST, {canBeMissing: true});
    const personalDetails = usePersonalDetails();
    const [userCardList] = useOnyx(ONYXKEYS.CARD_LIST, {canBeMissing: false});
    const [workspaceCardFeeds] = useOnyx(ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST, {canBeMissing: false});
    const allCards = useMemo(() => mergeCardListWithWorkspaceFeeds(workspaceCardFeeds ?? CONST.EMPTY_OBJECT, userCardList, true), [userCardList, workspaceCardFeeds]);
    const [allReports] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {canBeMissing: true});
    const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: true});
    const taxRates = useMemo(() => getAllTaxRates(policies), [policies]);

    useEffect(() => {
        const queryJSON = getCurrentSearchQueryJSON();
        if (!queryJSON) {
            return;
        }

        const formValues = buildFilterFormValuesFromQuery(queryJSON, policyCategories, policyTagsLists, currencyList, personalDetails, allCards, allReports, taxRates);
        updateAdvancedFilters(formValues, true);
        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
    }, []);

App/src/pages/Search/SearchAdvancedFiltersPage.tsx

Line 20 in c43ba15

What alternative solutions did you explore? (Optional)

None

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix applied filters are in empty state after resetting filters and closing RHP without saving it #78293

If no regressions arise, payment will be issued on 2026-01-07. 🎊

@luacmartins

@luacmartins / @JS00001 @garrettmknight The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Test:

Go to Reports > Expenses.
Click Filters.
Click From.
Select any user > Save.
Click View results.
Click Filters.
Click Reset filters.
Close the RHP without saving it.
Click Reset filters.
From filter should remain applied and Reset filters button will appear because user did not click View results after resetting filters.

Do we agree 👍 or 👎

@brunovjk

Payment summary:

Contributor: @brunovjk due $250 via NewDot

@brunovjk

@brunovjk has submitted payment for this report on ND here.

SO: https://stackoverflowteams.com/c/expensify/questions/7582

Vendor found in VML: True. Status: Active
Amount requested: $250.00 (Matches the payment summary here: [Due for payment 2026-01-07] Applied filters are in empty state after resetting filters and closing RHP without saving it #77992 (comment).)
I, @twisterdotcom am not already the BZ assignee. I have approved this payment.

Zapier Logs

Run ID: 00040eee-d850-a818-5548-b3aaeb260924

Navigation Menu

Repository navigation

[Due for payment 2026-01-07] Applied filters are in empty state after resetting filters and closing RHP without saving it #77992

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

15 remaining items

BugZero Checklist:

Regression Test Proposal

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function clearAdvancedFilters() {
	const values: Partial<Nullable<SearchAdvancedFiltersForm>> = {};
	for (const key of Object.values(FILTER_KEYS)) {
	switch (key) {
	case FILTER_KEYS.GROUP_BY:
	continue;
	case FILTER_KEYS.COLUMNS:
	continue;
	case FILTER_KEYS.TYPE:
	values[key] = CONST.SEARCH.DATA_TYPES.EXPENSE;
	continue;
	case FILTER_KEYS.STATUS:
	values[key] = CONST.SEARCH.STATUS.EXPENSE.ALL;
	continue;
	default:
	values[key] = null;
	}
	}
	Onyx.merge(ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM, values);

	const formValues = queryJSON
	? buildFilterFormValuesFromQuery(queryJSON, policyCategories, policyTagsLists, currencyList, personalDetails, allCards, allReports, taxRates)
	: getEmptyObject<Partial<SearchAdvancedFiltersForm>>();

	// Sync the advanced filters form with the current query when it changes
	useEffect(() => {
	updateAdvancedFilters(formValues, true);
	}, [formValues]);

[Due for payment 2026-01-07] Applied filters are in empty state after resetting filters and closing RHP without saving it #77992

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 18, 2025

melvin-bot commented on Dec 18, 2025

melvin-bot commented on Dec 18, 2025

github-actions commented on Dec 18, 2025

nyomanjyotisa commented on Dec 18, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

15 remaining items

melvin-bot commented on Dec 31, 2025

melvin-bot commented on Dec 31, 2025

melvin-bot commented on Dec 31, 2025

brunovjk commented on Jan 6, 2026

BugZero Checklist:

Regression Test Proposal

Test:

garrettmknight commented on Jan 7, 2026

twisterdotcom commented on Jan 8, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions