Skip to content

[CFI] Fix attendees selection to allow names instead of email or phone only #77993

Closed

Description

@lakchote

Currently we do not allow selecting an attendee by name

Fix attendees selection to allow names instead of email or phone only

Activity

  1. self-assigned this
    on Dec 18, 2025
  2. added
    InternalRequires API changes or must be handled by Expensify staff
    on Dec 18, 2025
  3. melvin-bot commented on Dec 22, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  4. pecanoro commented on Dec 22, 2025

    @pecanoro
    Contributor

    Removed the Reviewing label since it created some deploy blockers and I had to revert it

  5. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 23, 2025
  6. changed the title [-]Fix attendees selection to allow names instead of email or phone only[/-] [+][Due for payment 2025-12-30] Fix attendees selection to allow names instead of email or phone only[/+] on Dec 23, 2025
  7. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-12-30. 🎊

  8. 24 remaining items

  9. lakchote commented on Feb 10, 2026

    @lakchote
    ContributorAuthor

    Yes!

  10. eVoloshchak commented on Feb 27, 2026

    @eVoloshchak
    Contributor

    I'm owed a payment for this, left a comment here, not sure in which issue it should be handled. Thanks!

    cc: @lakchote, @trjExpensify

  11. eVoloshchak commented on Mar 25, 2026

    @eVoloshchak
    Contributor

    This has consisted of 2 PR's effectively

    1. Fix attendees selection to allow names instead of email or phone only #77995 - (according to Fix attendees selection to allow names instead of email or phone only #77995 (comment), got reverted) should have reduced payment, not sure by how much

    It creates a bunch of deploy blockers. The PR itself is not broken, it does allow adding names as attendees. However, it wasn't a complete fix since it uncovered a lot of things that are not working properly after adding an attendee who isn't an email or phone.

    1. Fix attendees selection to allow names instead of email or phone only && bug fixes #79111 - (first PR will bug fixes, created this deploy blocker, which was demoted since it's a new feature, Reports - Attendee added with a name, can´t be found when trying to apply "Attendee" filter. #79422 (comment)) - no payment, as it is basically the first PR with fixes

    Taking it and demoting since it's a new feature.

    1. Fix filtering attendees names in the Reports page #79498 - (new feature from above. got reverted, but then re-applied in Reapply "Fix filtering attendees names in the Reports page" and add improvements #80718), should be treated as 1 PR (read Reapply "Fix filtering attendees names in the Reports page" and add improvements #80718 (comment)).

    cc: @mallenexpensify, could you handle the payment on this one, please?

  12. mallenexpensify commented on Mar 26, 2026

    @mallenexpensify
    Contributor

    Thanks for providing the details @eVoloshchak that would have been a 🐰🕳 for me to go down.

    Without digging in too much

    1. What ended up happening after the revert? Did we pay someone else to fix it? At most, pay would be 50% here.
    2. From the OG issue

    @lakchote, I'm owed a payment for the review of #77995 (#79111) (regressions, was a deploy blocker #79422 (comment)) and #79498 (this one isn't a regression I think, just a new feature)

    We only want to pay on one of these issues, correct @eVoloshchak ? If so (and @lakchote agrees with what you posted for 3.) then I can pay 100% here and post on the other issue that payment isn't due.

  13. eVoloshchak commented on Mar 30, 2026

    @eVoloshchak
    Contributor

    What ended up happening after the revert?

    The original PR was reverted, the second PR with fixes was applied later

    Did we pay someone else to fix it?

    We didn't, all of the issues were simply closed after the first PR got reverted

    At most, pay would be 50% here.

    Yes, that is correct

    We only want to pay on one of these issues, correct @eVoloshchak ?

    That is correct

  14. lakchote commented on Mar 31, 2026

    @lakchote
    ContributorAuthor

    Your summary is correct @mallenexpensify!

  15. mallenexpensify commented on Apr 2, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @eVoloshchak due $125 via NewDot

    Thanks

  16. trjExpensify commented on Apr 2, 2026

    @trjExpensify
    Contributor

    approved $125 for @eVoloshchak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions