You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[CFI] Fix attendees selection to allow names instead of email or phone only #77993
changed the title [-]Fix attendees selection to allow names instead of email or phone only[/-][+][Due for payment 2025-12-30] Fix attendees selection to allow names instead of email or phone only[/+]on Dec 23, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
It creates a bunch of deploy blockers. The PR itself is not broken, it does allow adding names as attendees. However, it wasn't a complete fix since it uncovered a lot of things that are not working properly after adding an attendee who isn't an email or phone.
@lakchote, I'm owed a payment for the review of #77995 (#79111) (regressions, was a deploy blocker #79422 (comment)) and #79498 (this one isn't a regression I think, just a new feature)
We only want to pay on one of these issues, correct @eVoloshchak ? If so (and @lakchote agrees with what you posted for 3.) then I can pay 100% here and post on the other issue that payment isn't due.
Activity
melvin-bot commentedon Dec 22, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
pecanoro commentedon Dec 22, 2025
Removed the Reviewing label since it created some deploy blockers and I had to revert it
[-]Fix attendees selection to allow names instead of email or phone only[/-][+][Due for payment 2025-12-30] Fix attendees selection to allow names instead of email or phone only[/+]melvin-bot commentedon Dec 23, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-12-30. 🎊
24 remaining items
lakchote commentedon Feb 10, 2026
Yes!
eVoloshchak commentedon Feb 27, 2026
I'm owed a payment for this, left a comment here, not sure in which issue it should be handled. Thanks!
cc: @lakchote, @trjExpensify
eVoloshchak commentedon Mar 25, 2026
This has consisted of 2 PR's effectively
Reportspage #79498 - (new feature from above. got reverted, but then re-applied in Reapply "Fix filtering attendees names in theReportspage" and add improvements #80718), should be treated as 1 PR (read Reapply "Fix filtering attendees names in theReportspage" and add improvements #80718 (comment)).cc: @mallenexpensify, could you handle the payment on this one, please?
mallenexpensify commentedon Mar 26, 2026
Thanks for providing the details @eVoloshchak that would have been a 🐰🕳 for me to go down.
Without digging in too much
We only want to pay on one of these issues, correct @eVoloshchak ? If so (and @lakchote agrees with what you posted for
3.) then I can pay 100% here and post on the other issue that payment isn't due.eVoloshchak commentedon Mar 30, 2026
The original PR was reverted, the second PR with fixes was applied later
We didn't, all of the issues were simply closed after the first PR got reverted
Yes, that is correct
That is correct
lakchote commentedon Mar 31, 2026
Your summary is correct @mallenexpensify!
mallenexpensify commentedon Apr 2, 2026
Payment Summary
Contributor+: @eVoloshchak due $125 via NewDot
Thanks
trjExpensify commentedon Apr 2, 2026
approved $125 for @eVoloshchak