You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add Converted amount in expense thread for multi-currency cash expenses #77999
We're encountering user confusion in multi-currency "cash expense" situations, specifically when the expense purchase currency and the workspace currency are not the same.
We already handle this natively for the Expensify Card and third-party credit cards, via an Original pattern (like below).
We'd like to handle this similarly cash expenses, including receipt scans and per diem expenses (Note: distance and time expenses use a rate and amount that matches the workspace currency, so they don't apply.).
All in all the solution looks like this:
When expense-type is cash or per diem ...
In the expense thread...
Show Converted text in the "dot separator," followed by the amount in the workspace output currency....
What appears in the Amount push row is the original purchase currency and amount (unless manually changed by the user).
changed the title [-]Add `Converted` amount in expense thread for cash expenses[/-][+]Add `Converted` amount in expense thread for multi-currency cash expenses[/+]on Dec 18, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-12-18 15:47:13 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Add Converted amount in expense thread for multi-currency cash expenses
What is the root cause of that problem?
Improvement
What changes do you think we should make in order to solve the problem?
Update amountDescription with converted amount if the transaction's currency is not the same with the workspace's currency. The converted amount can get by transaction?.convertedAmount data.
// Because we lack the necessary data in policy.customUnits to determine the rate in merge flow,
// We need to extract the rate from the merchant string
// See https://github.com/Expensify/App/pull/71675#issuecomment-3425488228 for more information
Optional: We can only apply this for paid group policy if needed
What alternative solutions did you explore? (Optional)
NA
Result
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
⚠️@nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
⚠️@samranahm Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
Please re-state the problem that we are trying to solve in this issue.
Add Converted amount in expense thread for multi-currency cash expenses
What is the root cause of that problem?
Amount breakdown improvement
What changes do you think we should make in order to solve the problem?
We should modify the isCardTransaction in MoneyRequestView, For cash and per diem expenses, show converted amount if currencies differ.
Calculate the converted amount in workspace currency, we display the amount in workspace currency as the transaction will be converted
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-][Due for payment 2026-01-06] Add `Converted` amount in expense thread for multi-currency cash expenses[/-][+]Add `Converted` amount in expense thread for multi-currency cash expenses[/+]on Jan 6, 2026
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
It's a new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Test:
Create a new workspace
Create an expense with a currency that is not the workspace's currency
Go to the expense thread
Verify that the converted amount is displayed
Precondition:
Personal and group policy's default currency is not USD.
Go to self DM.
Create an expense with any currency other than USD.
Open the expense report.
Verify that the converted amount isn't displayed because for unreported expense the converted amount and current amount is the same
Precondition:
Invoice is enabled.
[User A] Send an invoice in any currency which is not workspace default currency to User B.
Activity
melvin-bot commentedon Dec 18, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (
External)melvin-bot commentedon Dec 18, 2025
Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.
[-]Add `Converted` amount in expense thread for cash expenses[/-][+]Add `Converted` amount in expense thread for multi-currency cash expenses[/+]nkdengineer commentedon Dec 18, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-12-18 15:47:13 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Add Converted amount in expense thread for multi-currency cash expenses
What is the root cause of that problem?
Improvement
What changes do you think we should make in order to solve the problem?
Update
amountDescriptionwith converted amount if the transaction's currency is not the same with the workspace's currency. The converted amount can get bytransaction?.convertedAmountdata.App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 431 to 460 in 90f3601
Optional: We can only apply this for paid group policy if needed
What alternative solutions did you explore? (Optional)
NA
Result
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
github-actions commentedon Dec 18, 2025
samranahm commentedon Dec 18, 2025
🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.
github-actions commentedon Dec 18, 2025
samranahm commentedon Dec 18, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Add Converted amount in expense thread for multi-currency cash expenses
What is the root cause of that problem?
Amount breakdown improvement
What changes do you think we should make in order to solve the problem?
We should modify the
isCardTransactioninMoneyRequestView, For cash and per diem expenses, show converted amount if currencies differ.Calculate the converted amount in workspace currency, we display the amount in workspace currency as the transaction will be converted
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
33 remaining items
nkdengineer commentedon Dec 31, 2025
@ZhenjaHorbach The PR is ready for review.
[-][Due for payment 2026-01-06] Add `Converted` amount in expense thread for multi-currency cash expenses[/-][+]Add `Converted` amount in expense thread for multi-currency cash expenses[/+]JmillsExpensify commentedon Jan 6, 2026
Working on the V2 PR
parasharrajat commentedon Jan 13, 2026
Looks like there a regression can you please @nkdengineer @ZhenjaHorbach #79440
melvin-bot commentedon Jan 13, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
ZhenjaHorbach commentedon Jan 20, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
It's a new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Test:
Precondition:
Precondition:
Do we agree 👍 or 👎
ZhenjaHorbach commentedon Jan 20, 2026
This issue will be ready for payment tomorrow!
ZhenjaHorbach commentedon Jan 22, 2026
@JmillsExpensify
We are ready for payment!
JmillsExpensify commentedon Jan 27, 2026
Payment summary:
garrettmknight commentedon Jan 27, 2026
$250 approved for @ZhenjaHorbach
twisterdotcom commentedon Jan 29, 2026
@nkdengineer has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Convertedamount in expense thread for multi-currency cash expenses #77999 (comment).)Zapier Logs
Run ID: 00040eee-2310-a21f-8456-9d08b50bc984ZhenjaHorbach commentedon Feb 5, 2026
I suppose we can close this issue