Skip to content

Add Converted amount in expense thread for multi-currency cash expenses #77999

Closed

Description

@JmillsExpensify

We're encountering user confusion in multi-currency "cash expense" situations, specifically when the expense purchase currency and the workspace currency are not the same.

We already handle this natively for the Expensify Card and third-party credit cards, via an Original pattern (like below).

Image

We'd like to handle this similarly cash expenses, including receipt scans and per diem expenses (Note: distance and time expenses use a rate and amount that matches the workspace currency, so they don't apply.).

All in all the solution looks like this:

  • When expense-type is cash or per diem ...
  • In the expense thread...
  • Show Converted text in the "dot separator," followed by the amount in the workspace output currency....
  • What appears in the Amount push row is the original purchase currency and amount (unless manually changed by the user).
Image
Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 18, 2025
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 18, 2025
  3. melvin-bot commented on Dec 18, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

  4. melvin-bot commented on Dec 18, 2025

    @melvin-bot

    Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

  5. changed the title [-]Add `Converted` amount in expense thread for cash expenses[/-] [+]Add `Converted` amount in expense thread for multi-currency cash expenses[/+] on Dec 18, 2025
  6. nkdengineer commented on Dec 18, 2025

    @nkdengineer
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-12-18 15:47:13 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Add Converted amount in expense thread for multi-currency cash expenses

    What is the root cause of that problem?

    Improvement

    What changes do you think we should make in order to solve the problem?

    Update amountDescription with converted amount if the transaction's currency is not the same with the workspace's currency. The converted amount can get by transaction?.convertedAmount data.

    const convertedAmount = isPaidGroupPolicy(moneyRequestReport) ? -(transaction?.convertedAmount ?? 0) : transaction?.convertedAmount ?? 0;
        if (currency !== moneyRequestReport?.currency && !isCardTransaction) {
            amountDescription += ` ${CONST.DOT_SEPARATOR} ${'Converted'} ${convertToDisplayString(convertedAmount, moneyRequestReport?.currency)}`;
        }
    

    if (isCardTransaction) {
    if (transactionPostedDate) {
    dateDescription += ` ${CONST.DOT_SEPARATOR} ${translate('iou.posted')} ${transactionPostedDate}`;
    }
    if (formattedOriginalAmount) {
    amountDescription += ` ${CONST.DOT_SEPARATOR} ${translate('iou.original')} ${formattedOriginalAmount}`;
    }
    if (isCancelled) {
    amountDescription += ` ${CONST.DOT_SEPARATOR} ${translate('iou.canceled')}`;
    }
    } else {
    if (!isDistanceRequest && !isPerDiemRequest) {
    amountDescription += ` ${CONST.DOT_SEPARATOR} ${translate('iou.cash')}`;
    }
    if (isCancelled) {
    amountDescription += ` ${CONST.DOT_SEPARATOR} ${translate('iou.canceled')}`;
    } else if (isApproved) {
    amountDescription += ` ${CONST.DOT_SEPARATOR} ${translate('iou.approved')}`;
    } else if (shouldShowPaid) {
    amountDescription += ` ${CONST.DOT_SEPARATOR} ${translate('iou.settledExpensify')}`;
    }
    }
    if (isExpenseSplit) {
    amountDescription += ` ${CONST.DOT_SEPARATOR} ${translate('iou.split')}`;
    }
    if (isFromMergeTransaction) {
    // Because we lack the necessary data in policy.customUnits to determine the rate in merge flow,
    // We need to extract the rate from the merchant string
    // See https://github.com/Expensify/App/pull/71675#issuecomment-3425488228 for more information

    Optional: We can only apply this for paid group policy if needed

    What alternative solutions did you explore? (Optional)

    NA

    Result

    Image

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. github-actions commented on Dec 18, 2025

    @github-actions
    Contributor

    ⚠️ @nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  8. samranahm commented on Dec 18, 2025

    @samranahm
    Contributor

    🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

  9. github-actions commented on Dec 18, 2025

    @github-actions
    Contributor

    ⚠️ @samranahm Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.

  10. samranahm commented on Dec 18, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Add Converted amount in expense thread for multi-currency cash expenses

    What is the root cause of that problem?

    Amount breakdown improvement

    What changes do you think we should make in order to solve the problem?

    We should modify the isCardTransaction in MoneyRequestView, For cash and per diem expenses, show converted amount if currencies differ.
    Calculate the converted amount in workspace currency, we display the amount in workspace currency as the transaction will be converted

    const shouldShowConvertedAmount = (transactionCurrency || actualCurrency) && policy?.outputCurrency && (transactionCurrency !== policy.outputCurrency || actualCurrency !== policy.outputCurrency) && formattedTransactionAmount;
    if (shouldShowConvertedAmount) {
        const workspaceCurrency = policy?.outputCurrency ?? CONST.CURRENCY.USD;
        const convertedAmount = convertToDisplayString(actualAmount, workspaceCurrency);
        amountDescription += ` ${CONST.DOT_SEPARATOR} ${translate('iou.converted')} ${convertedAmount}`;
    }

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  11. 33 remaining items

  12. nkdengineer commented on Dec 31, 2025

    @nkdengineer
    Contributor

    @ZhenjaHorbach The PR is ready for review.

  13. changed the title [-][Due for payment 2026-01-06] Add `Converted` amount in expense thread for multi-currency cash expenses[/-] [+]Add `Converted` amount in expense thread for multi-currency cash expenses[/+] on Jan 6, 2026
  14. JmillsExpensify commented on Jan 6, 2026

    @JmillsExpensify
    ContributorAuthor

    Working on the V2 PR

  15. parasharrajat commented on Jan 13, 2026

    @parasharrajat
    Member

    Looks like there a regression can you please @nkdengineer @ZhenjaHorbach #79440

  16. melvin-bot commented on Jan 13, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  17. ZhenjaHorbach commented on Jan 20, 2026

    @ZhenjaHorbach
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      It's a new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Test:

    1. Create a new workspace
    2. Create an expense with a currency that is not the workspace's currency
    3. Go to the expense thread
    4. Verify that the converted amount is displayed

    Precondition:

    • Personal and group policy's default currency is not USD.
    1. Go to self DM.
    2. Create an expense with any currency other than USD.
    3. Open the expense report.
    4. Verify that the converted amount isn't displayed because for unreported expense the converted amount and current amount is the same

    Precondition:

    • Invoice is enabled.
    1. [User A] Send an invoice in any currency which is not workspace default currency to User B.
    2. [User B] Open the invoice report.
    3. Verify that the converted amount is correct

    Do we agree 👍 or 👎

  18. ZhenjaHorbach commented on Jan 20, 2026

    @ZhenjaHorbach
    Contributor

    This issue will be ready for payment tomorrow!

  19. ZhenjaHorbach commented on Jan 22, 2026

    @ZhenjaHorbach
    Contributor

    @JmillsExpensify
    We are ready for payment!

  20. JmillsExpensify commented on Jan 27, 2026

    @JmillsExpensify
    ContributorAuthor

    Payment summary:

  21. garrettmknight commented on Jan 27, 2026

    @garrettmknight
    Contributor

    $250 approved for @ZhenjaHorbach

  22. twisterdotcom commented on Jan 29, 2026

    @twisterdotcom
    Contributor

    @nkdengineer has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-2310-a21f-8456-9d08b50bc984
  23. ZhenjaHorbach commented on Feb 5, 2026

    @ZhenjaHorbach
    Contributor

    I suppose we can close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions