You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-30] Reports - "Maximum tax amount is 0.00" when editing amount after enabling Tax #78021
Version Number: 9.2.82-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#77836 Email or phone of affected tester (no customers):sdjoinsjoisjoisdnjo@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Mac 26.1 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create an expense.
Go to Reports > Expenses.
Click Columns.
Select Tax.
Click Save.
Click on the expense.
Click Amount.
Edit the amount and save it.
Expected Result:
Amount can be edited.
Actual Result:
Amount cannot be edited. "Maximum tax amount is MYR 0.00" error shows up.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
When editing an expense amount after enabling the Tax column, users see the error "Maximum tax amount is MYR 0.00" and cannot save the edited amount.
What is the root cause of that problem?
In MoneyRequestAmountForm.tsx, the code checks if the current page is a tax amount form using Navigation.getActiveRoute().includes('taxAmount'). This method returns the full route including query parameters. When editing a regular amount (not tax), the route contains ?taxAmount=0 as a query parameter, which causes the check to incorrectly identify the page as a tax amount form. The tax validation then triggers with taxAmount=0, causing any amount greater than 0 to fail validation.
What changes do you think we should make in order to solve the problem?
Use Navigation.getActiveRouteWithoutParams() instead of Navigation.getActiveRoute() to check the route path without query parameters. This ensures the check only matches when the actual route path contains /taxAmount, not when it appears in query parameters.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Reports - "Maximum tax amount is 0.00" when editing amount after enabling Tax[/-][+][Due for payment 2025-12-30] Reports - "Maximum tax amount is 0.00" when editing amount after enabling Tax[/+]on Dec 23, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins@strepanier03 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Dec 18, 2025
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 18, 2025
Triggered auto assignment to @rlinoz (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Dec 18, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 18, 2025
💬 A slack conversation has been started in #expensify-open-source
samranahm commentedon Dec 18, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
When editing an expense amount after enabling the Tax column, users see the error "Maximum tax amount is MYR 0.00" and cannot save the edited amount.
What is the root cause of that problem?
In
MoneyRequestAmountForm.tsx, the code checks if the current page is a tax amount form usingNavigation.getActiveRoute().includes('taxAmount'). This method returns the full route including query parameters. When editing a regular amount (not tax), the route contains?taxAmount=0as a query parameter, which causes the check to incorrectly identify the page as a tax amount form. The tax validation then triggers withtaxAmount=0, causing any amount greater than 0 to fail validation.App/src/pages/iou/MoneyRequestAmountForm.tsx
Line 142 in 14818a7
What changes do you think we should make in order to solve the problem?
Use
Navigation.getActiveRouteWithoutParams()instead ofNavigation.getActiveRoute()to check the route path without query parameters. This ensures the check only matches when the actual route path contains/taxAmount, not when it appears in query parameters.We should change
isTaxAmountFormto:here
App/src/pages/iou/MoneyRequestAmountForm.tsx
Line 142 in 14818a7
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
luacmartins commentedon Dec 18, 2025
@samranahm which PR caused the regression?
1 remaining item
[-]Reports - "Maximum tax amount is 0.00" when editing amount after enabling Tax[/-][+][Due for payment 2025-12-30] Reports - "Maximum tax amount is 0.00" when editing amount after enabling Tax[/+]melvin-bot commentedon Dec 23, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 23, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-12-30. 🎊
melvin-bot commentedon Dec 23, 2025
@luacmartins @strepanier03 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]