Skip to content

[Due for payment 2025-12-30] Reports - "Maximum tax amount is 0.00" when editing amount after enabling Tax #78021

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.82-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77836
Email or phone of affected tester (no customers): sdjoinsjoisjoisdnjo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Go to Reports > Expenses.
  5. Click Columns.
  6. Select Tax.
  7. Click Save.
  8. Click on the expense.
  9. Click Amount.
  10. Edit the amount and save it.

Expected Result:

Amount can be edited.

Actual Result:

Amount cannot be edited. "Maximum tax amount is MYR 0.00" error shows up.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @strepanier03

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 18, 2025
  2. melvin-bot commented on Dec 18, 2025

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Dec 18, 2025

    @melvin-bot

    Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Dec 18, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Dec 18, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. samranahm commented on Dec 18, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When editing an expense amount after enabling the Tax column, users see the error "Maximum tax amount is MYR 0.00" and cannot save the edited amount.

    What is the root cause of that problem?

    In MoneyRequestAmountForm.tsx, the code checks if the current page is a tax amount form using Navigation.getActiveRoute().includes('taxAmount'). This method returns the full route including query parameters. When editing a regular amount (not tax), the route contains ?taxAmount=0 as a query parameter, which causes the check to incorrectly identify the page as a tax amount form. The tax validation then triggers with taxAmount=0, causing any amount greater than 0 to fail validation.

    const isTaxAmountForm = Navigation.getActiveRoute().includes('taxAmount');

    What changes do you think we should make in order to solve the problem?

    Use Navigation.getActiveRouteWithoutParams() instead of Navigation.getActiveRoute() to check the route path without query parameters. This ensures the check only matches when the actual route path contains /taxAmount, not when it appears in query parameters.

    We should change isTaxAmountForm to:

    const isTaxAmountForm = Navigation.getActiveRouteWithoutParams().includes('taxAmount');

    here

    const isTaxAmountForm = Navigation.getActiveRoute().includes('taxAmount');

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. luacmartins commented on Dec 18, 2025

    @luacmartins
    Contributor

    @samranahm which PR caused the regression?

  8. 1 remaining item

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 23, 2025
  10. changed the title [-]Reports - "Maximum tax amount is 0.00" when editing amount after enabling Tax[/-] [+][Due for payment 2025-12-30] Reports - "Maximum tax amount is 0.00" when editing amount after enabling Tax[/+] on Dec 23, 2025
  11. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-12-30. 🎊

  13. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    @luacmartins @strepanier03 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions