Expense- App crash after deleting category in the list

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.2.82-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176818/test-cases/41237209
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Windows 11 pro /Chrome
App Component: Workspace Settings

Action Performed:

Navigate to staging.new.expensify.com
Create Workspace
Go to category and open one of the category
Delete the item using RHP menu

Expected Result:

The App doesn't crash

Actual Result:

The App crash

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug7033235_1766094834208!Log_crash.txt

Bug7033235_1766094834203.bandicam_2025-12-19_00-50-40-794.mp4

View all open jobs on GitHub

@RachCHopkins

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@arosiclair

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense- App crash after deleting category in the list

What is the root cause of that problem?

The crash occurs in the requireFieldsPendingAction useMemo hook where the dependency array accesses policyCategory.pendingFields without optional chaining

App/src/pages/workspace/categories/CategorySettingsPage.tsx

Lines 132 to 139 in 894cbc2

    
           const requireFieldsPendingAction = useMemo(() => { 
        
               if (policy?.isAttendeeTrackingEnabled) { 
        
                   // Pending fields are objects so we can't use nullish coalescing 
        
                   // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing 
        
                   return policyCategory?.pendingFields?.areAttendeesRequired || policyCategory?.pendingFields?.areCommentsRequired; 
        
               } 
        
               return policyCategory?.pendingFields?.areCommentsRequired; 
        
           }, [policyCategory.pendingFields, policy?.isAttendeeTrackingEnabled]);

What changes do you think we should make in order to solve the problem?

Add optional chaining to policyCategory.pendingFields in the dependency array to safely handle when policyCategory is undefined

    }, [policyCategory?.pendingFields, policy?.isAttendeeTrackingEnabled]);

App/src/pages/workspace/categories/CategorySettingsPage.tsx

Line 139 in 894cbc2

}, [policyCategory.pendingFields, policy?.isAttendeeTrackingEnabled]);

What alternative solutions did you explore? (Optional)

None

Reproduced in staging v9.2.84-0 and not in prod v9.2.83-0. However, I don't reproduce this while offline and not after I reconnect either which is weird.

Can't reproduce in dev atm even with v9.2.84-0 checked out

This is reproducible with both staging and prod APIs so not a API blocker

@ikevin127

Okay reverting #76687 fixes this. cc @ikevin127 @jayeshmangwani @JS00001

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Reverting this one

MacOS Monterey / Chrome Web v9.2.84-5
Issue Not reproduced

Screen.Recording.2025-12-19.at.21.23.57.mp4

Closing, we cpd a revert, thanks!

Navigation Menu

Repository navigation

Expense- App crash after deleting category in the list #78076

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const requireFieldsPendingAction = useMemo(() => {
	if (policy?.isAttendeeTrackingEnabled) {
	// Pending fields are objects so we can't use nullish coalescing
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	return policyCategory?.pendingFields?.areAttendeesRequired \|\| policyCategory?.pendingFields?.areCommentsRequired;
	}
	return policyCategory?.pendingFields?.areCommentsRequired;
	}, [policyCategory.pendingFields, policy?.isAttendeeTrackingEnabled]);

Expense- App crash after deleting category in the list #78076

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 19, 2025

melvin-bot commented on Dec 19, 2025

melvin-bot commented on Dec 19, 2025

github-actions commented on Dec 19, 2025

nyomanjyotisa commented on Dec 19, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

arosiclair commented on Dec 19, 2025

arosiclair commented on Dec 19, 2025

arosiclair commented on Dec 19, 2025

arosiclair commented on Dec 19, 2025

melvin-bot commented on Dec 19, 2025

JS00001 commented on Dec 19, 2025

mvtglobally commented on Dec 19, 2025

JS00001 commented on Dec 19, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions