Repository navigation
[Due for payment 2026-01-05] [Due for payment 2025-12-30] Accounting - Netsuite set up steps are not highlighted correctly #78096
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.2.82-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #71868
Email or phone of affected tester (no customers): ndk.2303+154@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11 Home/Chrome
App Component: Workspace Settings
Action Performed:
Precondition: Create a control workspace and enable Accounting
- Open https://staging.new.expensify.com/
- Navigate to workspace setting
- Click on Accounting
- Click on Connect at 'Netsuite'
- Click 'Next' four times
- Click 'Back' four times
Expected Result:
Steps are highlighted correctly when going connection flow with Netsuite
Actual Result:
Step 5, at Credentials steps, Step 1 is highlighted.
Step 6. Steps 1 is highlighted and then there is no step is highlighted
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
Activity
melvin-bot commentedon Dec 19, 2025
Triggered auto assignment to @VictoriaExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 19, 2025
Triggered auto assignment to @francoisl (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 19, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 19, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nyomanjyotisa commentedon Dec 19, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Accounting - Netsuite set up steps are not highlighted correctly
What is the root cause of that problem?
InteractiveStepSubHeaderalways initializes withstartStepIndex={0}, but the actual current step is tracked inscreenIndexfromuseSubStepApp/src/pages/workspace/accounting/netsuite/NetSuiteTokenInput/NetSuiteTokenInputPage.tsx
Lines 72 to 76 in 894cbc2
What changes do you think we should make in order to solve the problem?
We can pass the current
screenIndextoInteractiveStepSubHeaderso it reinitializes with the correct stepApp/src/pages/workspace/accounting/netsuite/NetSuiteTokenInput/NetSuiteTokenInputPage.tsx
Line 74 in 894cbc2
We could also fix the typo in
CONST.NETSUITE_CONFIG.TOKEN_INPUT_STEP_NAMESwhere step 2 is '2,' instead of '2'App/src/CONST/index.ts
Line 2424 in 894cbc2
What alternative solutions did you explore? (Optional)
None
francoisl commentedon Dec 19, 2025
Thanks for the proposal.
I confirmed that reverting #71868 fixes the issue. Since the #70746 only happened on mobile and it's pretty rare to connect to accounting on mobile, I think it's better to revert the PR in this case, and then do a proper follow-up that also addresses this issue.
cc @abzokhattab @Pujan92
3 remaining items
[-]Accounting - Netsuite set up steps are not highlighted correctly[/-][+][Due for payment 2025-12-30] Accounting - Netsuite set up steps are not highlighted correctly[/+]melvin-bot commentedon Dec 23, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 23, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-12-30. 🎊
melvin-bot commentedon Dec 23, 2025
@francoisl @VictoriaExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2025-12-30] Accounting - Netsuite set up steps are not highlighted correctly[/-][+][Due for payment 2026-01-05] [Due for payment 2025-12-30] Accounting - Netsuite set up steps are not highlighted correctly[/+]melvin-bot commentedon Dec 29, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.87-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-01-05. 🎊
melvin-bot commentedon Dec 29, 2025
@francoisl @VictoriaExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]