Skip to content

[$250] Reports - Phone number user shows @expensify.sms on Reports #78114

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.82-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #76067
Email or phone of affected tester (no customers): applausetester+khdjdjdjsjsk@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Search

Action Performed:

Precondition:

  • User has invited a phone number user with no display name.
  • User has added a direct card in Company cards page.
  • User has assigned a card with transactions to phone number user.
  1. Launch Expensify app.
  2. Go to Reports > Expenses.

Expected Result:

Expense row will not show user name with @expensify.sms.

Actual Result:

Expense row shows user name with @expensify.sms.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7033403_1766120438427.Screen_Recording_20251219_125754_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022002016095318679684
  • Upwork Job ID: 2002016095318679684
  • Last Price Increase: 2025-12-19
  • Automatic offers:
    • nyomanjyotisa | Contributor | 109906321
Issue OwnerCurrent Issue Owner: @marcaaron

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 19, 2025
  2. melvin-bot commented on Dec 19, 2025

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. etCoderDysto commented on Dec 19, 2025

    @etCoderDysto
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Reports - Phone number user shows @expensify.sms on Reports

    What is the root cause of that problem?

    We are not removing @expensify.sms from displayName

    What changes do you think we should make in order to solve the problem?

    We should use Str.removeSMSDomain to remove it

    Str.removeSMSDomain(displayName ?? "")
    

    We should check if similar issue happens on other pages and fix them.

    What alternative solutions did you explore? (Optional)

    We can remove @expensify.sms from participantFromDisplayName since participantFromDisplayName is passed down as displayName

    Str.removeSMSDomain(participantFromDisplayName ?? "");
    

    participantFromDisplayName={participantFromDisplayName}

    const participantFromDisplayName = item?.from?.displayName ?? item?.from?.login ?? translate('common.hidden');

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. nyomanjyotisa commented on Dec 19, 2025

    @nyomanjyotisa
    Member

    🚨 Edited by proposal-police: This proposal was edited at 2025-12-23 07:02:58 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Reports - Phone number user shows @expensify.sms on Reports (on small screens only)

    What is the root cause of that problem?

    The issue occurs in UserInfoAndActionButtonRow (used for small screens), which directly uses item?.from?.displayName ?? item?.from?.login instead of using the pre-formatted item.formattedFrom prop

    const participantFromDisplayName = item?.from?.displayName ?? item?.from?.login ?? translate('common.hidden');
    const participantToDisplayName = item?.to?.displayName ?? item?.to?.login ?? translate('common.hidden');

    Meanwhile, on large screen, TransactionItemRow uses formattedFrom, which is why the issue doesn't occur on desktop

    displayName={transactionItem.formattedFrom ?? transactionItem.from.displayName ?? ''}

    displayName={transactionItem.formattedTo ?? transactionItem.to.displayName ?? ''}

    What changes do you think we should make in order to solve the problem?

    We should update UserInfoAndActionButtonRow to use the existing formattedFrom and formattedTo prop

        const participantFromDisplayName = item?.formattedFrom ?? item?.from?.displayName ?? item?.from?.login ?? translate('common.hidden');
        const participantToDisplayName = item?.formattedTo ?? item?.to?.displayName ?? item?.to?.login ?? translate('common.hidden');

    const participantFromDisplayName = item?.from?.displayName ?? item?.from?.login ?? translate('common.hidden');
    const participantToDisplayName = item?.to?.displayName ?? item?.to?.login ?? translate('common.hidden');

    Note: we can add the fallback on ExpenseReportListItemRow as well to fix the display name on Reports tab

                            displayName={item.formattedFrom ?? item.from.displayName ?? item.from.login ?? ''}

    displayName={item.from.displayName ?? item.from.login ?? ''}

                            displayName={item.formattedTo ?? item.to.displayName ?? item.to.login ?? ''}

    displayName={item.to.displayName ?? item.to.login ?? ''}

    What alternative solutions did you explore? (Optional)

    None

  5. Eskalifer1 commented on Dec 19, 2025

    @Eskalifer1
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Reports - Phone number user shows @expensify.sms on Reports

    What is the root cause of that problem?

    We dont filter @expensify.sms in this case

    <Text
    numberOfLines={1}
    style={[isLargeScreenWidth ? styles.themeTextColor : styles.textMicroSupporting, styles.flexShrink1, textStyle]}
    >
    {displayName}
    </Text>

    What changes do you think we should make in order to solve the problem?

    We should add formatted display of phone number here:

    <Text
    numberOfLines={1}
    style={[isLargeScreenWidth ? styles.themeTextColor : styles.textMicroSupporting, styles.flexShrink1, textStyle]}
    >
    {displayName}
    </Text>

    formatPhoneNumber(displayName)

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BZ Test Jan 26Lauren R running tests on removing BZ from certain parts in issue flows
    on Dec 19, 2025
  7. changed the title [-]Reports - Phone number user shows @expensify.sms on Reports[/-] [+][$250] Reports - Phone number user shows @expensify.sms on Reports[/+] on Dec 19, 2025
  8. melvin-bot commented on Dec 19, 2025

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 19, 2025
  10. melvin-bot commented on Dec 19, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @bernhardoj (External)

  11. 13 remaining items

  12. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 23, 2025
  13. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    📣 @nyomanjyotisa 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  14. melvin-bot commented on Jan 17, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @marcaaron, @bernhardoj, @laurenreidexpensify, @nyomanjyotisa eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  15. bernhardoj commented on Jan 17, 2026

    @bernhardoj
    Contributor

    @laurenreidexpensify this is ready for payment

  16. laurenreidexpensify commented on Feb 20, 2026

    @laurenreidexpensify
    Contributor

    oh my goodess sorry @bernhardoj @nyomanjyotisa i totally missed this one

  17. laurenreidexpensify commented on Feb 20, 2026

    @laurenreidexpensify
    Contributor

    Payment Summary

  18. bernhardoj commented on Feb 20, 2026

    @bernhardoj
    Contributor

    Thanks! Requested in ND.

  19. trjExpensify commented on Feb 25, 2026

    @trjExpensify
    Contributor

    approved $250 for @nyomanjyotisa.

  20. garrettmknight commented on Mar 6, 2026

    @garrettmknight
    Contributor

    $250 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BZ Test Jan 26Lauren R running tests on removing BZ from certain parts in issue flowsBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions