Skip to content

When expense created offline in McTest chat, total and marked as paid shown twice #78161

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.82-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77484
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: iPhone 15 iOS 26.1
App Component: Money Requests

Action Performed:

  1. Login to ND with a new account
  2. Tap FAB - Scan - Try it out
  3. Tap create expense and complete the flow
  4. Go offline
  5. Tap plus icon and create a manual expense in the chat with Manager McTest
  6. Open the expense details

Expected Result:

The total and "Marked as paid" message are not shown twice

Actual Result:

The total and "Marked as paid" message are shown twice

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7033305_1766101941638.PR_6.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 19, 2025
  2. melvin-bot commented on Dec 19, 2025

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. samranahm commented on Dec 19, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When expense created offline in McTest chat, total and marked as paid shown twice

    What is the root cause of that problem?

    When an expense is created offline in the McTest chat and marked as paid, it creates both an expense report (IOU report) and a transaction thread report.
    In ReportActionItemContentCreated, when both reports exist, it renders both
    MoneyReportView that shows the Total with a checkmark
    MoneyRequestView that shows the Amount with "marked as paid" text in the description AND shows "Marked as paid" icon

    What changes do you think we should make in order to solve the problem?

    We should hide the total in MoneyReportView when we have a transactionThreadReport and the report is settled, since MoneyRequestView will already display this information.

    const isSettled = isSettledReportUtils(report?.reportID);
    ...
    shouldShowTotal={transaction ? transactionCurrency !== report?.currency && !isSettled : false}

    here

    shouldShowTotal={transaction ? transactionCurrency !== report?.currency : false}

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. melvin-bot commented on Dec 24, 2025

    @melvin-bot

    @dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

  6. melvin-bot commented on Dec 27, 2025

    @melvin-bot

    @dylanexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  7. melvin-bot commented on Jan 2, 2026

    @melvin-bot

    @dylanexpensify 12 days overdue. Walking. Toward. The. Light...

  8. melvin-bot commented on Jan 2, 2026

    @melvin-bot

    @dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  9. dylanexpensify commented on Jan 5, 2026

    @dylanexpensify
    Contributor

    feels like an edge case we don't need to prioritize right now. @danielrvidal lmk if you disagree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions