You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Merge] Expense - Attendee section is missing when merging expenses when name is selected as attendee #78225
Version Number: 9.2.85-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#77995 Email or phone of affected tester (no customers):soijdnosidjoijidosj@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Mac 26.1 / Chrome App Component: Money Requests
Action Performed:
Preconditon:
Rules are enabled.
Attendee tracking is enabled in Rules.
Go to staging.new.expensify.com
Go to workspace chat.
Create two manual expenses and select name (not email) on Attendees field.
Open the expense report.
Open any expense.
Click More > Merge.
Select the other expense from Step 3 > Continue.
Expected Result:
On detail selection page, Attendee section will be shown because both expenses have different attendees.
Actual Result:
On detail selection page, Attendee section is not shown when name is selected as attendees.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Expense - Attendee section is missing when merging expenses when name is selected as attendee[/-][+][Merge] Expense - Attendee section is missing when merging expenses when name is selected as attendee[/+]on Dec 20, 2025
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
melvin-bot commentedon Dec 20, 2025
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 20, 2025
Triggered auto assignment to @Valforte (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 20, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 20, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
samranahm commentedon Dec 20, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense - Attendee section is missing when merging expenses when name is selected as attendee
What is the root cause of that problem?
In
MergeTransactionUtils, the attendee comparison logic only comparedlogin??emailvaluesWhen users selected attendees by name not email, the attendees can have:
This caused the comparison to incorrectly identify them as different attendees, preventing the Attendee section from showing during merge.
What changes do you think we should make in order to solve the problem?
We should update the comparison logic to use
accountIDas the primary identifier, with a fallback to login ?? email:here
App/src/libs/MergeTransactionUtils.ts
Lines 248 to 258 in 251ab97
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
youssef-lr commentedon Dec 20, 2025
We're reverting the offending PR.
[-]Expense - Attendee section is missing when merging expenses when name is selected as attendee[/-][+][Merge] Expense - Attendee section is missing when merging expenses when name is selected as attendee[/+]m-natarajan commentedon Dec 21, 2025
Not repro, Windows 11 / Chrome, iPhone 13 / iOS 18.7.1, v9.2.85-1
attendee.ios.MP4
attendee.mp4
melvin-bot commentedon Jan 17, 2026
This issue has not been updated in over 15 days. @youssef-lr, @bfitzexpensify eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
melvin-bot commentedon Mar 16, 2026
@youssef-lr, @bfitzexpensify, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.