Skip to content

[Due for payment 2026-01-28] [$250] Expense-Rejected expense preview total resets to 0 after rejection & update only after revisit #78577

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9.2.88-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/27754595/test-cases/69505292?q=Reject+
Email or phone of affected tester (no customers): dreamnitethedragon+yydyd373@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redminote 10S Android 13
App Component: Money Requests

Action Performed:

  1. Launch app
  2. Open workspace chat
  3. Create 3 manual expense
  4. Open the expense report
  5. Tap submit
  6. Select 2 expenses and Reject option from dropdown
  7. Enter reason and complete the flow
  8. Navigate to rejected expense
  9. Note Expense preview shows correct total briefly and changes to zero
  10. Tap Total
  11. Navigate back to expense preview
  12. Note correct total is shown now

Expected Result:

Rejected expense preview should consistently display the correct total.

The total should not change unexpectedly or require navigating away and back to display correct total amount.

Actual Result:

Rejected expense preview briefly displays the correct total.

The total then automatically changes to 0 without any user action.

Tapping Total and navigating back to the expense preview updates the total to the correct value.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7039126_1767085416715.Screenrecorder-2025-12-30-14-25-16-826.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022008463768715252552
  • Upwork Job ID: 2008463768715252552
  • Last Price Increase: 2026-01-06
Issue OwnerCurrent Issue Owner: @sonialiap

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 30, 2025
  2. melvin-bot commented on Dec 30, 2025

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. bernhardoj commented on Dec 31, 2025

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Rejected expense report shows 0 amount on the report preview.

    What is the root cause of that problem?

    When we reject expenses, we create a new report if we don't have one yet. The problem is, on success we use a SET that clears the report.

    App/src/libs/actions/IOU/index.ts

    Lines 13618 to 13632 in 1d1ea3d

    successData.push(
    {
    onyxMethod: Onyx.METHOD.SET,
    key: `${ONYXKEYS.COLLECTION.REPORT}${rejectedToReportID}`,
    value: {
    pendingFields: null,
    },
    },
    {
    onyxMethod: Onyx.METHOD.SET,
    key: `${ONYXKEYS.COLLECTION.REPORT_METADATA}${rejectedToReportID}`,
    value: {
    isOptimisticReport: null,
    },
    },

    So, the amount shown is 0.

    There are other bugs too, like report preview action is created for each rejected transaction and the report total will take the last transaction amount, but it's out of scope of this issue.

    What changes do you think we should make in order to solve the problem?

    We need to use MERGE instead of SET.

    App/src/libs/actions/IOU/index.ts

    Lines 13618 to 13632 in 1d1ea3d

    successData.push(
    {
    onyxMethod: Onyx.METHOD.SET,
    key: `${ONYXKEYS.COLLECTION.REPORT}${rejectedToReportID}`,
    value: {
    pendingFields: null,
    },
    },
    {
    onyxMethod: Onyx.METHOD.SET,
    key: `${ONYXKEYS.COLLECTION.REPORT_METADATA}${rejectedToReportID}`,
    value: {
    isOptimisticReport: null,
    },
    },

  4. melvin-bot commented on Jan 3, 2026

    @melvin-bot

    @sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 6, 2026
  6. changed the title [-]Expense-Rejected expense preview total resets to 0 after rejection & update only after revisit[/-] [+][$250] Expense-Rejected expense preview total resets to 0 after rejection & update only after revisit[/+] on Jan 6, 2026
  7. melvin-bot commented on Jan 6, 2026

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 6, 2026
  9. melvin-bot commented on Jan 6, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

  10. suneox commented on Jan 8, 2026

    @suneox
    Contributor

    @bernhardoj Thanks for your proposal, but can you still reproduce this on the latest main? On the latest main, after rejecting, I only see an issue with duplicated report groups.

    Image
    v9.2.96-1
    CleanShot.2026-01-09.at.00.30.10.mp4
    v9.2.94-0
    CleanShot.2026-01-09.at.00.23.51.mp4
  11. 19 remaining items

  12. changed the title [-][$250] Expense-Rejected expense preview total resets to 0 after rejection & update only after revisit[/-] [+][Due for payment 2026-01-28] [$250] Expense-Rejected expense preview total resets to 0 after rejection & update only after revisit[/+] on Jan 21, 2026
  13. melvin-bot commented on Jan 21, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jan 21, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-28. 🎊

    For reference, here are some details about the assignees on this issue:

    • @suneox requires payment through NewDot Manual Requests
    • @bernhardoj requires payment through NewDot Manual Requests
  15. melvin-bot commented on Jan 21, 2026

    @melvin-bot

    @suneox / @bernhardoj @sonialiap The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. suneox commented on Jan 28, 2026

    @suneox
    Contributor

    BugZero Checklist

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/70960/changes#r2737383816

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    1. Create a workspace with Delayed Submissions and Approvals enabled
    2. Have a workspace owner and a submitter user
    3. Submitter is logged into the app

    Test:

    1. As submitter, create 3 separate expenses in a workspace chat
    2. Submit all 3 expenses as a single report
    3. Open the submitted expense report
    4. Tap "Submit" button
    5. Select 2 of the 3 expenses for rejection
    6. Choose "Reject" from the dropdown menu
    7. Enter a rejection reason and complete the rejection flow
    8. Navigate to the newly created rejected expense report

    Expected Result: Rejected expense report preview displays the correct total amount

    Do we agree 👍 or 👎

  17. sonialiap commented on Feb 2, 2026

    @sonialiap
    Contributor

    Payment summary:
    @suneox $250 please request in NewDot
    @bernhardoj $250 please request in NewDot

    Apologies for the delay in payment, I was OOO for two weeks and apparently missed adding a BZ buddy to this issue

  18. bernhardoj commented on Feb 3, 2026

    @bernhardoj
    Contributor

    Requested in ND.

  19. trjExpensify commented on Feb 3, 2026

    @trjExpensify
    Contributor

    approved $250 for @suneox.

  20. garrettmknight commented on Mar 6, 2026

    @garrettmknight
    Contributor

    $250 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions