Skip to content

Reports - Back button on split overview reopens split overview after returning from split row #78587

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.89-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78382
Email or phone of affected tester (no customers): applausetester+291201kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Go to Reports > Expenses.
  5. Select the expense via dropdown > Split.
  6. Click on any split row.
  7. Click RHP back button.
  8. Click RHP back button.

Expected Result:

RHP will close.

Actual Result:

Split overview reopens.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 30, 2025
  2. melvin-bot commented on Dec 30, 2025

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #78382

  3. melvin-bot commented on Dec 30, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Dec 30, 2025

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Dec 30, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. thienlnam commented on Dec 31, 2025

    @thienlnam
    Contributor

    Appears to come from #78382 - cc @daledah @ikevin127

  7. ikevin127 commented on Dec 31, 2025

    @ikevin127
    Contributor

    @daledah When will you be available to raise a follow-up ? Please let us know!

  8. daledah commented on Dec 31, 2025

    @daledah
    Contributor

    Please assign me. I'll raise PR soon

  9. daledah commented on Dec 31, 2025

    @daledah
    Contributor

    @thienlnam @ikevin127 we have the follow up PR here. This issue might be due to a conflict. Because when we create a previous PR, this commit have already changed the SPLIT_EXPENSE route, leading to inconsistencies.

  10. ikevin127 commented on Dec 31, 2025

    @ikevin127
    Contributor

    @daledah Are you saying that:

    1. This issue was not directly caused by our PRs changes and if we were to revert back to just after our PR was merged - we wouldn't be able to reproduce the issue ?

    2. Before we merged our PR, you merged main which brought somebody elses changes (commit) that actually caused this issue - and without that commit the issue would not be reproducible on our PR alone ?

    Trying to figure out whether this regression is on us or not - like if we could've caught it before merge 🤔

  11. daledah commented on Dec 31, 2025

    @daledah
    Contributor

    @ikevin127 I don’t think this should be considered a regression caused by my PR, because the issue in the split page already existed before. When the bug was fixed in the split page, we ended up creating a different route for it, which resulted in the bug not being fixed for the new route.

  12. mountiny commented on Dec 31, 2025

    @mountiny
    Contributor

    To avoid spending more money on another C+ reviewing the fix, I would propose to proceed with a revert to unblock the deploy and you can raise the new PR with a new fix included, you can just copy the test cases and video over to the new PR

  13. m-natarajan commented on Dec 31, 2025

    @m-natarajan

    Not repro in MacOS Monterey / Chrome Web v9.2.89-4

    Screen.Recording.2025-12-31.at.16.24.40.mp4

    Still reproduces, Xiaomi Redmi Note 10 / Android 12, App v9.2.89-3

    Screenrecorder-2025-12-31-16-34-35-584.mp4
  14. m-natarajan commented on Dec 31, 2025

    @m-natarajan

    Not repro, Xiaomi Redmi Note 10 / Android 12, App v9.2.89-3

    Screenrecorder-2025-12-31-17-02-12-918.mp4
  15. ikevin127 commented on Dec 31, 2025

    @ikevin127
    Contributor

    @daledah Well I guess since the PR was reverted we should proceed as instructed in #78587 (comment), then when payment will be due for the rework PR we'll have to demonstrate that this regression / revert wasn't caused by our PR directly - this in order to not get a bounty penalty - otherwise we'll get a penalty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions