Skip to content

Payments - Error message appears when making a bank account as a default payment #7868

New issue
New issue
Closed
Closed
Payments - Error message appears when making a bank account as a default payment#7868
Assignees
Justicea83
Labels
EngineeringImprovementItem broken or needs improvement.WeeklyKSv2

Description

@kbecciv
kbecciv
opened on Feb 22, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Go to staging.new.expensify.com and login with Beta account
  2. Go to the payments page.
  3. Click any existing payment method to set it to default.
  4. Click set default

Expected Result:

Success message appears and able to set a payment as a default one

Actual Result:

Failed to set a default method error appears

Error message:

Failed to set a default method error

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.39.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Email or phone of affected tester (no customers): applausetester++2501mn@applause.expensifail.com

Notes/Photos/Videos: Any additional supporting documentation

Bug5465466_Recording__91.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

Issue was found when execute the PR: #7782

View all open jobs on GitHub

Activity

  1. kbecciv
    added
    Engineering
    DailyKSv2
    on Feb 22, 2022
  2. MelvinBot
    assigned
    iwiznia
    on Feb 22, 2022

  3. MelvinBot commented on Feb 22, 2022

    @MelvinBot
    MelvinBot
    on Feb 22, 2022
    Contributor

    Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  4. kbecciv
    changed the title [-]Payments - Error message appears when making a bank account as a default payment met[/-] [+]Payments - Error message appears when making a bank account as a default payment[/+] on Feb 22, 2022

  5. timszot commented on Feb 23, 2022

    @timszot
    timszot
    on Feb 23, 2022
    Contributor

    @parasharrajat This is related to your PR #7782 that was merged yesterday. Can you take a look here please?

  6. parasharrajat commented on Feb 23, 2022

    @parasharrajat
    parasharrajat
    on Feb 23, 2022
    Member

    Ok. Thanks. I will debug this. It does not seem related to that change as I also used to get to before that regression on my account. I will update you shortly as this is image

  7. iwiznia commented on Feb 23, 2022

    @iwiznia
    iwiznia
    on Feb 23, 2022
    Contributor

    Reproducible in production?: Yes

    Given this, I doubt this is a deploy blocker.

  8. iwiznia commented on Feb 23, 2022

    @iwiznia
    iwiznia
    on Feb 23, 2022
    Contributor

    @kbecciv I need the user's email to be able to get logs and try to determine if this can be worked on by an contributor or not. Can you give me the email of the user you used and an approximate date and time (including time zone) when the test was done?
    Also, do we not include the user's email and other relevant data as part of the issue template??

  9. kbecciv commented on Feb 23, 2022

    @kbecciv
    kbecciv
    on Feb 23, 2022
    Author

    @iwiznia Here is the email user - applausetester++2501mn@applause.expensifail.com and an approximate date and time is 02/22/22 at 5:02 PM EST.

  10. parasharrajat commented on Feb 23, 2022

    @parasharrajat
    parasharrajat
    on Feb 23, 2022
    Member

    Ok, I tested it. This error is not a regression my PR. #7769 was a regression from the PR which I already solved and it is now on staging.

    This seems like a backend error.

  11. iwiznia commented on Feb 23, 2022

    @iwiznia
    iwiznia
    on Feb 23, 2022
    Contributor

    Thanks @kbecciv!

    Logs for the request are here. The error in question is:

    Throwing exception with message: '405 Invalid wallet account' from auth/command/SetWalletLinkedAccount.cpp:45

    Seems we throw that error when the wallet bank account used is not in OPEN state. I checked and indeed the bank account you are using (id 1432796) is in the SETUP state:

    ionatan@db2.sjc:~$ sudo readdb.sh -line "select * from bankaccounts where bankaccountid = 1432796"
       created = 2022-01-25 20:16:56
 bankAccountID = 1432796
     accountID = 11162433
       deleted = 0
 accountNumber = v8:76DAE4A475D1E2B955F559047674FE97
 routingNumber = 011401533
      checking = 0
   addressName = Alberta Bobbeth Charleson
additionalData = REDACTED
   addressCity = true
  addressState = true
    addressZip =
 defaultCredit = 0
         state = 4
  validateCode = REDACTED
     processor =
          type = 1

    Now, I am not sure what this means... is the bank account not supposed to be in that state? Are we not supposed to be calling that command in this scenario? I have no idea. Pinging @madmax330 and @MariaHCD as they might have some more context.

  12. MariaHCD commented on Feb 24, 2022

    @MariaHCD
    MariaHCD
    on Feb 24, 2022
    Contributor

    I think we don't want to call SetWalletLinkedAccount if the bank account is still in the setup state. cc: @stitesExpensify

  13. stitesExpensify commented on Feb 24, 2022

    @stitesExpensify
    stitesExpensify
    on Feb 24, 2022
    Contributor

    Hmm. So this PR updates the error messages and we take care of this case. Should we just do that? Or do you think we should actually prevent them from trying to default an account?

    Also once we release this, when will the wallet not be open?

    CC @kevinksullivan

  14. iwiznia
    removed their assignment
    on Feb 25, 2022
  15. iwiznia
    added
    ImprovementItem broken or needs improvement.
    WeeklyKSv2
    and removed
    DailyKSv2
    on Feb 25, 2022

  16. iwiznia commented on Feb 25, 2022

    @iwiznia
    iwiznia
    on Feb 25, 2022
    Contributor

    Hope you are not asking me, because I have no idea. Also, unassigning myself as triaging is done and people that know this better than me are involved.

  17. madmax330 commented on Feb 28, 2022

    @madmax330
    madmax330
    on Feb 28, 2022
    Contributor

    I think fixing the error messages is fine. It would tell them that the bank account they want to use isn't valid. Not much else to do.

  18. kevinksullivan commented on Mar 2, 2022

    @kevinksullivan
    kevinksullivan
    on Mar 2, 2022
    Contributor

    Was OOO and just catching up now.

    Or do you think we should actually prevent them from trying to default an account?

    Do you mean, should we not show the option to set a default when the bank account is not in the Open state? I am sure we will want to add a more comprehensive solution for showing bank accounts in the non-open state in product, and at that point we won't let you set those accounts as a default, but for now we can lean on the error messages.

    Also once we release this, when will the wallet not be open?

    Someone could not have an upgraded Wallet.

  19. Justicea83
    self-assigned this
    on Mar 3, 2022

  20. stitesExpensify commented on Mar 8, 2022

    @stitesExpensify
    stitesExpensify
    on Mar 8, 2022
    Contributor

    Cool well based on that I think we can just close this then. We are making the error messages much better, so the user will now know why the default failed

  21. stitesExpensify
    closed this as completedon Mar 8, 2022

  22. botify commented on Mar 8, 2022

    @botify
    botify
    on Mar 8, 2022

    Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

EngineeringImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions