Skip to content

Hovering over room avatar no tool tip is displayed #7884

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #7459

Action Performed:

  1. Open the app and login
  2. Create a workspace and members to it
  3. Create a room in the workspace created
  4. Hover over the room avatar in LHN

Expected Result:

Tool tip is displayed with members

Actual Result:

When hovering over the rooms in the LHN no tool tip is displayed

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.40-0

Reproducible in staging?: Y

Reproducible in production?: Y

Email or phone of affected tester (no customers): applausetester++2501mn@applause.expensifail.com / Utest123

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Issue was found when executing #7459

Bug5467048_Screen_Shot_2022-02-23_at_6 24 09_PM

Bug5467048_Recording__243.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Feb 23, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. NikkiWines commented on Feb 24, 2022

    @NikkiWines
    Contributor

    This looks good for UpWork.

    A note to whoever takes this on, it might be good to rope in our design team because we'll probably want to make some sort of truncated tooltip for larger rooms instead of having a tooltip that displays like 50+ emails/names

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 24, 2022
  4. MelvinBot commented on Feb 24, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  5. removed their assignment
    on Feb 24, 2022
  6. jeromekessler26 commented on Feb 24, 2022

    @jeromekessler26
    Screen.Recording.2022-02-24.at.12.35.31.AM.mov

    Saw this in issues and thought I would do it before it hits Upwork. Added custom tool tip for Rooms. Everything works. I styled it the best I could. Shows the first two members and if there are more than 2 just shows the remaining members after. Like joe.kessler88@gmail.com, jerome.kessler@drinkezapp.com and 2 members. Kinda new to this so if you want me to make a pull request let me know.

  7. parasharrajat commented on Feb 24, 2022

    @parasharrajat
    Member

    This should be part of #7459 if this change is required.

    But I don't think this needed. Room avatar is always static so it doesn't seem like it needs tooltip. I asked to remove it in the PR.

  8. jeromekessler26 commented on Feb 24, 2022

    @jeromekessler26

    Sounds good. If yall decide it is needed let me know. Personally seems like a good idea to show the room members in the tooltip. Also thought of possibly adding a long-press action to mobile applications so they can see tooltips. Just a thought.

  9. stephanieelliott commented on Feb 24, 2022

    @stephanieelliott
    Contributor

    Thanks @parasharrajat ! Closing this, but let's reopen if we do want to add a long-press action in the future as suggested by @jkgaming88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions