You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Hovering over room avatar no tool tip is displayed #7884
A note to whoever takes this on, it might be good to rope in our design team because we'll probably want to make some sort of truncated tooltip for larger rooms instead of having a tooltip that displays like 50+ emails/names
Saw this in issues and thought I would do it before it hits Upwork. Added custom tool tip for Rooms. Everything works. I styled it the best I could. Shows the first two members and if there are more than 2 just shows the remaining members after. Like joe.kessler88@gmail.com, jerome.kessler@drinkezapp.com and 2 members. Kinda new to this so if you want me to make a pull request let me know.
Sounds good. If yall decide it is needed let me know. Personally seems like a good idea to show the room members in the tooltip. Also thought of possibly adding a long-press action to mobile applications so they can see tooltips. Just a thought.
Activity
MelvinBot commentedon Feb 23, 2022
Triggered auto assignment to @NikkiWines (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.NikkiWines commentedon Feb 24, 2022
This looks good for UpWork.
A note to whoever takes this on, it might be good to rope in our design team because we'll probably want to make some sort of truncated tooltip for larger rooms instead of having a tooltip that displays like 50+ emails/names
MelvinBot commentedon Feb 24, 2022
Triggered auto assignment to @stephanieelliott (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.jeromekessler26 commentedon Feb 24, 2022
Screen.Recording.2022-02-24.at.12.35.31.AM.mov
Saw this in issues and thought I would do it before it hits Upwork. Added custom tool tip for Rooms. Everything works. I styled it the best I could. Shows the first two members and if there are more than 2 just shows the remaining members after. Like joe.kessler88@gmail.com, jerome.kessler@drinkezapp.com and 2 members. Kinda new to this so if you want me to make a pull request let me know.
parasharrajat commentedon Feb 24, 2022
This should be part of #7459 if this change is required.
But I don't think this needed. Room avatar is always static so it doesn't seem like it needs tooltip. I asked to remove it in the PR.
jeromekessler26 commentedon Feb 24, 2022
Sounds good. If yall decide it is needed let me know. Personally seems like a good idea to show the room members in the tooltip. Also thought of possibly adding a long-press action to mobile applications so they can see tooltips. Just a thought.
stephanieelliott commentedon Feb 24, 2022
Thanks @parasharrajat ! Closing this, but let's reopen if we do want to add a long-press action in the future as suggested by @jkgaming88.