You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expenses - Delete option is not displayed offline in Reports in bulk selected dropdown #78863
Version Number: 9.2.93-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#78325 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: MacBook Air 15.6.1 Chrome, iPhone 15 iOS 26.1 Safari App Component: Search
Action Performed:
Sign in to ND
Create two expense in the workspace chat
Go offline
Navigate to Reports/ Expenses and select the two expenses
Click "2 selected" green button and observe the options
Expected Result:
Delete option is presented in bulk selected dropdown menu offline in Reports/ Expenses, as it is presented in the workspace chat
Actual Result:
Delete option is not displayed in bulk selected dropdown menu offline in Reports/ Expenses
What alternative solutions did you explore? (Optional)
N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Please re-state the problem that we are trying to solve in this issue.
When a user is offline in the Reports/Expenses page (Search page), the Delete option is not displayed in the bulk selection dropdown menu. However, the same Delete option IS displayed when offline in the workspace chat. This creates an inconsistent user experience where bulk delete functionality is available in one place but hidden in another when offline.
What is the root cause of that problem?
The root cause is an inconsistent offline check between the Search page (Reports/Expenses) and the workspace chat:
onSelected: ()=>{if(isOffline){setIsOfflineModalVisible(true);return;}// ... rest of the delete logic}
When the user clicks Delete while offline, the existing handler will show an offline modal explaining that the action cannot be performed offline. This provides a consistent UX with the workspace chat where the option is visible but the action is gracefully blocked when offline.
What alternative solutions did you explore? (Optional)
Yeah, I believe this isn't a regression from our PR as it wasn't supported before our PR. I thought we deliberately disable some offline operations on search pages. cc @luacmartins
I agree. We don't allow some actions to be taken offline on search because right now those actions use a separate DeleteMoneyRequestOnSearch API command that doesn't work with optimistic data.
Activity
melvin-bot commentedon Jan 5, 2026
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Jan 5, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Delete option is not displayed in bulk selected dropdown menu offline in Reports/ Expenses
What is the root cause of that problem?
In SearchPage.tsx (used for Reports/Expenses), the delete option was hidden when offline due to a !isOffline check.
App/src/pages/Search/SearchPage.tsx
Lines 767 to 769 in 255cb87
What changes do you think we should make in order to solve the problem?
we should remove the
!isOffline &&checkApp/src/pages/Search/SearchPage.tsx
Lines 767 to 769 in 255cb87
Note: we can do the same for other actions
What alternative solutions did you explore? (Optional)
N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
abbasifaizan70 commentedon Jan 5, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user is offline in the Reports/Expenses page (Search page), the Delete option is not displayed in the bulk selection dropdown menu. However, the same Delete option IS displayed when offline in the workspace chat. This creates an inconsistent user experience where bulk delete functionality is available in one place but hidden in another when offline.
What is the root cause of that problem?
The root cause is an inconsistent offline check between the Search page (Reports/Expenses) and the workspace chat:
App/src/pages/Search/SearchPage.tsx
Lines 767 to 782 in 7f878a9
The
!isOffline &&condition explicitly hides the Delete option when the user is offline.App/src/hooks/useSelectedTransactionsActions.ts
Lines 345 to 362 in 7f878a9
There is NO
!isOfflinecheck here, so the Delete option is visible even when offline in the workspace chat.This inconsistency causes different behavior between the two screens.
What changes do you think we should make in order to solve the problem?
Remove the
!isOffline &&condition from theshouldShowDeleteOptionvariable inSearchPage.tsx.App/src/pages/Search/SearchPage.tsx
Lines 767 to 768 in 7f878a9
To:
This change is safe because the
onSelectedhandler already has logic to handle the offline case atApp/src/pages/Search/SearchPage.tsx
Lines 788 to 793 in 7f878a9
When the user clicks Delete while offline, the existing handler will show an offline modal explaining that the action cannot be performed offline. This provides a consistent UX with the workspace chat where the option is visible but the action is gracefully blocked when offline.
What alternative solutions did you explore? (Optional)
None
Demo
Screen.Recording.2026-01-06.at.12.45.00.AM.mov
mallenexpensify commentedon Jan 6, 2026
👀 please @DylanDylann and @eh2077 , you worked on the below which is linked in the OP. Is this a regression?
DylanDylann commentedon Jan 7, 2026
@mallenexpensify This isn’t a regression from #78325. Based on my review, this behavior is expected from the initial implementation.
eh2077 commentedon Jan 7, 2026
Yeah, I believe this isn't a regression from our PR as it wasn't supported before our PR. I thought we deliberately disable some offline operations on search pages. cc @luacmartins
luacmartins commentedon Jan 7, 2026
I agree. We don't allow some actions to be taken offline on search because right now those actions use a separate
DeleteMoneyRequestOnSearchAPI command that doesn't work with optimistic data.luacmartins commentedon Jan 7, 2026
We should just close this issue.