Payments - Nothing happens when tap on Transfer Balance

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing #7812

Action Performed:

Launch App and login
Go to Payment
Tap on Transfer balance

Expected Result:

Tap on transfer balance and user will be able to go through Onfido flow.

Actual Result:

Nothing happens when tap on Transfer Balance.

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: v1.1.40-0

Reproducible in staging?: Y

Reproducible in production?: Y

Email or phone of affected tester (no customers): applausetester+092021fish@applause.expensifail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/155574964-9965c0ec-aa95-4e09-80aa-13863a701d5f.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub
Issue found when executing #7812

@mountiny

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@JmillsExpensify

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

This looks like an External issue since it is UI related.

Huh... This is 4 days overdue. Who can take care of this?

@mountiny

@mountiny Thanks for the warm welcome! I'm getting started hopefully next week. Can you help me reassign this issue to @rushatgabhane

It's been about a week and we still have no takers, correct? If so, I can up the payout of the job to $500.

@nkuoch

@nkuoch Actually double-checking now where this issue comes from, can contributors test the transfer balance feature? Isn't it under beta?

@rushatgabhane could you confirm, you have a way to reproduce this issue, please?

@mountiny

@mountiny Tapping on wallet balance should do nothing. As per the code below, the transfer balance option will be visible only when the balance is greater than 0. So this issue is invalid!

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Lines 239 to 263 in 67f26ba

    
           {Permissions.canUseWallet(this.props.betas) && ( 
        
               <> 
        
                   <View style={[styles.mv5]}> 
        
                       <CurrentWalletBalance /> 
        
                   </View> 
        
                   {this.props.userWallet.currentBalance > 0 && ( 
        
                       <KYCWall 
        
                           onSuccessfulKYC={this.navigateToTransferBalancePage} 
        
                           enablePaymentsRoute={ROUTES.SETTINGS_ENABLE_PAYMENTS} 
        
                           addBankAccountRoute={ROUTES.SETTINGS_ADD_BANK_ACCOUNT} 
        
                           addDebitCardRoute={ROUTES.SETTINGS_ADD_DEBIT_CARD} 
        
                           popoverPlacement="bottom" 
        
                       > 
        
                           {triggerKYCFlow => ( 
        
                               <MenuItem 
        
                                   title={this.props.translate('common.transferBalance')} 
        
                                   icon={Expensicons.Transfer} 
        
                                   onPress={triggerKYCFlow} 
        
                                   shouldShowRightIcon 
        
                               /> 
        
                           )} 
        
                       </KYCWall> 
        
                   )} 
        
               </> 
        
           )}

@Santhosh-Sellavel

@Santhosh-Sellavel Thank you for chiming itn. That aligns with what @mvtglobally mentioned in this comment.

Sorry for not catching this earlier 🙇

@kavimuru @mvtglobally Could you please update the WA steps that in case of 0 balance the Transfer balance is not visible correctly?

@JmillsExpensify We can close this job on Upwork too, this is not bug but feature.

Ah great catch! I've closed out the Upwork job. For clarity, are you all keeping this issue open? If not, feel free to close it!

@Santhosh-Sellavel

Thank you, Jason! Great catch indeed @Santhosh-Sellavel!

I will just wait for QA to confirm they take this into consideration in future testing. @mvtglobally @kavimuru Can you confirm please? :)

@mountiny

@mountiny at this point we do not have any regular regressions for "transfer balance" flow as we are unable to test it due to KYC wall.

We will keep this in mind for any future PRs if they come up. But mostly all future updates will need to be internalQA

@mvtglobally

@mvtglobally Great point! Thank you very much! Closing now.

Navigation Menu

Repository navigation

Payments - Nothing happens when tap on Transfer Balance #7893

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

17 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	{Permissions.canUseWallet(this.props.betas) && (
	<>
	<View style={[styles.mv5]}>
	<CurrentWalletBalance />
	</View>
	{this.props.userWallet.currentBalance > 0 && (
	<KYCWall
	onSuccessfulKYC={this.navigateToTransferBalancePage}
	enablePaymentsRoute={ROUTES.SETTINGS_ENABLE_PAYMENTS}
	addBankAccountRoute={ROUTES.SETTINGS_ADD_BANK_ACCOUNT}
	addDebitCardRoute={ROUTES.SETTINGS_ADD_DEBIT_CARD}
	popoverPlacement="bottom"
	>
	{triggerKYCFlow => (
	<MenuItem
	title={this.props.translate('common.transferBalance')}
	icon={Expensicons.Transfer}
	onPress={triggerKYCFlow}
	shouldShowRightIcon
	/>
	)}
	</KYCWall>
	)}
	</>
	)}

Payments - Nothing happens when tap on Transfer Balance #7893

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Activity

MelvinBot commented on Feb 24, 2022

MelvinBot commented on Feb 24, 2022

mountiny commented on Feb 24, 2022

MelvinBot commented on Mar 1, 2022

17 remaining items

Santhosh-Sellavel commented on Mar 2, 2022

MelvinBot commented on Mar 2, 2022

JmillsExpensify commented on Mar 8, 2022

mountiny commented on Mar 8, 2022

Santhosh-Sellavel commented on Mar 8, 2022

mountiny commented on Mar 8, 2022

JmillsExpensify commented on Mar 9, 2022

mountiny commented on Mar 9, 2022

mvtglobally commented on Mar 9, 2022

mountiny commented on Mar 9, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions