Skip to content

[$250] iOS - Save the world - No whisper message indicating that the user referred a teacher #78938

Closed as not planned

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.94-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2678/folder/13176687/41237963/1108364042?sort=%2Bidentifier&p=2
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: iPhone 13 iOS 26.2
App Component: User Settings

Action Performed:

  1. Open the app
  2. Login with a new Expensifail account or one that is NOT part of the "Teachers Unite! testing policy" - We'll use this account as the "Principal"
  3. Navigate to Profile settings
  4. Click on "Save the World"
  5. Click on "I know a teacher"
  6. Fill the first and last name
  7. For the email, enter a new Expensifail account
  8. Click Let's do this!

Expected Result:

The user is redirected to a public room with a whisper message indicating that they referred a teacher

Actual Result:

No whisper message indicating that the user referred a teacher

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7042348_1767726932999.ScreenRecording_01-06-2026_11-26-24_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022011239066492005535
  • Upwork Job ID: 2011239066492005535
  • Last Price Increase: 2026-01-14
Issue OwnerCurrent Issue Owner: @marcaaron

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 6, 2026
  2. melvin-bot commented on Jan 6, 2026

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. MobileMage commented on Jan 6, 2026

    @MobileMage
    Contributor

    Please re-state the problem that we are trying to solve in this issue.

    When a user refers a teacher via "Save the World" > "I know a teacher" and submits the form, they are redirected to the #teachers-unite public room but no whisper message appears indicating that they referred a teacher.

    What is the root cause of that problem?

    In src/libs/actions/TeachersUnite.ts, the referTeachersUniteVolunteer function (line 26) creates optimistic data for the report but does not create an optimistic whisper report action:

    const optimisticData = [
        { key: `report_${publicRoomReportID}`, value: {...} },
        { key: `reportMetadata_${publicRoomReportID}`, value: {...} },
        // Missing: reportActions entry for whisper message
    ];

    The navigation happens immediately after the API call is queued, so the user sees the room before the backend whisper arrives.

    What changes do you think we should make in order to solve the problem?

    Add an optimistic whisper to referTeachersUniteVolunteer:

    1. TeachersUnite.ts - Add currentUserAccountID parameter and create optimistic whisper:

    const whisperMessage = Localize.translateLocal('teachersUnitePage.referredTeacherMessage', {firstName, lastName, partnerUserID});
    const optimisticWhisper = buildOptimisticAddCommentReportAction(whisperMessage, undefined, currentUserAccountID);
    optimisticWhisper.reportAction.whisperedToAccountIDs = [currentUserAccountID];

    2. KnowATeacherPage.tsx - Pass session?.accountID to the action

    3. en.ts/es.ts - Add referredTeacherMessage translation key

    What alternative solutions did you explore? (Optional)

    N/A
    Screenshots

    Image
  4. melvin-bot commented on Jan 9, 2026

    @melvin-bot

    @johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. melvin-bot commented on Jan 13, 2026

    @melvin-bot

    @johncschuster 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 14, 2026
  7. changed the title [-]iOS - Save the world - No whisper message indicating that the user referred a teacher[/-] [+][$250] iOS - Save the world - No whisper message indicating that the user referred a teacher[/+] on Jan 14, 2026
  8. melvin-bot commented on Jan 14, 2026

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 14, 2026
  10. melvin-bot commented on Jan 14, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

  11. 5 remaining items

  12. melvin-bot commented on Jan 24, 2026

    @melvin-bot

    @marcaaron Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  13. suneox commented on Jan 25, 2026

    @suneox
    Contributor

    Same as above — waiting for the internal team to handle this one

  14. added
    InternalRequires API changes or must be handled by Expensify staff
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 27, 2026
  15. marcaaron commented on Jan 27, 2026

    @marcaaron
    Contributor

    This seems pretty minor and not immediately obvious what the problem might be so I am dropping it to be a Weekly.

  16. marcaaron commented on Feb 18, 2026

    @marcaaron
    Contributor

    I looked into this and as far as I can tell the issue is not in the backend we queue all the relevant updates. There could be some other reason why the whisper message does not display. But I think we should re-test this to see if it's still happening.

  17. IuliiaHerets commented on Feb 18, 2026

    @IuliiaHerets

    Issue can't be reproduced anymore for QA team. Checked on Iphone 8/ iOS 16.7.14 stg (v9.3.-20-6) and prod (v9.3.-20-6)

    Repro.-.issues.78938.-.Staging.mp4
    Repro-.issue.78938.-.Prod.mp4
  18. marcaaron commented on Feb 18, 2026

    @marcaaron
    Contributor

    Great thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.Help WantedApply this label when an issue is open to proposals by contributorsInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions