You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-23] [$125] verifySignedCommits doesn't paginate commits and can thus miss unsigned commits #78960
The verifySignedCommits workflow doesn't paginate commits, so if a PR has more than 30 commits (default value for per_page), it doesn't properly detect unsigned commits after the 30th.
Repro steps
Create a fresh branch
Create 30 signed commits, then an unsigned one (this assumes your git config already has signature enabled by default)
# Create 30 signed commits on a new branchforiin {1..30};do
git commit --allow-empty -m "Test commit $i"done# Create an unsigned commit
git commit --no-gpg-sign --allow-empty -m "Unsigned commit test"
changed the title [-]`verifySignedCommits` doesn't paginate commits and can thus miss unsigned commits[/-][+][$250] `verifySignedCommits` doesn't paginate commits and can thus miss unsigned commits[/+]on Jan 6, 2026
changed the title [-][$125] `verifySignedCommits` doesn't paginate commits and can thus miss unsigned commits[/-][+][Due for payment 2026-01-23] [$125] `verifySignedCommits` doesn't paginate commits and can thus miss unsigned commits[/+]on Jan 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.3-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@linhvovan29546@CortneyOfstad The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Jan 6, 2026
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 6, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022008688139822676909
[-]`verifySignedCommits` doesn't paginate commits and can thus miss unsigned commits[/-][+][$250] `verifySignedCommits` doesn't paginate commits and can thus miss unsigned commits[/+]melvin-bot commentedon Jan 6, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @linhvovan29546 (
External)PiyushChandra17 commentedon Jan 6, 2026
I'd like to work on this, the solution is already detailed in OP.
22 remaining items
[-][$125] `verifySignedCommits` doesn't paginate commits and can thus miss unsigned commits[/-][+][Due for payment 2026-01-23] [$125] `verifySignedCommits` doesn't paginate commits and can thus miss unsigned commits[/+]melvin-bot commentedon Jan 16, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.3-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-01-23. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 16, 2026
@linhvovan29546 @CortneyOfstad The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
linhvovan29546 commentedon Jan 19, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/7981/changes#r2704420041
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
No regression tests
Do we agree 👍 or 👎
Create JS action to verify signed commits
CortneyOfstad commentedon Jan 23, 2026
@TaduJR — sent you an offer via Upwork here. Please let me know once you accept. Thanks!
TaduJR commentedon Jan 24, 2026
Offer Accepted @CortneyOfstad
Thanks!
CortneyOfstad commentedon Jan 26, 2026
Payment Summary
@linhvovan29546 – paid $125 via Upwork
@TaduJR – paid $125 via Upwork
Regression Test
Not need per comment here