Skip to content

[Due for payment 2026-01-23] [$125] verifySignedCommits doesn't paginate commits and can thus miss unsigned commits #78960

Closed

Description

@francoisl

Problem

The verifySignedCommits workflow doesn't paginate commits, so if a PR has more than 30 commits (default value for per_page), it doesn't properly detect unsigned commits after the 30th.

Repro steps

  1. Create a fresh branch
  2. Create 30 signed commits, then an unsigned one (this assumes your git config already has signature enabled by default)
    # Create 30 signed commits on a new branch
    for i in {1..30}; do
        git commit --allow-empty -m "Test commit $i"
    done
    
    # Create an unsigned commit
    git commit --no-gpg-sign --allow-empty -m "Unsigned commit test"
  3. Run the verifySignedCommits workflow
  4. Notice that it passes

Example PR – workflow passes despite unsigned 31st commit

Solution

Use octokit's pagination functionality to get all commits on the PR.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022008688139822676909
  • Upwork Job ID: 2008688139822676909
  • Last Price Increase: 2026-01-06
  • Automatic offers:
    • linhvovan29546 | Reviewer | 110029544
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. self-assigned this
    on Jan 6, 2026
  2. added
    ImprovementItem broken or needs improvement.
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 6, 2026
  3. melvin-bot commented on Jan 6, 2026

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    InternalRequires API changes or must be handled by Expensify staff
    on Jan 6, 2026
  5. melvin-bot commented on Jan 6, 2026

    @melvin-bot
  6. changed the title [-]`verifySignedCommits` doesn't paginate commits and can thus miss unsigned commits[/-] [+][$250] `verifySignedCommits` doesn't paginate commits and can thus miss unsigned commits[/+] on Jan 6, 2026
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 6, 2026
  8. melvin-bot commented on Jan 6, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @linhvovan29546 (External)

  9. PiyushChandra17 commented on Jan 6, 2026

    @PiyushChandra17
    Contributor

    I'd like to work on this, the solution is already detailed in OP.

  10. 22 remaining items

  11. changed the title [-][$125] `verifySignedCommits` doesn't paginate commits and can thus miss unsigned commits[/-] [+][Due for payment 2026-01-23] [$125] `verifySignedCommits` doesn't paginate commits and can thus miss unsigned commits[/+] on Jan 16, 2026
  12. melvin-bot commented on Jan 16, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jan 16, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.3-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-23. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Jan 16, 2026

    @melvin-bot

    @linhvovan29546 @CortneyOfstad The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. linhvovan29546 commented on Jan 19, 2026

    @linhvovan29546
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/7981/changes#r2704420041

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    No regression tests

    Do we agree 👍 or 👎

  16. CortneyOfstad commented on Jan 23, 2026

    @CortneyOfstad
    Contributor

    @TaduJR — sent you an offer via Upwork here. Please let me know once you accept. Thanks!

  17. TaduJR commented on Jan 24, 2026

    @TaduJR
    Contributor

    @TaduJR — sent you an offer via Upwork here. Please let me know once you accept. Thanks!

    Offer Accepted @CortneyOfstad

    Thanks!

  18. CortneyOfstad commented on Jan 26, 2026

    @CortneyOfstad
    Contributor

    Payment Summary

    @linhvovan29546 – paid $125 via Upwork
    @TaduJR – paid $125 via Upwork

    Regression Test

    Not need per comment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions