Repository navigation
IOS - Attachment - Image upload remains loading #7900
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Click on a conversation
- Click on add attachment
- Upload an image
- Verify a preview is displayed
- Click on upload
- Verify the image is uploaded
Expected Result:
The image is uploaded and you can see the image in the conversation
Actual Result:
The image doesn't load and you can't see it in the conversation.
Image.from.iOS.2.MP4
Workaround:
Unknown
Platform:
Where is this issue occurring?
- iOS
Version Number: 1.1.40.0
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): veraclementina@gmail.com](mailto:veraclementina@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
Activity
OSBotify commentedon Feb 24, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon Feb 24, 2022
Triggered auto assignment to @roryabraham (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.kidroca commentedon Feb 24, 2022
maybe related to this PR that added loading to images : #7723
mdneyazahmad commentedon Feb 25, 2022
There are two related pr #7723 and #7569
These two pr handles two different issues.
Could you please confirm, when this issue occurs (uploading or after uploaded)?
roryabraham commentedon Feb 26, 2022
Sorry for the delay, looking into this now!
roryabraham commentedon Feb 26, 2022
Reproduced on
main, checking #7723 firstroryabraham commentedon Feb 26, 2022
Doesn't seem like #7723 or #7569 caused this 🤔
roryabraham commentedon Feb 26, 2022
Not sure, but it's possible this is just a side-effect of infra issues we had today
mdneyazahmad commentedon Feb 26, 2022
@roryabraham thanks for your investigation. I have seen many times when internet connection is not good it keeps loading. This is in general not related to this issue only but to the entire app. Do we have a mechanism to handle this situation and give the user a proper error message or some sort of feedback that something went wrong after a specific time?
kidroca commentedon Feb 28, 2022
@roryabraham @mdneyazahmad It's definitely a problem from #7723
Reverting it fixes the problem for me (tested on physical device, not sure if that matters)
See how even attachments that were sent ages ago are "loading" but as soon as I revert changes made to `ImageWithSizeCalculation.js they instantly load
RPReplay_Final1646043126.MP4.mp4
kidroca commentedon Feb 28, 2022
I think
loading: trueshould be set duringonLoadStartinstead of hardcoding totruein the constructorOr this should be removed
this.state.isLoading && styles.dNone,asdisplay: noneseem to prevent to trigger the normal image life cycle in the first placemountiny commentedon Feb 28, 2022
Thank you @kidroca, I have created a revert PR #7933 so Rory can then merge and @mdneyazahmad will look into the feedback you provided.
roryabraham commentedon Feb 28, 2022
Thanks @kidroca ... not sure why reverting #7723 didn't seem to resolve the problem for me, testing with my local back-end and a simulator. Going to retest now
roryabraham commentedon Feb 28, 2022
For some reason I am still unable to load images from my dev API, working on it...
roryabraham commentedon Feb 28, 2022
On my dev API, I'm actually seeing this log line in a network error where we fail to get the image size 🤔
mountiny commentedon Feb 28, 2022
@roryabraham Confirmed locally that the revert branch works for me, images already sent load and new upload shows up too.
roryabraham commentedon Feb 28, 2022
Got my VM/simulator issues sorted, merged the revert 👍
mvtglobally commentedon Feb 28, 2022
Issue is fixed https://user-images.githubusercontent.com/43995119/156066550-9f44977a-ddf0-45a0-86b5-802a9da6b224.MOV
yuwenmemon commentedon Feb 28, 2022
Great! Removing the blocker label then and closing this out!