You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
Reports show the “Missing category” and “Hold” violation twice for the same expense instead of only once.
What is the root cause of that problem?
The code that adds the HOLD violation does not check if a HOLD violation already exists for the transaction. As a result, every time the expense is processed, a new violation is appended, causing duplicates in Onyx and the UI.
What changes do you think we should make in order to solve the problem?
Add a check before pushing a new HOLD violation to the transactionViolations array. Only add the violation if it does not already exist.
This is no longer reproducible in v9.2.95-2 (Note: I had to enable Workspaces > {workspace} > Categories > Settings > Members must tag or categorize all expenses).
Activity
melvin-bot commentedon Jan 7, 2026
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 7, 2026
Triggered auto assignment to @marcaaron (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 7, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 7, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
twinkle-react commentedon Jan 7, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Reports show the “Missing category” and “Hold” violation twice for the same expense instead of only once.
What is the root cause of that problem?
The code that adds the HOLD violation does not check if a HOLD violation already exists for the transaction. As a result, every time the expense is processed, a new violation is appended, causing duplicates in Onyx and the UI.
What changes do you think we should make in order to solve the problem?
Add a check before pushing a new HOLD violation to the
transactionViolationsarray. Only add the violation if it does not already exist.File:
src/libs/actions/IOU/index.tsDescription of change:
hasHoldViolationcheck to ensure a HOLD violation is only added once per transaction.Justification:
src/libs/actions/IOU/index.tsowns the logic for creating and storing transaction violations.Final Enforcement Line:
The fix narrows the existing write to Onyx by only adding a HOLD violation if it does not already exist.
What alternative solutions did you explore? (Optional)
N/A
arosiclair commentedon Jan 7, 2026
This is no longer reproducible in v9.2.95-2 (Note: I had to enable Workspaces > {workspace} > Categories > Settings > Members must tag or categorize all expenses).
I think reverting #78315 probably fixed this cc @ikevin127 @jayeshmangwani @JS00001