Android - Chat - Unread message does not disappear from LHN in focus mode

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Launch the app
Log in with any account
Navigate to a conversation (conv 1)
Click on the Pin icon on top right to pin the conversation to the top of LHN
Navigate to another conversation (conv 2)
Write something on compose box and navigate away from the conversation
Check on LHN that the conversation now has a pencil icon indicating there’s a draft in the conversation
Navigate to another conversation (conv 3) and mark message as unread
Navigate away from the conversation and verify conv 3 is marked as unread (with bold letters) in LHN
Navigate to settings by clicking on the user avatar over the LHN
Click on preferences
Click on the Priority Mode option and select “#focus”
“#focus” mode should display all pinned conversations and also all that have unread messages and draft
Verify the 3 conversations with are displayed in LHN
Navigate to the unread conversation (conv 3) and open it so it's marked as unread

Expected Result:

Verify conversation 3 is not displayed in LHN anymore

Actual Result:

Unread message does not disappear from LHN

Workaround:

Unknown

Platform:

Where is this issue occurring?

Android

Version Number: 1.1.40
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856

Bug5468371_Screen_Recording_20220224-213453_New_Expensify.mp4

Notes/Photos/Videos:
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

view this job

@marcaaron

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@jboniface

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Proposal

In here, For sidebar Options in focus mode, we have a filter for read reports alone. Using hideReadReports: true

App/src/libs/OptionsListUtils.js

Lines 706 to 711 in 53a9891

    
           if (priorityMode === CONST.PRIORITY_MODE.GSD) { 
        
               sideBarOptions = { 
        
                   hideReadReports: true, 
        
                   sortByAlphaAsc: true, 
        
               }; 
        
           }

hideReadReports is configurable filter criteria for the getOption method

App/src/libs/OptionsListUtils.js

Line 351 in 53a9891

function getOptions(reports, personalDetails, activeReportID, {

In the following lines, report gets filtered only when it hasreport.unreadActionCount === 0

App/src/libs/OptionsListUtils.js

Lines 410 to 419 in 53a9891

    
           const shouldFilterReportIfEmpty = !showReportsWithNoComments && report.lastMessageTimestamp === 0 && !ReportUtils.isDefaultRoom(report); 
        
           const shouldFilterReportIfRead = hideReadReports && report.unreadActionCount === 0; 
        
           const shouldFilterReport = shouldFilterReportIfEmpty || shouldFilterReportIfRead; 
        
           if (report.reportID !== activeReportID 
        
               && !report.isPinned 
        
               && !hasDraftComment 
        
               && shouldFilterReport 
        
               && !reportContainsIOUDebt) { 
        
               return; 
        
           }

Since hideReadReports criteria is used for sidebarOptions alone, we remove the criteria.
Add a new criteria hideReports in getOptions method.

Now use hideReports in the filter and refactor the filter block as shown below.

       const shouldFilterReportIfEmpty = !showReportsWithNoComments && report.lastMessageTimestamp === 0 && !ReportUtils.isDefaultRoom(report);
       const shouldFilterReport = hideReports || shouldFilterReportIfEmpty;
       if (report.reportID !== activeReportID
           && !report.isPinned
           && !hasDraftComment
           && shouldFilterReport
           && !reportContainsIOUDebt) {
           return;
       }

Removed shouldFilterReportIfRead as we need to filter both read & unread reports and used hideReports in shouldFilterReport along with existing criterias.

This should be enough to handle this issue.
Thanks!

@jboniface

@jboniface Whoops! This issue is 2 days overdue. Let's get this updated quick!

post here https://www.upwork.com/jobs/~0148dbc5ffaba75ff9

@rushatgabhane

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

@marcaaron

Triggered auto assignment to @marcaaron (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Santhosh-Sellavel

Hmm, @Santhosh-Sellavel could you please help me understand why this is a bug?

The unread report is the most recent report. It shouldn't disappear once we've read it.
It should disappear only if we've read it, anddd we navigate to a different report.

I hope I'm making sense

@rushatgabhane

@rushatgabhane
My learnings here, on focus mode we can just have selected chats alone, and ignore other chats.

Also, Issue was reported by Applause here.

Do you agree that this issue should be closed?

I think this isn't a bug and we shouldn't remove unread chats from LHN. If we only keep pinned chats in the LHN then how the user would know about the new messages from a chat that isn't pinned by the user, it's not a good ux

@rushatgabhane

@rushatgabhane I am 50-50 here, so let's ask in the Slack channel to get an opinion on what's expected here.

Asked in channel thread link

Great, thanks. Added my thoughts in the 🧵

@marcaaron

If we assume that NewDot is supposed to work the same on all platforms then, when the current chat is open in the main view, it'd also be shown in LHN, on web/desktop. I think, in the screen vid in the OP, that it's not disappearing because the user hasn't navigated to a new report

@marcaaron we've reached a consensus to close this issue in this slack thread.

Sounds good thanks

Navigation Menu

Repository navigation

Android - Chat - Unread message does not disappear from LHN in focus mode #7903

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Proposal

3 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (priorityMode === CONST.PRIORITY_MODE.GSD) {
	sideBarOptions = {
	hideReadReports: true,
	sortByAlphaAsc: true,
	};
	}

	const shouldFilterReportIfEmpty = !showReportsWithNoComments && report.lastMessageTimestamp === 0 && !ReportUtils.isDefaultRoom(report);
	const shouldFilterReportIfRead = hideReadReports && report.unreadActionCount === 0;
	const shouldFilterReport = shouldFilterReportIfEmpty \|\| shouldFilterReportIfRead;
	if (report.reportID !== activeReportID
	&& !report.isPinned
	&& !hasDraftComment
	&& shouldFilterReport
	&& !reportContainsIOUDebt) {
	return;
	}

Android - Chat - Unread message does not disappear from LHN in focus mode #7903

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Activity

MelvinBot commented on Feb 25, 2022

MelvinBot commented on Feb 25, 2022

Santhosh-Sellavel commented on Feb 25, 2022

Proposal

MelvinBot commented on Feb 28, 2022

jboniface commented on Feb 28, 2022

3 remaining items

MelvinBot commented on Feb 28, 2022

MelvinBot commented on Feb 28, 2022

rushatgabhane commented on Mar 3, 2022

Santhosh-Sellavel commented on Mar 3, 2022

rushatgabhane commented on Mar 3, 2022

thesahindia commented on Mar 3, 2022

Santhosh-Sellavel commented on Mar 4, 2022

Santhosh-Sellavel commented on Mar 4, 2022

rushatgabhane commented on Mar 5, 2022

rushatgabhane commented on Mar 14, 2022

marcaaron commented on Mar 14, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions