Repository navigation
[HOLD for payment 2022-06-15] $500 If your have your language set to Spanish, the currency is not localized when you select it #7915
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Set app language to spanish
- Navigate to IOU
- Check currency display
Expected Result:
Currency should be localized
Actual Result:
Currency is not localized.
It should be. ie: if I select USD, the symbol shown should be US$ and not just $.
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.1.40-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @iwiznia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1645483634039679
Activity
MelvinBot commentedon Feb 25, 2022
Triggered auto assignment to @robertjchen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.robertjchen commentedon Feb 28, 2022
Great catch, opening this up for a contributor to tackle! 👍
MelvinBot commentedon Feb 28, 2022
Triggered auto assignment to @laurenreidexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.[-]If your have your language set to Spanish, when selecting the currency is not localized [/-][+]If your have your language set to Spanish, the currency is not localized when you select it [/+]laurenreidexpensify commentedon Feb 28, 2022
https://www.upwork.com/jobs/~0194843e6376082b51
MelvinBot commentedon Feb 28, 2022
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
Exported)43 remaining items
melvin-bot commentedon May 26, 2022
This issue has not been updated in over 15 days. @tgolen, @parasharrajat, @laurenreidexpensify, @mdneyazahmad eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
laurenreidexpensify commentedon May 31, 2022
@parasharrajat @mdneyazahmad what's the latest here on the PR ? Who are we waiting on to take the next action: contributor, contributor plus or Expensify engineer?
mdneyazahmad commentedon May 31, 2022
@laurenreidexpensify waiting review from @tgolen
mountiny commentedon Jun 6, 2022
Merged, let's hope everything will go smooth 🎉 Great work @mdneyazahmad
[-]$500 If your have your language set to Spanish, the currency is not localized when you select it [/-][+][HOLD for payment 2022-06-15] $500 If your have your language set to Spanish, the currency is not localized when you select it [/+]melvin-bot commentedon Jun 8, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.73-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-06-15. 🎊
laurenreidexpensify commentedon Jun 15, 2022
Everyone has been paid. Hurrah 4 months later and we're finally done :) Well done everyone!