Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.2.99-8
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2769/folder/13176709/41236921/1119954416?sort=%2Bidentifier
Email or phone of affected tester (no customers): poipio514+owner2@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Windows 11 / Chrome
App Component: Workspace Settings
Action Performed:
Preconditions:
Prepare 4 accounts:
- Workspace Owner
- Employee
- Approver 1
- Approver 2
The Owner has a controlled workspace with an advanced approval workflow:
- Employee submits to Approver 1
- Approver 2 is the final approver
Steps:
- Log in as the Employee.
- Create an expense in the workspace and submit it for approval.
- Log in as the Owner.
- Navigate to OldDot (OD).
- Remove Approver 1 and Approver 2 from the approval workflow so they are no longer approvers, and set all approval steps to the Owner.
- Navigate back to NewDot (ND).
- Go to the employee’s workspace chat and open the expense created in step 2.
Expected Result:
- Approver 1 has been removed from the chat member list.
- The next approver shown is the workspace Owner.
Actual Result:
- Approver 1 is still displayed in the chat member list.
- The next approver shown is Approver 1.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
Screenshots/Videos
Bug7047710_1768292138677.remove_approver.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022013264868881335802
- Upwork Job ID: 2013264868881335802
- Last Price Increase: 2026-04-14
Issue Owner
Current Issue Owner: @francoislMetadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Jan 13, 2026
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 17, 2026
@CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
CortneyOfstad commentedon Jan 19, 2026
Getting eyes on this!
[-]Workspace - One of the approver still appears in employe's WS chat after removing it in OD[/-][+][$250] Workspace - One of the approver still appears in employe's WS chat after removing it in OD[/+]melvin-bot commentedon Jan 19, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022013264868881335802
melvin-bot commentedon Jan 19, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @huult (
External)annaweber830 commentedon Jan 20, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
After an owner edits a workspace’s advanced approval workflow in OldDot (removing approvers and setting approvals to the owner), NewDot does not immediately reflect those changes. In the employee’s workspace chat, one removed approver still appears in the Members list, and the “next approver” shown in next steps remains the old approver instead of the owner.
What is the root cause of that problem?
When switching back from OldDot → NewDot, the NewDot client can continue using stale Onyx state (policy employeeList/approval chain and/or report participants) because we don’t reliably refresh/fetch incremental updates on transition. As a result, UI logic that derives:
keeps showing outdated approver data until some later refresh occurs.
What changes do you think we should make in order to solve the problem?
removed approvers are no longer listed as workspace chat members, and
“next approver” updates to the owner as expected.
App/src/libs/actions/Session/index.ts
Lines 79 to 81 in e54cfd4
App/src/libs/actions/Session/index.ts
Lines 655 to 668 in e54cfd4
App/src/libs/actions/App.ts
Lines 81 to 88 in e54cfd4
App/src/libs/actions/App.ts
Lines 586 to 588 in e54cfd4
What alternative solutions did you explore? (Optional)
95 remaining items
melvin-bot commentedon Apr 14, 2026
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
melvin-bot commentedon Apr 14, 2026
@francoisl 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
CortneyOfstad commentedon Apr 16, 2026
Bump @francoisl on the comment here — thanks!
melvin-bot commentedon Apr 16, 2026
@francoisl 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
huult commentedon Apr 17, 2026
Same
melvin-bot commentedon Apr 17, 2026
📣 @tradego579! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
francoisl commentedon Apr 17, 2026
Sorry I haven't had time to look into this yet, hoping to get to it soon 🤞
CortneyOfstad commentedon Apr 20, 2026
No worries — thanks @francoisl!
melvin-bot commentedon Apr 20, 2026
@francoisl Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
francoisl commentedon Apr 20, 2026
I don't think this is a bug, changing the approval workflow of a workspace just doesn't edit the current approver on processing reports. We also can't change this behavior for Classic, because submitters can choose to submit reports to someone else than their
submitsToif approval workflows are not strictly enforced.