Skip to content

[Due for payment 2026-01-21] QBO - Search field in QuickBooks Online debit card export page is missing "Search" label #79458

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.0-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #79080
Email or phone of affected tester (no customers): applausetester+120101abc@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Assign a company card to any workspace member.
  • Workspace is connected to QBO.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Accounting.
  3. Click Export > Export company card expenses as.
  4. Click Export as > Debit card.
  5. Close the RHP.
  6. Go to workspace settings > Company card.
  7. Click on the assigned company card.
  8. Click QuickBooks Online debit card export.

Expected Result:

Search field in QuickBooks Online debit card export page will show "Search" label.

Actual Result:

Search field in QuickBooks Online debit card export page is missing "Search" label.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7047989_1768306160143.13.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 13, 2026
  2. melvin-bot commented on Jan 13, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #79080

  3. melvin-bot commented on Jan 13, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Jan 13, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Jan 13, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Jan 13, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #79080 - "Make SelectionScreen use new SelectionList" by @zfurtak (High confidence)
    Related Issues: None

    Recommendation: REVERT

    The PR introduced a bug in the SelectionScreen component where textInputOptions is created with incorrect property names (textInputLabel and textInputValue instead of label and value), causing the search field label to not display.

    📋 Detailed Analysis

    Evidence

    PR #79080 refactored SelectionScreen to use the new SelectionList component instead of SelectionListWithSections. During this migration, the way text input options are passed changed:

    Old approach (SelectionListWithSections):

    • Direct props: textInputLabel, textInputValue, onChangeText

    New approach (SelectionList):

    • Single object prop: textInputOptions with properties: label, value, onChangeText

    The Bug:
    In src/components/SelectionScreen.tsx lines 150-154, the code creates:

    const textInputOptions = {
        onChangeText,
        textInputLabel,  // ❌ Should be: label
        textInputValue,  // ❌ Should be: value
    };

    The new SelectionList component expects textInputOptions.label and textInputOptions.value, but SelectionScreen is passing textInputOptions.textInputLabel and textInputOptions.textInputValue.

    In BaseSelectionList.tsx line 85:

    shouldShowTextInput = !!textInputOptions?.label,

    And line 307:

    accessibilityLabel={textInputOptions?.label}

    Since textInputOptions.label is undefined, the label is not displayed.

    Root Cause

    During the refactoring from SelectionListWithSections to SelectionList, the property names in the textInputOptions object were not updated to match the new API. This affects all pages using SelectionScreen with a search field, including the QuickBooks Online debit card export page mentioned in this issue.

    Reproduction

    The bug is reproducible in staging only (not production) and affects all platforms. It impacts any page using SelectionScreen with search functionality, particularly visible in:

    • Workspace > Company card > QuickBooks Online debit card export page
    • Any other accounting integration pages with search fields
  7. 3 remaining items

  8. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 14, 2026
  9. changed the title [-]QBO - Search field in QuickBooks Online debit card export page is missing "Search" label[/-] [+][Due for payment 2026-01-21] QBO - Search field in QuickBooks Online debit card export page is missing "Search" label[/+] on Jan 14, 2026
  10. melvin-bot commented on Jan 14, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jan 14, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.1-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-21. 🎊

    For reference, here are some details about the assignees on this issue:

    • @zfurtak does not require payment (Contractor)
  12. melvin-bot commented on Jan 14, 2026

    @melvin-bot

    @grgia @mallenexpensify @zfurtak The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. mallenexpensify commented on Jan 23, 2026

    @mallenexpensify
    Contributor

    No payment due. No test case cuz issues came from one. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions