Skip to content

[Due for payment 2026-01-23] [$250] Reports - Delete option is missing for unreported expenses on Reports #79618

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.2-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #79328
Email or phone of affected tester (no customers): sdjoisdjnsoinjsdosiod@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Create an expense.
  4. Go to Reports > Expenses.
  5. Select the expense via checkbox.
  6. Click dropdown button.

Expected Result:

Delete option will be present.

Actual Result:

Delete option is missing for unreported expenses on Reports.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7049464_1768430675417.8.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022011769383385920319
  • Upwork Job ID: 2011769383385920319
  • Last Price Increase: 2026-01-15
Issue OwnerCurrent Issue Owner: @shubham1206agra

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jan 14, 2026
  2. melvin-bot commented on Jan 14, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #79328

  3. melvin-bot commented on Jan 14, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Jan 14, 2026

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Jan 14, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Jan 14, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #79328 - "refactor: isolate ONYXKEYS.COLLECTION.TRANSACTION changeTransactionsReport" by @Guccio163 (High confidence)
    Related Issues: None

    Recommendation: REVERT

    The PR should be reverted as it introduced a regression that prevents users from deleting unreported expenses on the Reports page, which is core functionality for expense management.

    Labels: Keeping DeployBlockerCash (App deploy is blocked), removing DeployBlocker as this is a frontend-only issue.

    Detailed Analysis

    Evidence

    PR #79328 was a refactor that changed the changeTransactionsReport function in src/libs/actions/Transaction.ts to require an explicit allTransactionsCollection parameter instead of using Onyx.connect subscription.

    The PR description states: "This PR is part of a refactor to remove Onyx.connect for the keys: ONYXKEYS.COLLECTION.TRANSACTION from the src/libs/actions/Transaction.ts file and replace it with useOnyx. It isolates the changeTransactionsReport function from the ONYXKEYS.COLLECTION.TRANSACTION Onyx.connect key."

    Key changes in the PR:

    1. Changed changeTransactionsReport function signature to accept allTransactionsCollection: OnyxCollection<Transaction> as a required parameter
    2. Updated all call sites of changeTransactionsReport to pass the transactions collection
    3. Created a new AddUnreportedExpenseFooter component

    Verification

    The bug affects the delete option for unreported expenses on the Reports page (Search results).

    Affected files:

    Confirmation of PR involvement:
    The PR modifies how transactions are accessed in multiple places. While it updated call sites that explicitly call changeTransactionsReport, the search results page logic for determining available actions (including delete) was not updated to account for the refactored data access pattern.

    In SearchPage.tsx lines ~1001-1014, the code retrieves transactions from search results to check if they can be deleted. For unreported transactions (those without a report or with reportID === CONST.REPORT.UNREPORTED_REPORT_ID), the parentReport lookup may fail to find the necessary data after the refactor, causing canDeleteMoneyRequestReport to return false even when delete should be allowed.

    Root Cause

    The refactor changed how transaction data is accessed throughout the codebase from a centralized Onyx.connect subscription to explicit parameter passing. While direct call sites were updated, indirect code paths that rely on transaction data being available in search results were not fully accounted for. The delete option visibility check in SearchPage expects unreported transactions to be properly accessible, but after the refactor this data access pattern may be broken for the unreported expense case.

    The issue is reproducible only on staging (not production) and only affects Reports page, confirming this PR (which is only on staging) is the cause.

  7. 1 remaining item

  8. Guccio163 commented on Jan 15, 2026

    @Guccio163
    Contributor

    Looks like the bug was introduced in this commit merging this PR, it doesn't occur one commit earlier on main, should be worth checking out 👀

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 15, 2026
  10. changed the title [-]Reports - Delete option is missing for unreported expenses on Reports[/-] [+][$250] Reports - Delete option is missing for unreported expenses on Reports[/+] on Jan 15, 2026
  11. melvin-bot commented on Jan 15, 2026

    @melvin-bot
  12. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 15, 2026
  13. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

  14. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 15, 2026
  15. IuliiaHerets commented on Jan 15, 2026

    @IuliiaHerets

    Windows 10/ Chrome
    v9.3.2-1
    Not Repro

    Repro.-.issue.79618.mp4
  16. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 16, 2026
  17. changed the title [-][$250] Reports - Delete option is missing for unreported expenses on Reports[/-] [+][Due for payment 2026-01-23] [$250] Reports - Delete option is missing for unreported expenses on Reports[/+] on Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions