You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-23] [$250] Reports - Delete option is missing for unreported expenses on Reports #79618
Version Number: 9.3.2-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#79328 Email or phone of affected tester (no customers):sdjoisdjnsoinjsdosiod@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.1 / Chrome App Component: Search
Action Performed:
Go to staging.new.expensify.com
Go to self DM.
Create an expense.
Go to Reports > Expenses.
Select the expense via checkbox.
Click dropdown button.
Expected Result:
Delete option will be present.
Actual Result:
Delete option is missing for unreported expenses on Reports.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #79328 - "refactor: isolate ONYXKEYS.COLLECTION.TRANSACTION changeTransactionsReport" by @Guccio163 (High confidence) Related Issues: None
Recommendation: REVERT
The PR should be reverted as it introduced a regression that prevents users from deleting unreported expenses on the Reports page, which is core functionality for expense management.
Labels: Keeping DeployBlockerCash (App deploy is blocked), removing DeployBlocker as this is a frontend-only issue.
Detailed Analysis
Evidence
PR #79328 was a refactor that changed the changeTransactionsReport function in src/libs/actions/Transaction.ts to require an explicit allTransactionsCollection parameter instead of using Onyx.connect subscription.
The PR description states: "This PR is part of a refactor to remove Onyx.connect for the keys: ONYXKEYS.COLLECTION.TRANSACTION from the src/libs/actions/Transaction.ts file and replace it with useOnyx. It isolates the changeTransactionsReport function from the ONYXKEYS.COLLECTION.TRANSACTION Onyx.connect key."
Key changes in the PR:
Changed changeTransactionsReport function signature to accept allTransactionsCollection: OnyxCollection<Transaction> as a required parameter
Updated all call sites of changeTransactionsReport to pass the transactions collection
Created a new AddUnreportedExpenseFooter component
Verification
The bug affects the delete option for unreported expenses on the Reports page (Search results).
Affected files:
src/pages/Search/SearchPage.tsx - Contains the dropdown options logic that checks if delete should be available
src/libs/ReportUtils.ts - Contains canDeleteMoneyRequestReport function that validates delete permissions
Confirmation of PR involvement:
The PR modifies how transactions are accessed in multiple places. While it updated call sites that explicitly call changeTransactionsReport, the search results page logic for determining available actions (including delete) was not updated to account for the refactored data access pattern.
In SearchPage.tsx lines ~1001-1014, the code retrieves transactions from search results to check if they can be deleted. For unreported transactions (those without a report or with reportID === CONST.REPORT.UNREPORTED_REPORT_ID), the parentReport lookup may fail to find the necessary data after the refactor, causing canDeleteMoneyRequestReport to return false even when delete should be allowed.
Root Cause
The refactor changed how transaction data is accessed throughout the codebase from a centralized Onyx.connect subscription to explicit parameter passing. While direct call sites were updated, indirect code paths that rely on transaction data being available in search results were not fully accounted for. The delete option visibility check in SearchPage expects unreported transactions to be properly accessible, but after the refactor this data access pattern may be broken for the unreported expense case.
The issue is reproducible only on staging (not production) and only affects Reports page, confirming this PR (which is only on staging) is the cause.
changed the title [-]Reports - Delete option is missing for unreported expenses on Reports[/-][+][$250] Reports - Delete option is missing for unreported expenses on Reports[/+]on Jan 15, 2026
changed the title [-][$250] Reports - Delete option is missing for unreported expenses on Reports[/-][+][Due for payment 2026-01-23] [$250] Reports - Delete option is missing for unreported expenses on Reports[/+]on Jan 16, 2026
Activity
melvin-bot commentedon Jan 14, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #79328
melvin-bot commentedon Jan 14, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Jan 14, 2026
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jan 14, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 14, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #79328 - "refactor: isolate ONYXKEYS.COLLECTION.TRANSACTION changeTransactionsReport" by @Guccio163 (High confidence)
Related Issues: None
Recommendation: REVERT
The PR should be reverted as it introduced a regression that prevents users from deleting unreported expenses on the Reports page, which is core functionality for expense management.
Labels: Keeping
DeployBlockerCash(App deploy is blocked), removingDeployBlockeras this is a frontend-only issue.Detailed Analysis
Evidence
PR #79328 was a refactor that changed the
changeTransactionsReportfunction insrc/libs/actions/Transaction.tsto require an explicitallTransactionsCollectionparameter instead of using Onyx.connect subscription.The PR description states: "This PR is part of a refactor to remove Onyx.connect for the keys: ONYXKEYS.COLLECTION.TRANSACTION from the src/libs/actions/Transaction.ts file and replace it with useOnyx. It isolates the changeTransactionsReport function from the ONYXKEYS.COLLECTION.TRANSACTION Onyx.connect key."
Key changes in the PR:
changeTransactionsReportfunction signature to acceptallTransactionsCollection: OnyxCollection<Transaction>as a required parameterchangeTransactionsReportto pass the transactions collectionAddUnreportedExpenseFootercomponentVerification
The bug affects the delete option for unreported expenses on the Reports page (Search results).
Affected files:
src/pages/Search/SearchPage.tsx- Contains the dropdown options logic that checks if delete should be availablesrc/libs/ReportUtils.ts- ContainscanDeleteMoneyRequestReportfunction that validates delete permissionssrc/libs/actions/Transaction.ts- Changed by PR refactor: isolate ONYXKEYS.COLLECTION.TRANSACTION changeTransactionsReport #79328Confirmation of PR involvement:
The PR modifies how transactions are accessed in multiple places. While it updated call sites that explicitly call
changeTransactionsReport, the search results page logic for determining available actions (including delete) was not updated to account for the refactored data access pattern.In
SearchPage.tsxlines ~1001-1014, the code retrieves transactions from search results to check if they can be deleted. For unreported transactions (those without a report or withreportID === CONST.REPORT.UNREPORTED_REPORT_ID), theparentReportlookup may fail to find the necessary data after the refactor, causingcanDeleteMoneyRequestReportto return false even when delete should be allowed.Root Cause
The refactor changed how transaction data is accessed throughout the codebase from a centralized Onyx.connect subscription to explicit parameter passing. While direct call sites were updated, indirect code paths that rely on transaction data being available in search results were not fully accounted for. The delete option visibility check in SearchPage expects unreported transactions to be properly accessible, but after the refactor this data access pattern may be broken for the unreported expense case.
The issue is reproducible only on staging (not production) and only affects Reports page, confirming this PR (which is only on staging) is the cause.
1 remaining item
Guccio163 commentedon Jan 15, 2026
Looks like the bug was introduced in this commit merging this PR, it doesn't occur one commit earlier on main, should be worth checking out 👀
[-]Reports - Delete option is missing for unreported expenses on Reports[/-][+][$250] Reports - Delete option is missing for unreported expenses on Reports[/+]melvin-bot commentedon Jan 15, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022011769383385920319
melvin-bot commentedon Jan 15, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (
External)IuliiaHerets commentedon Jan 15, 2026
Windows 10/ Chrome
v9.3.2-1
Not Repro
Repro.-.issue.79618.mp4
[-][$250] Reports - Delete option is missing for unreported expenses on Reports[/-][+][Due for payment 2026-01-23] [$250] Reports - Delete option is missing for unreported expenses on Reports[/+]