You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-02-19] [$250] Report - "Waiting for you to add expenses" in empty report is not translated #79619
Version Number: v9.3.2-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#75261 Email or phone of affected tester (no customers): Any new account Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Macbook Pro 2023 / Sequoia 15.2 App Component: Chat Report View
Please re-state the problem that we are trying to solve in this issue.
"Waiting for you to add expenses" message in empty reports is not translated when device is set to Spanish (or any non-English language).
What is the root cause of that problem?
There are two next step systems in the codebase:
New system (ReportNextStep with messageKey) - uses translation keys like CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONS that get translated via buildNextStepMessage() with translate()
Deprecated system (ReportNextStepDeprecated with message array) - builds hardcoded English strings directly in buildNextStepNew() at src/libs/NextStepUtils.ts
The MoneyReportHeaderStatusBar component receives the deprecated format from Onyx (ONYXKEYS.COLLECTION.NEXT_STEP) and uses parseMessage() which just renders the English text as-is - no translation happens.
Then update callers to pass both formats during migration.
What alternative solutions did you explore? (Optional)
Could modify buildNextStepNew() to use translate() directly when building message arrays, but that would require passing translate through many call sites. Using the new messageKey system is the intended migration path.
Please re-state the problem that we are trying to solve in this issue.
"Waiting for you to add expenses" in empty reports is not translated when device language is set to Spanish/other languages.
What is the root cause of that problem?
MoneyReportHeader reads from deprecated ONYXKEYS.COLLECTION.NEXT_STEP which contains hardcoded English strings built by buildNextStepNew() in src/libs/NextStepUtils.ts:
message: [{text: 'Waiting for '},// hardcoded{text: `${ownerDisplayName}`,type: 'strong'},{text: ' to '},{text: isReportContainingTransactions ? 'submit' : 'add'},{text: ' %expenses.'},],
A new translation-aware system already exists:
buildOptimisticNextStep() generates Report.nextStep with messageKey for translations
buildNextStepMessage() translates using translate()
Translations exist in all language files (es.ts has them at lines 1263-1272)
The new format is stored on Report.nextStep but the UI never reads it.
What changes do you think we should make in order to solve the problem?
Update MoneyReportHeaderStatusBar.tsx to use the new translatable format:
Add nextStepNew prop for the new Report.nextStep format
In the messageContent useMemo, check for nextStepNew?.messageKey first and use buildNextStepMessage() with translate()
Fall back to deprecated format if new one isn't available
What alternative solutions did you explore? (Optional)
Could modify buildNextStepNew() to accept a translate function, but that would require threading it through many call sites. The new messageKey system already exists for exactly this purpose - just need to wire it up.
changed the title [-]Report - "Waiting for you to add expenses" in empty report is not translated[/-][+][$250] Report - "Waiting for you to add expenses" in empty report is not translated[/+]on Jan 15, 2026
⚠️@yatin-italy Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
changed the title [-][$250] Report - "Waiting for you to add expenses" in empty report is not translated[/-][+][Due for payment 2026-02-19] [$250] Report - "Waiting for you to add expenses" in empty report is not translated[/+]on Feb 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.17-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@aimane-chnaif@brianlee-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: The localization wasn't originally supported for this next step message.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Jan 14, 2026
Triggered auto assignment to @brianlee-expensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MobileMage commentedon Jan 14, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Waiting for you to add expenses" message in empty reports is not translated when device is set to Spanish (or any non-English language).
What is the root cause of that problem?
There are two next step systems in the codebase:
New system (
ReportNextStepwithmessageKey) - uses translation keys likeCONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONSthat get translated viabuildNextStepMessage()withtranslate()Deprecated system (
ReportNextStepDeprecatedwithmessagearray) - builds hardcoded English strings directly inbuildNextStepNew()atsrc/libs/NextStepUtils.tsThe
MoneyReportHeaderStatusBarcomponent receives the deprecated format from Onyx (ONYXKEYS.COLLECTION.NEXT_STEP) and usesparseMessage()which just renders the English text as-is - no translation happens.Looking at
buildNextStepNew()lines 507-529:What changes do you think we should make in order to solve the problem?
Modify
MoneyReportHeaderStatusBarto use the new translation system:nextStep(deprecated) andnextStepNew(new format with messageKey) propsnextStepNewis available, usebuildNextStepMessage()withtranslate()to get translated textparseMessage()for deprecated formatIn
src/components/MoneyReportHeaderStatusBar.tsx:Then update callers to pass both formats during migration.
What alternative solutions did you explore? (Optional)
Could modify
buildNextStepNew()to usetranslate()directly when building message arrays, but that would require passingtranslatethrough many call sites. Using the newmessageKeysystem is the intended migration path.duckemiah commentedon Jan 14, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Waiting for you to add expenses" in empty reports is not translated when device language is set to Spanish/other languages.
What is the root cause of that problem?
MoneyReportHeaderreads from deprecatedONYXKEYS.COLLECTION.NEXT_STEPwhich contains hardcoded English strings built bybuildNextStepNew()insrc/libs/NextStepUtils.ts:A new translation-aware system already exists:
buildOptimisticNextStep()generatesReport.nextStepwithmessageKeyfor translationsbuildNextStepMessage()translates usingtranslate()The new format is stored on
Report.nextStepbut the UI never reads it.What changes do you think we should make in order to solve the problem?
Update
MoneyReportHeaderStatusBar.tsxto use the new translatable format:nextStepNewprop for the newReport.nextStepformatmessageContentuseMemo, check fornextStepNew?.messageKeyfirst and usebuildNextStepMessage()withtranslate()In
MoneyReportHeader.tsx, pass the new format:What alternative solutions did you explore? (Optional)
Could modify
buildNextStepNew()to accept a translate function, but that would require threading it through many call sites. The newmessageKeysystem already exists for exactly this purpose - just need to wire it up.[-]Report - "Waiting for you to add expenses" in empty report is not translated[/-][+][$250] Report - "Waiting for you to add expenses" in empty report is not translated[/+]melvin-bot commentedon Jan 15, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022011593758031610412
melvin-bot commentedon Jan 15, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (
External)yatin-italy commentedon Jan 15, 2026
🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.
github-actions commentedon Jan 15, 2026
abdul-samad-91 commentedon Jan 15, 2026
🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.
21 remaining items
[-][$250] Report - "Waiting for you to add expenses" in empty report is not translated[/-][+][Due for payment 2026-02-19] [$250] Report - "Waiting for you to add expenses" in empty report is not translated[/+]melvin-bot commentedon Feb 12, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.17-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-02-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 12, 2026
@aimane-chnaif @brianlee-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
brianlee-expensify commentedon Feb 14, 2026
@aimane-chnaif can you fill out the bugzero checklist and confirm whether a regression test is needed? thanks in advance!
aimane-chnaif commentedon Feb 15, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: The localization wasn't originally supported for this next step message.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/601202
Regression Test Proposal
Precondition:
Users device is set to other language
Test:
Do we agree 👍 or 👎
brianlee-expensify commentedon Feb 19, 2026
Payment Summary
Contributor: @MobileMage paid $250 via Upwork
Contributor+: @aimane-chnaif paid $250 via Upwork