You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-23] Expense - Delete modal indicates multiple reports when deleting a report from More menu #79623
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #75261 - "Can't select an empty report from the Reports > Reports page" by @lorretheboy (High confidence) Related Issues: None
Recommendation: REVERT
The PR introduced a bug in MoneyReportHeader.tsx where the delete confirmation modal incorrectly uses the number of transactions instead of the number of reports when determining pluralization.
PR modifications confirmed:
The PR diff shows changes to MoneyReportHeader.tsx that added {count: transactionCount} parameter to the translation calls.
Root Cause
In MoneyReportHeader.tsx at lines 1404-1405, the delete confirmation modal uses:
The issue is that transactionCount represents the number of transactions/expenses in the report, not the number of reports being deleted. When deleting a single report via the More menu, the code should pass count: 1 because only ONE report is being deleted, regardless of how many transactions are in it.
Example scenario from the bug report:
User creates a report with 2 expenses
User clicks More > Delete
transactionCount = 2 (because there are 2 expenses)
Modal shows "Delete reports" and "Are you sure that you want to delete these reports?" (plural)
Expected: "Delete report" and "Are you sure that you want to delete this report?" (singular)
The fix should change transactionCount to 1 on these lines, since when deleting from the More menu, you're always deleting exactly one report.
changed the title [-]Expense - Delete modal indicates multiple reports when deleting a report from More menu[/-][+][Due for payment 2026-01-23] Expense - Delete modal indicates multiple reports when deleting a report from More menu[/+]on Jan 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.3-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins@stephanieelliott The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Jan 15, 2026
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 15, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #75261
melvin-bot commentedon Jan 15, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 15, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 15, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #75261 - "Can't select an empty report from the Reports > Reports page" by @lorretheboy (High confidence)
Related Issues: None
Recommendation: REVERT
The PR introduced a bug in MoneyReportHeader.tsx where the delete confirmation modal incorrectly uses the number of transactions instead of the number of reports when determining pluralization.
Labels: Keeping
DeployBlockerCash(App deploy blocked). RemovingDeployBlocker(not a backend issue).📋 Detailed Analysis
Evidence
Verification
I verified that PR #75261 modified
src/components/MoneyReportHeader.tsxand introduced the problematic code at lines 1404-1405.Files affected by the bug:
/home/runner/work/App/App/src/components/MoneyReportHeader.tsx(lines 1404-1405)PR modifications confirmed:
The PR diff shows changes to MoneyReportHeader.tsx that added
{count: transactionCount}parameter to the translation calls.Root Cause
In MoneyReportHeader.tsx at lines 1404-1405, the delete confirmation modal uses:
The issue is that
transactionCountrepresents the number of transactions/expenses in the report, not the number of reports being deleted. When deleting a single report via the More menu, the code should passcount: 1because only ONE report is being deleted, regardless of how many transactions are in it.Example scenario from the bug report:
transactionCount = 2(because there are 2 expenses)The fix should change
transactionCountto1on these lines, since when deleting from the More menu, you're always deleting exactly one report.IuliiaHerets commentedon Jan 15, 2026
This issue is not reproduced anymore in the latest build
Screen.Recording.2026-01-15.at.18.14.21.mp4
[-]Expense - Delete modal indicates multiple reports when deleting a report from More menu[/-][+][Due for payment 2026-01-23] Expense - Delete modal indicates multiple reports when deleting a report from More menu[/+]melvin-bot commentedon Jan 16, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.3-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-01-23. 🎊
melvin-bot commentedon Jan 16, 2026
@luacmartins @stephanieelliott The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]