Skip to content

[Due for payment 2026-01-23] Expense - Delete modal indicates multiple reports when deleting a report from More menu #79623

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.2-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #75261, https://test-management.browserstack.com/projects/2219752/folder/13176670/test-cases/41237092
Email or phone of affected tester (no customers): sidnjodsjdoijndsojsio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two expenses.
  4. Open the expense report.
  5. Click More > Delete.

Expected Result:

Delete modal will show "Delete report" with "Are you sure that you want to delete this report?".

Actual Result:

Delete modal shows "Delete reports" with "Are you sure that you want to delete these reports?".

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Image
Bug7049540_1768436362453.9.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @stephanieelliott

Activity

  1. added
    DeployDeferredDo not use - this label signifies that PR will be deployed later
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jan 15, 2026
  2. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. added
    DeployBlockerCashThis issue or pull request should block deployment
    and removed
    DeployDeferredDo not use - this label signifies that PR will be deployed later
    on Jan 15, 2026
  4. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #75261

  5. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Jan 15, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. OSBotify commented on Jan 15, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #75261 - "Can't select an empty report from the Reports > Reports page" by @lorretheboy (High confidence)
    Related Issues: None

    Recommendation: REVERT

    The PR introduced a bug in MoneyReportHeader.tsx where the delete confirmation modal incorrectly uses the number of transactions instead of the number of reports when determining pluralization.

    Labels: Keeping DeployBlockerCash (App deploy blocked). Removing DeployBlocker (not a backend issue).

    📋 Detailed Analysis

    Evidence

    • The issue explicitly states it's reproducible on staging (9.3.2-0) but not production
    • PR Can't select an empty report from the Reports > Reports page #75261 was merged on 2026-01-14 and is included in the current staging deploy
    • melvin-bot automatically identified this PR as the cause
    • The bug affects the delete modal text when deleting a report from the More menu

    Verification

    I verified that PR #75261 modified src/components/MoneyReportHeader.tsx and introduced the problematic code at lines 1404-1405.

    Files affected by the bug:

    • /home/runner/work/App/App/src/components/MoneyReportHeader.tsx (lines 1404-1405)

    PR modifications confirmed:
    The PR diff shows changes to MoneyReportHeader.tsx that added {count: transactionCount} parameter to the translation calls.

    Root Cause

    In MoneyReportHeader.tsx at lines 1404-1405, the delete confirmation modal uses:

    title: translate('iou.deleteReport', {count: transactionCount}),
    prompt: translate('iou.deleteReportConfirmation', {count: transactionCount}),

    The issue is that transactionCount represents the number of transactions/expenses in the report, not the number of reports being deleted. When deleting a single report via the More menu, the code should pass count: 1 because only ONE report is being deleted, regardless of how many transactions are in it.

    Example scenario from the bug report:

    1. User creates a report with 2 expenses
    2. User clicks More > Delete
    3. transactionCount = 2 (because there are 2 expenses)
    4. Modal shows "Delete reports" and "Are you sure that you want to delete these reports?" (plural)
    5. Expected: "Delete report" and "Are you sure that you want to delete this report?" (singular)

    The fix should change transactionCount to 1 on these lines, since when deleting from the More menu, you're always deleting exactly one report.

  8. IuliiaHerets commented on Jan 15, 2026

    @IuliiaHerets

    This issue is not reproduced anymore in the latest build

    Screen.Recording.2026-01-15.at.18.14.21.mp4
  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 16, 2026
  10. changed the title [-]Expense - Delete modal indicates multiple reports when deleting a report from More menu[/-] [+][Due for payment 2026-01-23] Expense - Delete modal indicates multiple reports when deleting a report from More menu[/+] on Jan 16, 2026
  11. melvin-bot commented on Jan 16, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jan 16, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.3-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-23. 🎊

  13. melvin-bot commented on Jan 16, 2026

    @melvin-bot

    @luacmartins @stephanieelliott The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions