[HOLD for payment 2022-04-06] Enter/return doesn't work when the button has options - reported by @Tushu17

@Tushu17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to chat of a user who have a paypal account.
Select Actions -> Send money -> enter amount > Hit Next
Pick any user
Press Enter/Return or "Go" on mobile keyboard

Expected Result:

Pressing Enter/Return should send money like it does in the request money.

Actual Result:

Pressing Enter/Return Closes the Keyboard or does nothing

Workaround:

unknown

Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.41-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-rec.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644833714384489

View all open jobs on GitHub

@deetergp

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal
Addition of pressOnEnter in

App/src/components/ButtonWithDropdown.js

Lines 32 to 39 in d6e64b3

    
           <Button 
        
               success 
        
               onPress={props.onButtonPress} 
        
               text={props.buttonText} 
        
               isLoading={props.isLoading} 
        
               shouldRemoveRightBorderRadius 
        
               style={[styles.flex1]} 
        
           />

<Button
    success
    onPress={props.onButtonPress}
    text={props.buttonText}
    isLoading={props.isLoading}
    shouldRemoveRightBorderRadius
    style={[styles.flex1]}
+   pressOnEnter
/>

solves the issue.

Proposal

Proposing a solution as I reported this issue

We aren't passing pressOnEnter to the Button that we use in ButtonWithDropdown as we can see below -

App/src/components/ButtonWithDropdown.js

Lines 30 to 39 in d6e64b3

    
           const ButtonWithDropdown = props => ( 
        
               <View style={[styles.flexRow, styles.justifyContentBetween, styles.alignItemsCenter]}> 
        
                   <Button 
        
                       success 
        
                       onPress={props.onButtonPress} 
        
                       text={props.buttonText} 
        
                       isLoading={props.isLoading} 
        
                       shouldRemoveRightBorderRadius 
        
                       style={[styles.flex1]} 
        
                   />

So by passing pressOnEnter to the Button which is on line 32 we can fix it.

@jliexpensify

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@deetergp

@deetergp - should go to Upworks right? If so, I'll assign myself again and make a job.

Internal - https://www.upwork.com/ab/applicants/1499184622705242112/job-details
External - https://www.upwork.com/jobs/~0160e8df4df0728126

@kadiealexander

Adding @kadiealexander to help keep an eye on my GH's as I'll be OOO next week

@sobitneupane

📣 @sobitneupane You have been assigned to this job by @jliexpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@jliexpensify

@jliexpensify leaving you assigned, please make payment on this one on the 6th/7th, as I'll be away. Thanks! 🎉

@rushatgabhane

There's an iOS regression - if this isn't a big deal, I can arrange payment cc @rushatgabhane @NikkiWines

@jliexpensify

@jliexpensify could you please link the iOS regression. I'm not able to find it 😅

@rushatgabhane

@rushatgabhane - apologies: I used the wrong terminology here! I did see that iOS failed to deploy - #8206 - which is what I meant.

If that's not an issue, I'll pay!

Asking in Slack here: https://expensify.slack.com/archives/C01SKUP7QR0/p1649636370757839

Hoping to get an answer in the next 24 hours so I can issue payment.

Sorry for the delay - confirmed that it's all good to proceed with payment, and will do shortly.

@Tushu17

Paid @Tushu17 and @rushatgabhane . Just awaiting @sobitneupane to accept and will pay + close job.

@sobitneupane

Just awaiting @sobitneupane to accept and will pay + close job.

Accepted the offer.

Paid, and closed job in Upworks!

Navigation Menu

Repository navigation

[HOLD for payment 2022-04-06] Enter/return doesn't work when the button has options - reported by @Tushu17 #7964

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Proposal

20 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<Button
	success
	onPress={props.onButtonPress}
	text={props.buttonText}
	isLoading={props.isLoading}
	shouldRemoveRightBorderRadius
	style={[styles.flex1]}
	/>

	const ButtonWithDropdown = props => (
	<View style={[styles.flexRow, styles.justifyContentBetween, styles.alignItemsCenter]}>
	<Button
	success
	onPress={props.onButtonPress}
	text={props.buttonText}
	isLoading={props.isLoading}
	shouldRemoveRightBorderRadius
	style={[styles.flex1]}
	/>

[HOLD for payment 2022-04-06] Enter/return doesn't work when the button has options - reported by @Tushu17 #7964

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Activity

MelvinBot commented on Mar 2, 2022

sobitneupane commented on Mar 2, 2022

Tushu17 commented on Mar 2, 2022

Proposal

MelvinBot commented on Mar 2, 2022

jliexpensify commented on Mar 3, 2022

jliexpensify commented on Mar 3, 2022

20 remaining items

jliexpensify commented on Mar 11, 2022

MelvinBot commented on Mar 11, 2022

kadiealexander commented on Apr 4, 2022

jliexpensify commented on Apr 7, 2022

rushatgabhane commented on Apr 7, 2022

jliexpensify commented on Apr 8, 2022

jliexpensify commented on Apr 11, 2022

jliexpensify commented on Apr 11, 2022

jliexpensify commented on Apr 11, 2022

sobitneupane commented on Apr 12, 2022

jliexpensify commented on Apr 12, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions