Skip to content

[Due for payment 2026-01-27] Expense - Invited member cannot see Attendee field #79710

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.3-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #79050
Email or phone of affected tester (no customers): sdjsjdoisnjdoisjosdj22@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Preconditions:

  • Rules are enabled.
  • Enable Attendee tracking in Rules.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two expenses.
  4. Open the expense report.
  5. Mention User B and send it to the report.
  6. Click Invite to chat only.
  7. As User B, open the report.

Expected Result:

User B can see Attendee field.

Actual Result:

Attendee field is hidden from User B.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7050309_1768498935765.6.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @brianlee-expensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 15, 2026
  2. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #79050

  3. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    Triggered auto assignment to @brianlee-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Jan 15, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Jan 15, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #79050 - "feat: add ability to require attendees based on category selection (rework)" by @ikevin127 (High confidence)
    Related Issues: None identified

    Recommendation: REVERT

    PR #79050 introduced a regression where the Attendee field visibility is incorrectly tied to edit permissions. Users invited to "chat only" (not workspace members) cannot see the Attendee field because they lack edit permissions, even though they should be able to view it as read-only.

    Labels: No changes needed - DeployBlockerCash is correctly applied for this Frontend bug.

    📋 Detailed Analysis

    Evidence

    PR #79050 added the ability to require attendees based on category selection. The PR modified MoneyRequestView.tsx and added logic that ties the attendees field interactivity to the canEdit permission (line 1058: interactive={canEdit}).

    Verification

    The issue affects the attendees field in src/components/ReportActionItem/MoneyRequestView.tsx:

    • Lines 1041-1065: The attendees field uses interactive={canEdit} and shouldShowRightIcon={canEdit}
    • Line 324: canEdit is calculated based on whether the user is the expense creator, admin, or manager
    • When a user is invited to "chat only", they are not a workspace member, so canEdit = false
    • The MenuItemWithTopDescription component with interactive={false} makes the field appear disabled/hidden

    Root Cause

    The PR incorrectly assumed that attendee field visibility should be controlled by edit permissions. However, the expected behavior is:

    • Workspace members with edit rights: Can edit the attendee field
    • Invited chat-only users: Should see the attendee field as read-only, but cannot edit it

    The regression is that interactive={canEdit} prevents chat-only users from seeing the field at all, when they should see it in a non-interactive (read-only) state.

    Comparison

    In MoneyRequestConfirmationListFooter.tsx (lines 737-758), the attendees field correctly uses isReadOnly instead of canEdit, which is the pattern that should have been followed in MoneyRequestView.tsx.

  7. JS00001 commented on Jan 15, 2026

    @JS00001
    Contributor

    Going to CP a fix here to disable the feature: #79620

  8. ikevin127 commented on Jan 15, 2026

    @ikevin127
    Contributor

    🗒️ Noted for follow-up PR.

  9. 5 remaining items

  10. IuliiaHerets commented on Jan 16, 2026

    @IuliiaHerets

    Chrome / 9.3.3-2
    Not reproduce anymore by QA team

    Screen.Recording.2026-01-16.at.10.42.29.mp4
  11. JS00001 commented on Jan 16, 2026

    @JS00001
    Contributor

    CP'd a fix to hide this feature, closing. @ikevin127 Lets fix this in a follow up

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 20, 2026
  13. changed the title [-]Expense - Invited member cannot see Attendee field[/-] [+][Due for payment 2026-01-27] Expense - Invited member cannot see Attendee field[/+] on Jan 20, 2026
  14. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.4-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-27. 🎊

  16. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    @JS00001 @brianlee-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions