Skip to content

[Due for payment 2026-02-17] Reports - RHP closes and reopens after adding a new expense. #79712

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.3.0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77657
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Search

Action Performed:

Prerequisite: Account has at least one workspace.

  1. Open the staging.new.expensify.com website.
  2. Open any workspace chat,
  3. Create a manual expense.
  4. Navigate to "Reports" > "Expenses"
  5. Open the just created expense.
  6. Tap on "More" > "Add Expense" > "Create Expense"
  7. Create a new manual expense.
  8. Note that when expense is created, RHP closes and reopens.

Expected Result:

When an expense is added to report, RHP should remain opened and new expense should appear automatically.

Actual Result:

When an expense is added to report, RHP closes and reopens automatically.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7050328_1768499514794.Wide.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @WojtekBoman

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 15, 2026
  2. github-actions commented on Jan 15, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. OSBotify commented on Jan 15, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #75886 - "Add Super Wide RHP Routes" by @WojtekBoman (High confidence)
    Related Issues: None identified

    Recommendation: REVERT

    PR #75886 introduced a regression in the dismissModalAndOpenReportInInboxTab function that causes the RHP to close and reopen when adding an expense to a report opened in the Super Wide RHP. The intended behavior should be for the RHP to remain open with the new expense appearing automatically. Reverting this PR will restore the expected behavior.

    Labels: Keeping DeployBlockerCash (App deploy blocked). Removing DeployBlocker if present (not a backend issue).

    Detailed Analysis

    Evidence

    The bug occurs when:

    1. User opens an expense report in the Super Wide RHP (Reports > Expenses > click report with multiple expenses)
    2. User clicks "More" > "Add Expense" > "Create Expense"
    3. User creates a new manual expense
    4. The RHP closes and reopens instead of staying open

    This behavior is directly caused by changes in PR #75886 to the dismissModalAndOpenReportInInboxTab function in src/libs/actions/IOU/index.ts.

    Verification

    Affected file: src/libs/actions/IOU/index.ts (lines 989-1017)

    PR #75886 modified this file: Confirmed via gh pr view 75886 --json files

    Specific problematic code (added in PR #75886, lines 995-999):

    // When a report is opened in the super wide RHP, we need to dismiss to the first RHP to show the same report with new expense.
    if (isReportOpenInSuperWideRHP(rootState)) {
        Navigation.dismissToPreviousRHP();
        return;
    }

    This code dismisses the RHP when an expense is added, causing the close/reopen behavior that users are experiencing.

    Root Cause

    The dismissModalAndOpenReportInInboxTab function is called after creating an expense. PR #75886 added logic to handle the Super Wide RHP case by calling Navigation.dismissToPreviousRHP(), which dismisses and reopens the RHP.

    The comment suggests this was intentional ("to show the same report with new expense"), but this creates a poor UX where the panel visibly closes and reopens. The expected behavior, as stated in the issue, is for the RHP to remain open and the new expense to appear automatically without any dismissal.

    Timeline alignment:

    This confirms PR #75886 is the root cause.

  4. OSBotify commented on Jan 15, 2026

    @OSBotify
    Contributor

    Labels are already correct - DeployBlockerCash is present (blocking App deploy) and DeployBlocker is not present. No label changes needed.

  5. francoisl commented on Jan 15, 2026

    @francoisl
    Contributor

    cc @mountiny @ZhenjaHorbach this also looks related to the RHP changes

  6. ZhenjaHorbach commented on Jan 15, 2026

    @ZhenjaHorbach
    Contributor

    cc @mountiny @ZhenjaHorbach this also looks related to the RHP changes

    Yeah
    But I think it's not a deploy blocker
    Minor visual issue

  7. francoisl commented on Jan 15, 2026

    @francoisl
    Contributor

    Demoting as non-critical issue

  8. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 15, 2026
  9. 31 remaining items

  10. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.15-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-02-17. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. melvin-bot commented on Feb 20, 2026

    @melvin-bot

    @mountiny, @ZhenjaHorbach, @collectioneur Whoops! This issue is 2 days overdue. Let's get this updated quick!

  13. mountiny commented on Feb 20, 2026

    @mountiny
    Contributor

    I believe this was a follow up so we can close now

  14. moved this from MEDIUM or LOW to Done in [#whatsnext] #migrateon Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions