Skip to content

Attendee - Multiple attendee violation only applicable for the owner of the WS #79721

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.3.3-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #79050
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 11 pro /Chrome
App Component: Money Requests

Action Performed:

Preconditions:
Rules are enabled.
Enable Attendee tracking in Rules.

  1. Navigate to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create expenses with Equipment category and change the WS attendee to other user (remove WS owner)
  4. Go to Workspace Settings > Categories.
  5. Open Equipment settings.
  6. Click Require fields.
  7. Enable Require attendees.
  8. Navigate straight to Reports > Expenses without opening the report first.

Expected Result:

"Multiple attendees required for this category" violation is shown on the expense row.

Actual Result:

"Multiple attendees required for this category" violation is not shown on the expense row if the attendee is other than yourself

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @JS00001

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 15, 2026
  2. github-actions commented on Jan 15, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #79050

  5. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. OSBotify commented on Jan 15, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #79050 - feat: add ability to require attendees based on category selection (rework) by @ikevin127 (High confidence)

    Recommendation: REVERT

    PR #79050 introduced a bug in the attendee violation logic for the Reports > Expenses view. The violation check uses the current logged-in user's details instead of the expense creator's details, causing incorrect validation when viewing expenses created by other users.

    Labels: Will KEEP DeployBlockerCash (App PR caused the issue). DeployBlocker label is not present on this issue.

    Evidence

    The bug reproduces when:

    1. A user (not the workspace owner) creates an expense
    2. They select a category requiring attendees but only add one attendee (not themselves)
    3. The workspace owner views Reports > Expenses
    4. Expected: Multiple attendees required for this category violation shows
    5. Actual: No violation shows

    This matches the issue description: Multiple attendee violation only applicable for the owner of the WS

    Root Cause

    The violation logic in src/libs/AttendeeUtils.ts checks if there are attendees besides the expense creator. However, the code in src/components/SelectionListWithSections/Search/TransactionListItem.tsx line 164 passes the current viewers details instead of the creators details.

    Affected file: src/components/SelectionListWithSections/Search/TransactionListItem.tsx line 164
    Fix needed: Pass transactionItem.from instead of currentUserDetails to syncMissingAttendeesViolation

  7. ikevin127 commented on Jan 15, 2026

    @ikevin127
    Contributor

    Going to CP a fix here to disable the feature: #79620

    @JS00001 This should be fixed by the ☝️ CP.
    🗒️ Noted for follow-up PR.

  8. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 16, 2026
  9. ikevin127 commented on Jan 16, 2026

    @ikevin127
    Contributor
    1. Create expenses with Equipment category and change the WS attendee to other user (remove WS owner)

    "Multiple attendees required for this category" violation is not shown on the expense row if the attendee is other than yourself

    This one can be closed as a non-issue because ☝️ that's how the feature is expected to work based on issue OP:

    Require attendees logic

    We'll flag an Attendees violation on an expense when either of the following is true:

    • The attendees array is empty, or
    • The length of the attendees array minus the expense creator is zero. // 👈 THIS

    @JS00001 Should be closed as NAB.

  10. IuliiaHerets commented on Jan 16, 2026

    @IuliiaHerets

    Unable to repro on Windows 11 / Chrome in v9.3.3-2
    No Attendees in required fields, only Description

    bandicam.2026-01-16.15-53-40-933.mp4
  11. JS00001 commented on Jan 16, 2026

    @JS00001
    Contributor

    CP'd a fix to hide this feature, closing. @ikevin127 Lets fix this in a follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions