You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Expense - No violation when editing an existing receipt expense to a zero amount #79722
Version Number: v9.3.3-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#79197 Email or phone of affected tester (no customers):applausetester+im_1501.3@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Mac 15.4.1 Safari, Chrome App Component: Money Requests
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This PR introduced changes to allow zero-amount expenses behind the zero_expenses beta flag. However, it inadvertently broke the modifiedAmount violation that should appear when editing a receipt expense to zero if the smartscanned amount was different.
The PR author explicitly stated in the test steps that the smartscan difference violation should still appear:
"Confirm you can edit an existing receipt expense to set the amount to zero. No violation should show (beyond the amount being different to the smartscanned amount when relevant)."
Labels: Keeping DeployBlockerCash (App deploy is blocked). This is a frontend bug in the App repository.
Detailed Analysis
Evidence
PR #79197 changed the type of modifiedAmount from number (with 0 as default) to string (with ' as empty). The new hasValidModifiedAmount() function treats modifiedAmount = '0' (zero as string) as a valid modification.
However, the backend-generated modifiedAmount violation is not appearing when a receipt expense is edited to zero, even though the smartscanned amount was different. This suggests the app is not properly signaling to the backend that the amount was modified, or the zero-amount logic is interfering with violation generation.
The bug is reproducible on staging: Confirmed in the issue report
The feature is behind a beta flag: CONST.BETAS.ZERO_EXPENSES - affects users in the beta
PR merge timeline: Merged on 2026-01-15, aligns with when bug appeared
Root Cause
The changes in how modifiedAmount is handled (number vs string, and how zero values are interpreted) are interfering with the backend's ability to detect that an amount was modified from the smartscanned value. The modifiedAmount violation is a backend-generated violation that should appear when the user changes the amount away from what was smartscanned, but the app's new zero-amount handling is likely preventing this signal from being sent correctly to the backend.
Key code changes in the PR:
modifiedAmount changed from number to string type
hasValidModifiedAmount() function treats '0' as valid, which may be causing issues with violation detection
Multiple places now use Number(transaction.modifiedAmount) conversions
changed the title [-]Expense - No violation when editing an existing receipt expense to a zero amount[/-][+][$250] Expense - No violation when editing an existing receipt expense to a zero amount[/+]on Jan 19, 2026
Activity
melvin-bot commentedon Jan 15, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #79197
melvin-bot commentedon Jan 15, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Jan 15, 2026
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jan 15, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 15, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #79197 - "[BETA] Allow zero-amount expenses - ROUND 5" by @Gonals (High confidence)
Related Issues: None
Recommendation: REVERT
This PR introduced changes to allow zero-amount expenses behind the
zero_expensesbeta flag. However, it inadvertently broke themodifiedAmountviolation that should appear when editing a receipt expense to zero if the smartscanned amount was different.The PR author explicitly stated in the test steps that the smartscan difference violation should still appear:
Labels: Keeping
DeployBlockerCash(App deploy is blocked). This is a frontend bug in the App repository.Detailed Analysis
Evidence
PR #79197 changed the type of
modifiedAmountfromnumber(with0as default) tostring(with'as empty). The newhasValidModifiedAmount()function treatsmodifiedAmount = '0'(zero as string) as a valid modification.However, the backend-generated
modifiedAmountviolation is not appearing when a receipt expense is edited to zero, even though the smartscanned amount was different. This suggests the app is not properly signaling to the backend that the amount was modified, or the zero-amount logic is interfering with violation generation.Verification
modifiedAmounttype from number to string across multiple filesCONST.BETAS.ZERO_EXPENSES- affects users in the betaRoot Cause
The changes in how
modifiedAmountis handled (number vs string, and how zero values are interpreted) are interfering with the backend's ability to detect that an amount was modified from the smartscanned value. ThemodifiedAmountviolation is a backend-generated violation that should appear when the user changes the amount away from what was smartscanned, but the app's new zero-amount handling is likely preventing this signal from being sent correctly to the backend.Key code changes in the PR:
modifiedAmountchanged fromnumbertostringtypehasValidModifiedAmount()function treats'0'as valid, which may be causing issues with violation detectionNumber(transaction.modifiedAmount)conversionsValforte commentedon Jan 15, 2026
Under a beta, we can remove it as a deploy blocker
1 remaining item
[-]Expense - No violation when editing an existing receipt expense to a zero amount[/-][+][$250] Expense - No violation when editing an existing receipt expense to a zero amount[/+]melvin-bot commentedon Jan 19, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022013064919522501250
melvin-bot commentedon Jan 19, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (
External)melvin-bot commentedon Jan 26, 2026
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
Gonals commentedon Jan 28, 2026
I think this is fixed