Skip to content

Split in group - Fields lead to "Not here", Split button is presented in a scan split #79742

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.3-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176944/test-cases/41237730
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: MacBook Air 15.7.3 Chrome, iPhone 15 iOS 26.1
App Component: Money Requests

Action Performed:

  1. Sign in to ND
  2. Create a group chat with two other existing accounts, send a message in the chat
  3. Split a scan expense in the group chat, uploading a valid receipt
  4. When the scan is finished, open the split details
  5. Click on the fields like amount, merchant, etc
  6. Click "Split" button

Expected Result:

Split button is not displayed in the split details, fields are not editable

Actual Result:

Fields in the slit can be opened and lead to "Not here" RHP. Split button is shown, pressing it leads to unexpected error.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 16, 2026
  2. melvin-bot commented on Jan 16, 2026

    @melvin-bot

    Triggered auto assignment to @brianlee-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 16, 2026

    @melvin-bot

    Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jan 16, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 16, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Jan 16, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #79197 - "[BETA] Allow zero-amount expenses - ROUND 5" by @Gonals (High confidence)
    Related Issues: None

    Recommendation: REVERT

    PR #79197 should be reverted as it introduces a bug that makes split expense fields incorrectly editable after scanning completes.

    Labels: Keeping DeployBlockerCash (Frontend/App bug that requires an App PR fix)

    Detailed Analysis

    Evidence

    PR #79197 was merged on 2026-01-15 13:30:11Z to add support for zero-amount expenses. However, it modified the logic in src/pages/iou/SplitBillDetailsPage.tsx on line 75:

    Before:

    const isEditingSplitBill = session?.accountID === actorAccountID && areRequiredFieldsEmpty(transaction) && !isDistanceRequest;

    After:

    const isEditingSplitBill = session?.accountID === actorAccountID && (areRequiredFieldsEmpty(transaction) || transaction?.amount === 0) && !isDistanceRequest;

    This change makes split expenses with zero amount editable. However, the condition transaction?.amount === 0 is also temporarily true when a receipt is still being scanned (before SmartScan completes). When SmartScan finishes and populates the amount, the fields should become read-only, but the code now incorrectly allows editing.

    Verification

    Root Cause

    The condition transaction?.amount === 0 was added to allow editing zero-amount expenses (the feature PR #79197 implements). However, scanned expenses also have amount === 0 during scanning. After SmartScan completes and populates merchant/amount, the split should become read-only, but the new logic incorrectly treats it as editable because it checks both areRequiredFieldsEmpty() OR amount === 0.

    The correct logic should only check areRequiredFieldsEmpty() for split bills, or add additional checks to exclude completed scans from being editable.

  7. AndrewGable commented on Jan 16, 2026

    @AndrewGable
    Contributor

    cc @Gonals - But I think we can keep this because it sounds like it's behind a beta

  8. francoisl commented on Jan 16, 2026

    @francoisl
    Contributor

    I can reproduce on an account that's not on the beta. The PR has conflicts when reverting, I wonder if we can add the particular part of the code causing the issue behind the beta too, instead.

  9. AndrewGable commented on Jan 16, 2026

    @AndrewGable
    Contributor

    I can reproduce on an account that's not on the beta.

    Ok so seems like a real blocker then

  10. francoisl commented on Jan 16, 2026

    @francoisl
    Contributor

    Testing a potential fix in #79797

  11. AndrewGable commented on Jan 16, 2026

    @AndrewGable
    Contributor

    Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions