[Due for payment 2026-04-23] [$250] Report - Formula report field initial value {report:i} is not persisted & resets to {report:id}

@mallenexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: V9.3.4-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-3028/folder/13176707/41236876/1131712084
Email or phone of affected tester (no customers): dreamnitethedragon+yydyd373@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redminote 10S Android 13
App Component: Workspace Settings

Action Performed:

Pre-condition: report field is enabled

Launch app
Go to workspace settings
Tapping add field
Select type - formula
Tap initial value and change it to {report:i} and save
Enter a name and save
Created report field is not shown in list
Tap add field
Enter a name, select type formula and save
Tap the report field created
Tap initial value and change it to {report:i} and save
Note reverts to original as {report:id}

Expected Result:

User should not be allowed to save an unsupported formula value OR
App should show a clear validation error for {report:i}.
If saved, the formula report field should:

Appear in the fields list
Retain {report:i} when reopened or edited

Actual Result:

App allows saving {report:i} without any validation.
The created report field does not appear in the fields list.
When editing the report field, {report:i} automatically reverts back to {report:id} without user action or warning.

Workaround:

Unknown

Platforms:

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~022013597456074804416
Upwork Job ID: 2013597456074804416
Last Price Increase: 2026-02-10
Automatic offers:

linhvovan29546 | Contributor | 110521220

Issue Owner

Current Issue Owner: @mallenexpensify

@dylanexpensify

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

User should not be allowed to save an unsupported formula value OR
App should show a clear validation error for {report:i}.
If saved, the formula report field should:

Appear in the fields list
Retain {report:i} when reopened or edited

What is the root cause of that problem?

The UI does not validate formula placeholders/tokens in the “Initial value” input. So unsupported tokens like {report:i} get submitted. The backend then normalizes/rejects/ignores unsupported formula parts (e.g., reverting to a supported default like {report:id}), leading to inconsistent UI state (missing field / unexpected value changes) without any user-facing error.

What changes do you think we should make in order to solve the problem?

Add client-side validation for report-field formulas that rejects unsupported {report:*} tokens (including {report:i}) and shows a clear inline validation error, preventing save.
Apply this validation in both places users can set the initial value:
- Create report field flow
- Edit initial value flow

Add a dedicated translation string for the validation message so the UI clearly communicates what’s wrong and suggests a supported token (e.g., {report:id}).

App/src/pages/workspace/reports/ReportFieldsInitialValuePage.tsx

Lines 63 to 70 in eafbcff

    
           const validateForm = useCallback( 
        
               (values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM>): FormInputErrors<typeof ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM> => { 
        
                   const {initialValue: formInitialValue} = values; 
        
                   const errors: FormInputErrors<typeof ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM> = {}; 
        
                   if (formInitialValue.length > CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH) { 
        
                       errors[INPUT_IDS.INITIAL_VALUE] = translate('common.error.characterLimitExceedCounter', formInitialValue.length, CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH); 
        
                   }

const validateForm = useCallback(
        (values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM>): FormInputErrors<typeof ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM> => {
            const {initialValue: formInitialValue} = values;
            const errors: FormInputErrors<typeof ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM> = {};

            if (formInitialValue.length > CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH) {
                errors[INPUT_IDS.INITIAL_VALUE] = translate('common.error.characterLimitExceedCounter', formInitialValue.length, CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH);
            }

            if (
                (reportField?.type === CONST.REPORT_FIELD_TYPES.TEXT || reportField?.type === CONST.REPORT_FIELD_TYPES.FORMULA) &&
                !!formInitialValue &&
                !errors[INPUT_IDS.INITIAL_VALUE]
            ) {
                const unsupportedFormulaParts = getUnsupportedReportFieldFormulaParts(formInitialValue);
                if (unsupportedFormulaParts.length > 0) {
                    errors[INPUT_IDS.INITIAL_VALUE] = translate('workspace.reportFields.unsupportedFormulaValueError', {value: unsupportedFormulaParts.join(', ')});
                }
            }

App/src/pages/workspace/reports/CreateReportFieldsPage.tsx

Lines 102 to 104 in eafbcff

    
           if (type === CONST.REPORT_FIELD_TYPES.TEXT && !!formInitialValue && formInitialValue.length > CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH) { 
        
               errors[INPUT_IDS.INITIAL_VALUE] = translate('common.error.characterLimitExceedCounter', formInitialValue.length, CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH); 
        
           }


if (type === CONST.REPORT_FIELD_TYPES.TEXT && !!formInitialValue && formInitialValue.length > CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH) {
                errors[INPUT_IDS.INITIAL_VALUE] = translate('common.error.characterLimitExceedCounter', formInitialValue.length, CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH);
            }

            if ((type === CONST.REPORT_FIELD_TYPES.TEXT || type === CONST.REPORT_FIELD_TYPES.FORMULA) && !!formInitialValue && !errors[INPUT_IDS.INITIAL_VALUE]) {
                const unsupportedFormulaParts = getUnsupportedReportFieldFormulaParts(formInitialValue);
                if (unsupportedFormulaParts.length > 0) {
                    errors[INPUT_IDS.INITIAL_VALUE] = translate('workspace.reportFields.unsupportedFormulaValueError', {value: unsupportedFormulaParts.join(', ')});
                }
            }

We should add this code to WorkspaceReportFieldUtils

type FormulaParsePart = {
    definition: string;
    type: string;
    fieldPath: string[];
    functions: string[];
};
function getUnsupportedReportFieldFormulaParts(initialValue?: string): string[] {
    if (!initialValue || typeof initialValue !== 'string') {
        return [];
    }

    // Dynamically require to avoid circular dependency with ReportActionsUtils
    const {parse, FORMULA_PART_TYPES} = require('./Formula') as {
        parse: (formula?: string) => FormulaParsePart[];
        FORMULA_PART_TYPES: {REPORT: string};
    };

    const supportedReportFields = new Set([
        'id',
        'status',
        'expensescount',
        'type',
        'startdate',
        'enddate',
        'total',
        'reimbursable',
        'currency',
        'policyname',
        'workspacename',
        'created',
        'submit',
        'autoreporting',
    ]);

    const supportedSubmitDirections = new Set(['from', 'to', 'date']);
    const supportedSubmitPersonFields = new Set(['firstname', 'lastname', 'fullname', 'email', 'userid', 'customfield1', 'payrollid', 'customfield2']);
    const supportedAutoReportingFields = new Set(['start', 'end']);

    const unsupported: string[] = [];
    const parts = parse(initialValue);

    for (const part of parts) {
        if (part.type !== FORMULA_PART_TYPES.REPORT) {
            continue;
        }

        const [field, ...rest] = part.fieldPath ?? [];
        const normalizedField = field?.trim().toLowerCase();

        if (!normalizedField || !supportedReportFields.has(normalizedField)) {
            unsupported.push(part.definition);
            continue;
        }

        if (normalizedField === 'submit') {
            const direction = rest.at(0)?.trim().toLowerCase();
            if (!direction || !supportedSubmitDirections.has(direction)) {
                unsupported.push(part.definition);
                continue;
            }

            // report:submit:date is valid (format is optional and validated elsewhere)
            if (direction === 'date') {
                continue;
            }

            // report:submit:from:* and report:submit:to:* need a subfield
            const submitField = rest.at(1)?.trim().toLowerCase();
            if (!submitField || !supportedSubmitPersonFields.has(submitField)) {
                unsupported.push(part.definition);
            }
            continue;
        }

        if (normalizedField === 'autoreporting') {
            const subField = rest.at(0)?.trim().toLowerCase();
            if (!subField || !supportedAutoReportingFields.has(subField)) {
                unsupported.push(part.definition);
            }
        }
    }

    return unsupported;
}

And we should add language params:
type UnsupportedFormulaValueErrorParams = {value: string};

What alternative solutions did you explore? (Optional)

We add all locales (de, fr, it, ja, nl, pl, pt-BR, zh-hans, es)

Proposal

Please re-state the problem that we are trying to solve in this issue.

When creating or editing a formula report field, users can enter unsupported placeholders like {report:i} without any validation. This causes:

Created fields don't appear in the fields list
Invalid values silently revert to {report:id} without warning
No error message shown to users

What is the root cause of that problem?

The root cause is missing client-side validation for formula field placeholders. The app doesn't validate whether a formula uses supported placeholders (like {report:id}) or unsupported ones (like {report:i}) before attempting to save, leading to:

No validation error shown to users for invalid formulas
Server-side auto-correction that silently changes values without user feedback
Fields not appearing in the list when invalid formulas are saved

What changes do you think we should make in order to solve the problem?

Add client-side validation to check formula placeholders before saving. The solution includes:

1. Formula Validation Function (`App/src/libs/Formula.ts`)

Added getSupportedReportFields() function that returns a list of all supported report field placeholders: id, status, expensescount, type, startdate, enddate, total, reimbursable, currency, policyname, workspacename, created, submit, autoreporting
Added validateFormula() function that parses the formula and checks if all placeholders are in the supported list
Returns an object with isValid boolean and unsupportedPlaceholders array
Exports both functions for use in other components

2. Edit Page Validation (`App/src/pages/workspace/reports/ReportFieldsInitialValuePage.tsx`)

Imported validateFormula from Formula.ts
Added validation check in the validateForm callback for FORMULA type fields
If validation fails, displays error message with the unsupported placeholders
Prevents saving when invalid placeholders are detected

3. Create Page Validation (`App/src/pages/workspace/reports/CreateReportFieldsPage.tsx`)

Imported validateFormula from Formula.ts
Added same validation logic in the validateForm callback when creating new formula fields
Shows validation error before field creation

4. Translation Support (`App/src/languages/params.ts`)

Added InvalidFormulaErrorParams type with placeholders: string property
Exported the type for use in language files

5. Error Messages (All language files)

Added invalidFormulaError translation string to en.ts and all other language files (es.ts, pt-BR.ts, de.ts, fr.ts, it.ts, ja.ts, nl.ts, pl.ts, zh-hans.ts)
Message displays which placeholders are invalid and suggests supported ones like {report:id}, {report:name}, {report:created}
Imported InvalidFormulaErrorParams type in all language files

Test Branch

#79899

Demo

Job added to Upwork: https://www.upwork.com/jobs/~022013597456074804416

@dominictb

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

Proposal

Restate the problem this issue is trying to solve.
Formula report fields let unsupported {report:*} placeholders (e.g., {report:i}) be saved; the server normalizes or drops them, so the field disappears from the list and the value reverts without warning on reopen.

What is the root cause of that problem?
Shared policy actions (createReportField/updateReportFieldInitialValue in src/libs/actions/Policy/ReportField.ts) never validate report-formula placeholders—they optimistically persist any string and only infer type from brace presence. Unsupported tokens reach the API, which mutates/drops them, violating the guarantee that persisted initial values use only supported formula tokens.

What changes do you think we should make in order to solve the problem?

Enforce this rule:
“A workspace report field initial value is saved only if all {report:*} placeholders are supported by the Formula evaluator.”
Add validation in Policy/ReportField.ts.
Use Formula.parse and FORMULA_PART_TYPES.
Detect unsupported report placeholders like {report:i} or invalid subfields.
Run this check before any optimistic update or API call.
Show an error on the form when validation fails.
Use Localize.translate('common.error.invalidValue', …).
Set the error on INPUT_IDS.INITIAL_VALUE with FormActions.setErrors.
Do not add new translation strings.
Export the helper for tests.
Export getUnsupportedReportFormulaParts.
Do not change its logic.
Add unit tests.
Reject {report:i}.
Allow {report:id} and {report:submit:from}.

Exact code deltas (snippets, no filepaths)

import Localize from '@libs/Localize';

// ...setErrors(
ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM,
{
    [INPUT_IDS.INITIAL_VALUE]: Localize.translate('common.error.invalidValue', {
        expectedValues:
            'report:{id,status,expensescount,type,startdate,enddate,total,reimbursable,currency,policyname,workspacename,created,submit:{from|to|date},autoreporting:{start|end}}',
    }),
}
);

// In Policy/ReportField.ts
export function getUnsupportedReportFormulaParts(initialValue?: string): string[] {
    // existing logic to parse and collect unsupported report parts
}

// tests/unit/PolicyReportFieldTest.ts
import {getUnsupportedReportFormulaParts} from '@libs/actions/Policy/ReportField';

describe('getUnsupportedReportFormulaParts', () => {
    it('rejects unsupported report token', () => {
        expect(getUnsupportedReportFormulaParts('{report:i}')).toEqual(['{report:i}']);
    });

    it('allows supported report tokens', () => {
        expect(getUnsupportedReportFormulaParts('{report:id}')).toEqual([]);
        expect(getUnsupportedReportFormulaParts('{report:submit:from}')).toEqual([]);
    });
});

What alternative solutions did you explore? (Optional)
N/A

@dominictb

@dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Reviewing label has been removed, please complete the "BugZero Checklist".

@linhvovan29546

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.59-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Report - Formula report field initial value {report:i} is not persisted & resets to {report:id} #84207

If no regressions arise, payment will be issued on 2026-04-23. 🎊

For reference, here are some details about the assignees on this issue:

@linhvovan29546 requires payment automatic offer (Contributor)
@annaweber830 requires payment (Needs manual offer from BZ)

@linhvovan29546

@linhvovan29546 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@linhvovan29546

@linhvovan29546 Eep! 4 days overdue now. Issues have feelings too...

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Awaiting Payment)

BugZero Checklist:

[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to the comment on the PR: N/A - This was not a regression. The backend already validates unsupported formula tokens, but the FW never had client-side validation for formula report field initial values. This is a missing validation edge case, not a bug introduced by a specific PR.
Link to the comment on the Issue: N/A
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A - Not critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue: https://github.com/Expensify/Expensify/issues/627940

Regression Test Proposal

Precondition:

A workspace with report fields enabled
User is logged in and has access to workspace settings

Test:

Go to workspace settings > Report Fields
Tap "Add field"
Select type: Formula
Tap "Initial value" and enter {report:i}
Verify a validation error is shown: "Formula field {report:i} not recognized"
Change the initial value to {report:id} and save
Verify the field is created successfully and appears in the fields list
Tap the created field
Tap "Initial value" and change it to {report:unknown}
Verify a validation error is shown: "Formula field {report:unknown} not recognized"
Change value back to a valid formula (e.g. {report:title}) and save
Verify the field retains the value when reopened

Do we agree 👍 or 👎

Zapier Logs

Run ID: 00040eee-ca59-a16b-0126-699fb97020d4

@annaweber830

@annaweber830 can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022047381003309283930

@twisterdotcom can you pay @annaweber830 once they've accepted the job? Can you also pay @linhvovan29546 ? Their contract is here. Thx

@linhvovan29546

Payment Summary:

@linhvovan29546 paid $250 via Upwork here
@annaweber830 paid $250 via Upwork.

@annaweber830

@annaweber830 paid, summary updated above. Thx.

Navigation Menu

Repository navigation

[Due for payment 2026-04-23] [$250] Report - Formula report field initial value {report:i} is not persisted & resets to {report:id} #79855

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

1. Formula Validation Function (`App/src/libs/Formula.ts`)

2. Edit Page Validation (`App/src/pages/workspace/reports/ReportFieldsInitialValuePage.tsx`)

3. Create Page Validation (`App/src/pages/workspace/reports/CreateReportFieldsPage.tsx`)

4. Translation Support (`App/src/languages/params.ts`)

5. Error Messages (All language files)

Test Branch

Demo

60 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const validateForm = useCallback(
	(values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM>): FormInputErrors<typeof ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM> => {
	const {initialValue: formInitialValue} = values;
	const errors: FormInputErrors<typeof ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM> = {};

	if (formInitialValue.length > CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH) {
	errors[INPUT_IDS.INITIAL_VALUE] = translate('common.error.characterLimitExceedCounter', formInitialValue.length, CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH);
	}

	if (type === CONST.REPORT_FIELD_TYPES.TEXT && !!formInitialValue && formInitialValue.length > CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH) {
	errors[INPUT_IDS.INITIAL_VALUE] = translate('common.error.characterLimitExceedCounter', formInitialValue.length, CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH);
	}

[Due for payment 2026-04-23] [$250] Report - Formula report field initial value {report:i} is not persisted & resets to {report:id} #79855

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jan 19, 2026

annaweber830 commented on Jan 19, 2026

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

abbasifaizan70 commented on Jan 19, 2026

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

1. Formula Validation Function (App/src/libs/Formula.ts)

2. Edit Page Validation (App/src/pages/workspace/reports/ReportFieldsInitialValuePage.tsx)

3. Create Page Validation (App/src/pages/workspace/reports/CreateReportFieldsPage.tsx)

4. Translation Support (App/src/languages/params.ts)

5. Error Messages (All language files)

Test Branch

Demo

melvin-bot commented on Jan 20, 2026

melvin-bot commented on Jan 20, 2026

yatin-italy commented on Jan 20, 2026

melvin-bot commented on Jan 24, 2026

60 remaining items

melvin-bot commented on Apr 16, 2026

melvin-bot commented on Apr 16, 2026

melvin-bot commented on Apr 16, 2026

melvin-bot commented on Apr 21, 2026

melvin-bot commented on Apr 22, 2026

linhvovan29546 commented on Apr 23, 2026

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

mallenexpensify commented on Apr 23, 2026

twisterdotcom commented on Apr 24, 2026

mallenexpensify commented on Apr 24, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

1. Formula Validation Function (`App/src/libs/Formula.ts`)

2. Edit Page Validation (`App/src/pages/workspace/reports/ReportFieldsInitialValuePage.tsx`)

3. Create Page Validation (`App/src/pages/workspace/reports/CreateReportFieldsPage.tsx`)

4. Translation Support (`App/src/languages/params.ts`)