Skip to content

[Due for payment 2026-01-29] Bank - Date of birth field placeholder shows YYYY-MM-DD when the new format is MM/DD/YYYY #80011

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.5-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78251
Email or phone of affected tester (no customers): applausetester+sdjois2jd@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Workspaces > Workflows.
  3. Click Add bank account.
  4. Click Connect manually.
  5. Proceed to Personal info - Date of birth step.
  6. Select a birth date.

Expected Result:

Date of birth field placeholder should be MM/DD/YYYY.

Actual Result:

Date of birth field placeholder shows YYYY-MM-DD when the new format is MM/DD/YYYY.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7054189_1768930091622.2.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @heyjennahay

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 20, 2026
  2. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #78251

  3. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Jan 20, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Jan 20, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #78251 - Fix localization: dates not being localized correctly by @sofi-a (High confidence)

    Recommendation: ROLL FORWARD

    The fix is straightforward - remove the placeholder prop from DateOfBirthStep.tsx (line 102). A revert would undo all the date localization improvements across the entire app, which would be much more disruptive than applying a simple one-line fix.

    Labels: Keeping DeployBlockerCash (App deploy is blocked). Removing DeployBlocker if present (backend is not affected).

    Evidence

    PR #78251 introduced localized date formatting throughout the app. The DatePicker component now computes placeholders dynamically based on the user's locale using Intl.DateTimeFormat.

    However, the component has a logic bug in lines 61-80 of src/components/DatePicker/index.tsx - when a placeholder prop is explicitly passed, it returns that placeholder instead of computing the localized one.

    Verification

    The DateOfBirthStep component (src/components/SubStepForms/DateOfBirthStep.tsx line 102) passes placeholder={translate('common.dateFormat')} which evaluates to YYYY-MM-DD.

    This is the only usage in the codebase that passes translate('common.dateFormat') as a placeholder to DatePicker. Because a placeholder is explicitly passed, the DatePicker uses the old YYYY-MM-DD format instead of computing the localized MM/DD/YYYY format.

    Root Cause

    When PR #78251 added locale-aware placeholder computation, it did not account for existing code that was passing the old translate('common.dateFormat') placeholder. The DatePicker's computedPlaceholder logic checks if a placeholder exists, and if so, uses it directly - bypassing the new localization logic.

    Proposed Fix

    Remove the placeholder prop from line 102 of src/components/SubStepForms/DateOfBirthStep.tsx. The DatePicker will then automatically compute the correct localized placeholder based on the user's locale.

  7. Beamanator commented on Jan 20, 2026

    @Beamanator
    Contributor

    @sofi-a @akinwale @iwiznia can y'all see if your PR #78251 caused this? And work on a revert if so?

  8. iwiznia commented on Jan 20, 2026

    @iwiznia
    Contributor

    @sofi-a can you fix this? Or we could revert the PR...

  9. Beamanator commented on Jan 21, 2026

    @Beamanator
    Contributor

    Looks like this same as in prod now

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 22, 2026
  11. changed the title [-]Bank - Date of birth field placeholder shows YYYY-MM-DD when the new format is MM/DD/YYYY[/-] [+][Due for payment 2026-01-29] Bank - Date of birth field placeholder shows YYYY-MM-DD when the new format is MM/DD/YYYY[/+] on Jan 22, 2026
  12. melvin-bot commented on Jan 22, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jan 22, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.6-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-29. 🎊

  14. melvin-bot commented on Jan 22, 2026

    @melvin-bot

    @iwiznia @heyjennahay The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions