Skip to content

[Domain Control] [Release 3] [BE] Onyx updates for vacation delegates and lock account details #80128

Closed

Description

@mountiny

Part of #76750

Description

Update the Auth backend to send proper Onyx updates for vacation delegates and lock account details. This enables the Release 3.3 (Report suspicious activity) and Release 3.4 (Vacation delegate) features.

Implementation Details

From the design doc:

Vacation Delegates

  • Update getDomainForOnyx to handle the vacation delegates
  • If the current user is a domain admin:
    • Get all members on the domain and query all of their private_vacationDelegate name value pairs
    • Add those values to the domain object
  • Update Domain::removeAdmin method in Auth to send Onyx updates to clear all the values of this NVP for the removed admin

Lock Account Details

  • Update getDomainForOnyx to handle the locked account details
  • If the current user is a domain admin:
    • Get all members on the domain and query all of their private_lockAccountDetails name value pairs
    • Add those values to the domain object if the value of the NVP is true
  • Update Domain::removeAdmin method in Auth to send Onyx updates to clear all the values of this NVP for the removed admin

Onyx Data Structure

{
    "domain_<domainAccountID>": {
        "private_vacationDelegate_<domainMemberAccountID>": {
            "delegate": "someemail@test.com",
            "creator": "someotheremail@test.com"
        },
        "expensify_lockAccountDetails_<domainMemberAccountID>": true
    }
}

Issue Owner

Current Issue Owner: @JS00001

Activity

  1. self-assigned this
    on Jan 21, 2026
  2. self-assigned this
    on Jan 21, 2026
  3. JS00001 commented on Jan 26, 2026

    @JS00001
    Contributor

    BE PR being worked on

  4. melvin-bot commented on Jan 30, 2026

    @melvin-bot

    @mountiny, @JS00001 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. mountiny commented on Jan 30, 2026

    @mountiny
    ContributorAuthor

    Done

  6. self-assigned this
    on Feb 4, 2026
  7. moved this from Done to In Progress in Bring Domain Control to NewDoton Feb 4, 2026
  8. rayane-d commented on Feb 4, 2026

    @rayane-d
    Contributor

    This is not completely done yet. The Auth PR added vacation delegates to the domain data, but we still need to add the lock account details data

  9. rayane-d commented on Feb 11, 2026

    @rayane-d
    Contributor

    Done 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions