Repository navigation
Desktop app size is 161 Mb instead 90 Mb #8014
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing #7744
Action Performed:
- Download the Desktop app .dmg and verify the size
Expected Result:
The size is close to 90 Mb
Actual Result:
The size .dmg is 161 Mb instead 90 Mb.
Workaround:
Unknown
Platform:
Where is this issue occurring?
- Desktop App
Version Number: v1.1.41-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
Activity
MelvinBot commentedon Mar 5, 2022
Triggered auto assignment to @Beamanator (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Beamanator commentedon Mar 7, 2022
@kidroca it looks like in the test steps of your PR (#7744), you mentioned:
However, when downloading I see the app as 154mb - do you think this is "close enough" to 90mb or is something else included that needs to be removed?
francoisl commentedon Mar 7, 2022
154 MB doesn't sound close enough to 90MB.
I'm thinking this might have had to do with #7987, which is now resolved. When I download the staging app now, its size is 91MB as expected, but it shows as an unsupported app and I can't install it at all.
OSBotify commentedon Mar 7, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:Beamanator commentedon Mar 7, 2022
Yeah good call that does look related - @roryabraham can you help with this issue?
Beamanator commentedon Mar 7, 2022
@francoisl which download link are you using for the staging app? I used https://staging.new.expensify.com/NewExpensify.dmg and I'm currently seeing a 154 MB app downloading - i'll try running it once it downloads
Update: I'm able to open it, no problem 🤔 - I think we can remove
DeployBlockerCashbut I'm very curious to know why it's not working for youkidroca commentedon Mar 7, 2022
@Beamanator
Sorry the requirements should have been updated
We had some problems getting the app on staging and updating after #7744
@roryabraham made some updates to fix the deploy blocker and have things more close to how they used to be
This resulted in the
universalapp being served athttps://staging.new.expensify.com/NewExpensify.dmgCurrent we serve only 1 architecture
universalapp which is 2x size to support both x64 and arm64 (160MB installer, 350MB installed)But we can also serve:
Sample build output for all targets:
kidroca commentedon Mar 7, 2022
This is not an issue, or at least it's not a deploy blocker
The desktop app being 161Mb is still 2x smaller than what we had in the past
There's a separate ticket handling x64/arm64 distribution
kidroca commentedon Mar 7, 2022
@francoisl
You can tap on "New Expensify" from the .dmg and select "Get Info" from the context menu. Check the
Kindfield :I guess M1 macs can run x64, but x64 can't run the "Apple Silicon" version
While
universalworks on bothBeamanator commentedon Mar 7, 2022
Awesome thanks for the clarification @kidroca 👍 💯
I'll close this out since, as you mentioned above, the larger size is expected, and we have another ticket discussion possible options here
francoisl commentedon Mar 7, 2022
Ok thanks for the context!