You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Domains - No RBR error on the Domain Admins page when changing primary contact fails #80206
Version Number: 9.3.6-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#79765 Email or phone of affected tester (no customers):applausetester@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Mac 26.1 / Chrome App Component: Workspace Settings
Please re-state the problem that we are trying to solve in this issue.
When changing the primary contact on the Domain Admins Settings page fails (e.g., due to network failure), no RBR error indicator appears on the Domain Admins page to guide users to the Settings RHP where the actual error is displayed.
What is the root cause of that problem?
The DomainAdminsPage subscribes to domainErrors from Onyx but only uses adminErrors for displaying errors on admin list items. The Settings button (lines 77-83) does not check for or display errors from technicalContactEmailErrors or useTechnicalContactBillingCardErrors.
While errors are properly displayed in DomainAdminsSettingsPage via OfflineWithFeedback, there's no RBR indicator on the parent page to lead users there.
What changes do you think we should make in order to solve the problem?
Add a red DotIndicator next to the Settings button when settings errors exist, following the same pattern used in DomainsListRow.
In DomainAdminsPage.tsx:
Add necessary imports and compute hasSettingsErrors:
changed the title [-]Domains - No RBR error on the Domain Admins page when changing primary contact fails[/-][+][$250] Domains - No RBR error on the Domain Admins page when changing primary contact fails[/+]on Jan 23, 2026
When changing the primary contact on the Domain Admins Settings page fails (e.g., due to network failure), no RBR error indicator appears on the Domain Admins page to guide users to the Settings RHP where the actual error is displayed.
Root Cause
The DomainAdminsPage subscribes to domainErrors from Onyx but only uses adminErrors for displaying errors on admin list items. The Settings button does not check for or display errors from technicalContactEmailErrors or useTechnicalContactBillingCardErrors.
While errors are properly displayed in DomainAdminsSettingsPage via OfflineWithFeedback, there's no RBR indicator on the parent page to lead users there.
Key code paths:
src/pages/domain/Admins/DomainAdminsPage.tsx:35-42 - domainErrors and domainPendingAction are fetched but not fully utilized
Enable "Simulate failing network requests" via CMD+D
Navigate to Workspaces -> Domain -> Domain Admins
Tap Settings button
Tap "Primary contact"
Select a different contact
Close the RHP (navigate back to Domain Admins page)
Verify: Red dot indicator appears next to Settings button
Tap Settings button again
Verify: Error message is visible on Primary contact row
Disable network failure simulation
Verify: Dot indicator disappears when errors clear
Expected Behavior
When technicalContactEmailErrors or useTechnicalContactBillingCardErrors exist, a red dot appears next to the Settings button
Clicking Settings navigates to the Settings page where the full error message is displayed
The dot disappears when errors are cleared
Works in both narrow (mobile) and wide (desktop) layouts
Alternatives Considered
Alternative 1: Full-page error banner
Display a large error banner at the top of the Domain Admins page. Rejected: Too invasive for this use case; the dot indicator pattern is already established in the codebase.
Alternative 2: Error toast notification
Show a toast message when the user returns to the page. Rejected: Toasts are transient and don't persist to guide users to the error location.
Alternative 3: Modal error dialog
Display a modal when errors are detected. Rejected: Modals interrupt user flow and are inconsistent with existing RBR patterns.
Yeah I don't mind what you have there - would it be the worst to add the red dot to the right side of the button (like where a dropdown caret would go) and leave the settings icon? (Might look wacky)
Yeah I'm with you—I actually don't hate having it on the right, it feels pretty clear to me, but I agree it looks better if we just replace the left icon. (And yeah, I don't really wanna do a custom button + dot thing here like that Figma screenshot haha)
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
melvin-bot commentedon Jan 22, 2026
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.cosmicvulpes commentedon Jan 22, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When changing the primary contact on the Domain Admins Settings page fails (e.g., due to network failure), no RBR error indicator appears on the Domain Admins page to guide users to the Settings RHP where the actual error is displayed.
What is the root cause of that problem?
The
DomainAdminsPagesubscribes todomainErrorsfrom Onyx but only usesadminErrorsfor displaying errors on admin list items. The Settings button (lines 77-83) does not check for or display errors fromtechnicalContactEmailErrorsoruseTechnicalContactBillingCardErrors.While errors are properly displayed in
DomainAdminsSettingsPageviaOfflineWithFeedback, there's no RBR indicator on the parent page to lead users there.What changes do you think we should make in order to solve the problem?
Add a red
DotIndicatornext to the Settings button when settings errors exist, following the same pattern used inDomainsListRow.In
DomainAdminsPage.tsx:hasSettingsErrors:Viewand conditionally render the RBR indicator:What alternative solutions did you explore? (Optional)
N/A
[-]Domains - No RBR error on the Domain Admins page when changing primary contact fails[/-][+][$250] Domains - No RBR error on the Domain Admins page when changing primary contact fails[/+]melvin-bot commentedon Jan 23, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022014812157853469840
melvin-bot commentedon Jan 23, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (
External)CortneyOfstad commentedon Jan 23, 2026
Hey @shubham1206agra! There is a proposal above for review – thanks!
HiepPP commentedon Jan 23, 2026
Proposal for Issue #80206
Problem
When changing the primary contact on the Domain Admins Settings page fails (e.g., due to network failure), no RBR error indicator appears on the Domain Admins page to guide users to the Settings RHP where the actual error is displayed.
Root Cause
The
DomainAdminsPagesubscribes todomainErrorsfrom Onyx but only usesadminErrorsfor displaying errors on admin list items. The Settings button does not check for or display errors fromtechnicalContactEmailErrorsoruseTechnicalContactBillingCardErrors.While errors are properly displayed in
DomainAdminsSettingsPageviaOfflineWithFeedback, there's no RBR indicator on the parent page to lead users there.Key code paths:
src/pages/domain/Admins/DomainAdminsPage.tsx:35-42-domainErrorsanddomainPendingActionare fetched but not fully utilizedsrc/pages/domain/Admins/DomainAdminsPage.tsx:77-83- Settings button lacks error indicatorsrc/pages/domain/Admins/DomainAdminsSettingsPage.tsx:58-70- Errors displayed correctly in Settingssrc/components/Domain/DomainsListRow.tsx:65-71- Reference pattern for DotIndicator usageSolution
Add a red
DotIndicatornext to the Settings button when settings errors exist, following the same pattern used inDomainsListRow.Implementation
Files Modified
src/pages/domain/Admins/DomainAdminsPage.tsx
Step 1: Add necessary imports
Add these imports after line 18:
Step 2: Add DotIndicator to icons and initialize theme
Replace line 27 with:
Add after line 29 (after
const styles = useThemeStyles();):Step 3: Compute hasSettingsErrors
Add after line 42 (after the
domainPendingActionselector):Step 4: Wrap Settings button with error indicator
Replace the Settings button (lines 77-83) with:
Complete Modified Section
Here's the complete modified
DomainAdminsPage.tsxwith all changes integrated:Testing Approach
Expected Behavior
technicalContactEmailErrorsoruseTechnicalContactBillingCardErrorsexist, a red dot appears next to the Settings buttonAlternatives Considered
Alternative 1: Full-page error banner
Display a large error banner at the top of the Domain Admins page.
Rejected: Too invasive for this use case; the dot indicator pattern is already established in the codebase.
Alternative 2: Error toast notification
Show a toast message when the user returns to the page.
Rejected: Toasts are transient and don't persist to guide users to the error location.
Alternative 3: Modal error dialog
Display a modal when errors are detected.
Rejected: Modals interrupt user flow and are inconsistent with existing RBR patterns.
References
src/components/Domain/DomainsListRow.tsx:65-71src/CONST/index.ts:4011-4014src/pages/domain/Admins/DomainAdminsPage.tsxsrc/pages/domain/Admins/DomainAdminsSettingsPage.tsx:58-70shubham1206agra commentedon Jan 25, 2026
@situchan and @war-in should take over this as a regression.
situchan commentedon Jan 25, 2026
yes assignment here @mountiny
19 remaining items
dannymcclain commentedon Feb 2, 2026
Yeah I don't mind what you have there - would it be the worst to add the red dot to the right side of the button (like where a dropdown caret would go) and leave the settings icon? (Might look wacky)
shawnborton commentedon Feb 2, 2026
Does feel a little whacky I must say, but here it is:
shawnborton commentedon Feb 2, 2026
We could do something more custom like this:
But part of me thinks just replacing the icon with a left red dot would do the trick just fine?
dannymcclain commentedon Feb 2, 2026
Yeah I'm with you—I actually don't hate having it on the right, it feels pretty clear to me, but I agree it looks better if we just replace the left icon. (And yeah, I don't really wanna do a custom button + dot thing here like that Figma screenshot haha)
dubielzyk-expensify commentedon Feb 3, 2026
Yeah I also don't mind either replacing the cog or the right dot treatment
shawnborton commentedon Feb 3, 2026
Sweet sounds good to me, I say we go with the left icon replacement idea for now. @mountiny holler if you need anything else.
mountiny commentedon Feb 4, 2026
Perfect, thank you!
melvin-bot commentedon Mar 5, 2026
This issue has not been updated in over 15 days. @shawnborton, @CortneyOfstad, @mountiny, @war-in, @situchan eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
mountiny commentedon Mar 5, 2026
This was fixed and payment is handled as part of project