You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Merchant page opens after selecting workspace chat when submitting distance expense #80280
Version Number: 9.3.7-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#76595 Email or phone of affected tester (no customers):jsiodjosjdnisojso@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.1 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to self DM.
Create a manual or map distance expense.
Click Submit it to someone.
Select workspace chat.
Expected Result:
Confirm page will open.
Actual Result:
Merchant page opens when it is a distance expense.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #76595 - "Update create transaction Manual flow to ask for merchant after asking for amount" by @nkdengineer (High confidence) Related Issues: None
Recommendation: REVERT
This PR introduced a critical logic error in the participant selection flow. When submitting distance expenses to a workspace chat, the code incorrectly navigates to the Merchant page instead of the Confirmation page. Distance expenses should skip the merchant step entirely.
However, the subsequent navigation logic ignores this check and always routes to the Merchant page when not categorizing. For distance expenses (REQUEST_TYPE.DISTANCE or REQUEST_TYPE.DISTANCE_MAP), isMerchantRequired would be false, but the user still gets sent to the Merchant page incorrectly.
The conditional logic should check isMerchantRequired before deciding whether to route to the Merchant step or Confirmation step.
Activity
melvin-bot commentedon Jan 22, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #76595
melvin-bot commentedon Jan 22, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Jan 22, 2026
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jan 22, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 22, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #76595 - "Update create transaction Manual flow to ask for merchant after asking for amount" by @nkdengineer (High confidence)
Related Issues: None
Recommendation: REVERT
This PR introduced a critical logic error in the participant selection flow. When submitting distance expenses to a workspace chat, the code incorrectly navigates to the Merchant page instead of the Confirmation page. Distance expenses should skip the merchant step entirely.
Labels: Keeping
DeployBlockerCash(App deploy blocked), removingDeployBlocker(not a backend issue)📋 Detailed Analysis
Evidence
The bug is reproducible on staging with version 9.3.7-0, which includes PR #76595. The issue report states:
PR #76595 was merged on 2026-01-22 at 16:18:30Z and modifies the participant selection flow to add merchant step for manual expenses.
Verification
The PR modifies
src/pages/iou/request/step/IOURequestStepParticipants.tsx, specifically the navigation logic after participants are selected.Root cause identified in lines 387-398:
Root Cause
Logic error:
ROUTES.MONEY_REQUEST_STEP_CATEGORY.getRoute(...)but does not assign the result to theroutevariableelseblock unconditionally setrouteto the Merchant page, regardless of whether merchant is requiredThe code at line 375 correctly determines that merchant is only required for manual expenses:
However, the subsequent navigation logic ignores this check and always routes to the Merchant page when not categorizing. For distance expenses (
REQUEST_TYPE.DISTANCEorREQUEST_TYPE.DISTANCE_MAP),isMerchantRequiredwould befalse, but the user still gets sent to the Merchant page incorrectly.The conditional logic should check
isMerchantRequiredbefore deciding whether to route to the Merchant step or Confirmation step.cead22 commentedon Jan 22, 2026
This is probably from this PR #76595. @nkdengineer can we skip the merchant page when we have a value for the merchant? cc @Krishna2323
melvin-bot commentedon Jan 22, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
cead22 commentedon Jan 23, 2026
We reverted the offending PR and CP'd it to staging. @mitarachim Can you please re-test and reopen this if the issue persists? Thanks